From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56D55D1F9D1 for ; Thu, 4 Dec 2025 12:20:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18DE710E934; Thu, 4 Dec 2025 12:20:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="h2tDufgz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCD4B10E1E0; Thu, 4 Dec 2025 12:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764850807; x=1796386807; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=l5RZdf8e/zhB+USml8d08qyw3G3+Y4U9wM9GTqIDbVM=; b=h2tDufgzOq384GWeoZqu7BwpjkE29peeKP7ZoEv6vIiQgqeAPa683eXl 3Vri+mSwFsutz05nEplJOR5z1RFQDx+e6fUq67WZEZMsJAUPaI26+LyDf TUuGNk/o81xvGfHi9z2FChoP+8xLCp8zpaNyqr5cMVDxZTDrodC8WZGM8 vdvd2gFF29y+qDmep9FXSosa2RnGAcz4Iq5RX45tH5AufmZiSaolHJNi2 RYFdS1MD1Z4JpM09rTUV8MTQLUvr/VcRQxfJlcDFn/UlqLZqxpPlZ3rrr bbTm3Yf313iZ6gJWwxTEaxGklLmujzMkj02w/dQzAV9UEU9l/hKVraIjq A==; X-CSE-ConnectionGUID: SXeXHpUKS+CDb2XeXUQ9JQ== X-CSE-MsgGUID: HysWGQlbQvKjCj3G8edgkw== X-IronPort-AV: E=McAfee;i="6800,10657,11631"; a="65864773" X-IronPort-AV: E=Sophos;i="6.20,248,1758610800"; d="scan'208";a="65864773" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2025 04:20:06 -0800 X-CSE-ConnectionGUID: VlAWi4gYRn2bzSpvUr4ppg== X-CSE-MsgGUID: jGEhN+IMSVCOOsuBr26MXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,248,1758610800"; d="scan'208";a="225928589" Received: from hrotuna-mobl2.ger.corp.intel.com (HELO [10.245.245.167]) ([10.245.245.167]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2025 04:20:00 -0800 Message-ID: Subject: Re: [PATCH] drm/xe/pf: fix VFIO link error From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= To: Arnd Bergmann , Rodrigo Vivi , David Airlie , Simona Vetter , =?UTF-8?Q?Micha=C5=82?= Winiarski , Michal Wajdeczko Cc: Arnd Bergmann , Matthew Brost , Lucas De Marchi , Jani Nikula , Riana Tauro , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Thu, 04 Dec 2025 13:19:58 +0100 In-Reply-To: <20251204094154.1029357-1-arnd@kernel.org> References: <20251204094154.1029357-1-arnd@kernel.org> Organization: Intel Sweden AB, Registration Number: 556189-6027 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-2.fc41) MIME-Version: 1.0 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 2025-12-04 at 10:41 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > The Makefile logic for building xe_sriov_vfio.o was added > incorrectly, > as setting CONFIG_XE_VFIO_PCI=3Dm means it doesn't get included into a > built-in xe driver: >=20 > ERROR: modpost: "xe_sriov_vfio_stop_copy_enter" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_stop_copy_exit" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_suspend_device" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_wait_flr_done" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_error" [drivers/vfio/pci/xe/xe-vfio- > pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_resume_data_enter" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_resume_device" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_resume_data_exit" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_data_write" [drivers/vfio/pci/xe/xe- > vfio-pci.ko] undefined! > ERROR: modpost: "xe_sriov_vfio_migration_supported" > [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined! > WARNING: modpost: suppressed 3 unresolved symbol warnings because > there were too many) >=20 > Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide > whether to > include the the object instead. s/the the/the/ found by CI. Same question here, Do you want to resent or should I fix up when commiting? Thanks, Thomas >=20 > Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO") > Signed-off-by: Arnd Bergmann > --- > =C2=A0drivers/gpu/drm/xe/Makefile | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/xe/Makefile > b/drivers/gpu/drm/xe/Makefile > index dfc2ded01455..e5f3c2ec9e9a 100644 > --- a/drivers/gpu/drm/xe/Makefile > +++ b/drivers/gpu/drm/xe/Makefile > @@ -185,8 +185,8 @@ xe-$(CONFIG_PCI_IOV) +=3D \ > =C2=A0 xe_sriov_pf_sysfs.o \ > =C2=A0 xe_tile_sriov_pf_debugfs.o > =C2=A0 > -ifeq ($(CONFIG_PCI_IOV),y) > - xe-$(CONFIG_XE_VFIO_PCI) +=3D xe_sriov_vfio.o > +ifdef CONFIG_XE_VFIO_PCI > + xe-$(CONFIG_PCI_IOV) +=3D xe_sriov_vfio.o > =C2=A0endif > =C2=A0 > =C2=A0# include helpers for tests even when XE is built-in