Re: [PATCH v2 2/3] drm/xe: Move TLB invalidation reset before HW reset

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10.01.2024 00:01, Matthew Brost wrote:
> This is a software reset which can be done immediately after stopping
> the UC.

IMO there is too tight relation between TLB invalidation code and CT
internals (TLB code uses internal CT locks) but since this is not new:

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 3af2adec1295..c647f41b2751 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -619,12 +619,12 @@ static int gt_reset(struct xe_gt *gt)
>  	if (err)
>  		goto err_out;
>  
> +	xe_gt_tlb_invalidation_reset(gt);
> +
>  	err = do_gt_reset(gt);
>  	if (err)
>  		goto err_out;
>  
> -	xe_gt_tlb_invalidation_reset(gt);
> -
>  	err = do_gt_restart(gt);
>  	if (err)
>  		goto err_out;