From: Nirmoy Das <nirmoy.das@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-xe@lists.freedesktop.org
Cc: Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH] drm/xe/guc_submit: use jiffies for job timeout
Date: Thu, 14 Mar 2024 13:34:09 +0100 [thread overview]
Message-ID: <c3d85eb3-b850-4ecc-bbd1-089e60f47533@linux.intel.com> (raw)
In-Reply-To: <20240314121554.223229-2-matthew.auld@intel.com>
On 3/14/2024 1:15 PM, Matthew Auld wrote:
> drm_sched_init() expects jiffies for the timeout, but here we are
> passing the timeout in ms. Convert to jiffies instead.
>
> Fixes: eef55700f302 ("drm/xe: Add sysfs for default engine scheduler properties")
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 19efdb2f881f..82c955a2a15c 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1226,7 +1226,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
> init_waitqueue_head(&ge->suspend_wait);
>
> timeout = (q->vm && xe_vm_in_lr_mode(q->vm)) ? MAX_SCHEDULE_TIMEOUT :
> - q->sched_props.job_timeout_ms;
> + msecs_to_jiffies(q->sched_props.job_timeout_ms);
> err = xe_sched_init(&ge->sched, &drm_sched_ops, &xe_sched_ops,
> get_submit_wq(guc),
> q->lrc[0].ring.size / MAX_JOB_SIZE_BYTES, 64,
next prev parent reply other threads:[~2024-03-14 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 12:15 [PATCH] drm/xe/guc_submit: use jiffies for job timeout Matthew Auld
2024-03-14 12:20 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-14 12:20 ` ✓ CI.checkpatch: " Patchwork
2024-03-14 12:21 ` ✓ CI.KUnit: " Patchwork
2024-03-14 12:32 ` ✓ CI.Build: " Patchwork
2024-03-14 12:34 ` Nirmoy Das [this message]
2024-03-14 12:34 ` ✓ CI.Hooks: " Patchwork
2024-03-14 12:36 ` ✓ CI.checksparse: " Patchwork
2024-03-14 13:00 ` ✗ CI.BAT: failure " Patchwork
2024-03-14 16:15 ` [PATCH] " Matthew Brost
2024-03-14 17:23 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3d85eb3-b850-4ecc-bbd1-089e60f47533@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox