Re: [PATCH] drm/i915/colorop: do not include headers from headers

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 12/18/2025 7:48 PM, Jani Nikula wrote:
> drm_colorop.h doesn't need the intel_display_types.h include for
> anything. Don't include headers from headers if it can be avoided.
> 

LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Fixes: 3e9b06559aa1 ("drm/i915: Add intel_color_op")
> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
> Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_colorop.c | 2 ++
>   drivers/gpu/drm/i915/display/intel_colorop.h | 4 +++-
>   2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_colorop.c b/drivers/gpu/drm/i915/display/intel_colorop.c
> index f2fc0d8780ce..1d84933f05aa 100644
> --- a/drivers/gpu/drm/i915/display/intel_colorop.c
> +++ b/drivers/gpu/drm/i915/display/intel_colorop.c
> @@ -2,7 +2,9 @@
>   /*
>    * Copyright © 2025 Intel Corporation
>    */
> +
>   #include "intel_colorop.h"
> +#include "intel_display_types.h"
>   
>   struct intel_colorop *to_intel_colorop(struct drm_colorop *colorop)
>   {
> diff --git a/drivers/gpu/drm/i915/display/intel_colorop.h b/drivers/gpu/drm/i915/display/intel_colorop.h
> index 21d58eb9f3d0..9276eee6e75a 100644
> --- a/drivers/gpu/drm/i915/display/intel_colorop.h
> +++ b/drivers/gpu/drm/i915/display/intel_colorop.h
> @@ -6,7 +6,9 @@
>   #ifndef __INTEL_COLOROP_H__
>   #define __INTEL_COLOROP_H__
>   
> -#include "intel_display_types.h"
> +enum intel_color_block;
> +struct drm_colorop;
> +struct intel_colorop;
>   
>   struct intel_colorop *to_intel_colorop(struct drm_colorop *colorop);
>   struct intel_colorop *intel_colorop_alloc(void);