Re: [PATCH] drm/xe/migrate: Fix an error path

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Wed, 2025-10-08 at 13:55 +0200, Francois Dugast wrote:
> On Wed, Sep 10, 2025 at 06:09:39PM +0200, Thomas Hellström wrote:
> > The exhaustive eviction accidently changed an error path goto to
> > a return. Fix this.
> > 
> > Fixes: 59eabff2a352 ("drm/xe: Convert xe_bo_create_pin_map() for
> > exhaustive eviction")
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> 
> Reviewed-by: Francois Dugast <francois.dugast@intel.com>

Thanks, Francois!
/Thomas


> 
> > ---
> >  drivers/gpu/drm/xe/xe_migrate.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_migrate.c
> > b/drivers/gpu/drm/xe/xe_migrate.c
> > index 6fad5d469629..1ffff251d763 100644
> > --- a/drivers/gpu/drm/xe/xe_migrate.c
> > +++ b/drivers/gpu/drm/xe/xe_migrate.c
> > @@ -425,7 +425,7 @@ int xe_migrate_init(struct xe_migrate *m)
> >  		xe_validation_retry_on_oom(&ctx, &err);
> >  	}
> >  	if (err)
> > -		return err;
> > +		goto err_out;
> >  
> >  	if (xe->info.has_usm) {
> >  		struct xe_hw_engine *hwe =
> > xe_gt_hw_engine(primary_gt,
> > -- 
> > 2.51.0
> >