From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v7 5/5] drm/xe: Remove xe_ggtt_node_allocated
Date: Fri, 30 Jan 2026 01:20:17 +0100 [thread overview]
Message-ID: <c5f5731f-5337-4c97-82ab-8392e9338b1c@intel.com> (raw)
In-Reply-To: <20260128165724.12587-6-dev@lankhorst.se>
On 1/28/2026 5:57 PM, Maarten Lankhorst wrote:
> With the intermediate state gone, no longer useful. Just check against
> NULL where needed.
>
> After looking carefully, the check for allocated in xe_fb_pin.c is
> unneeded. vma->node is never NULL. The check is specifically only
> to check if vma->node == the bo's root tile ggtt_obj.
>
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> Changelog:
> - Update commit message to explain the change in xe_fb_pin.c
> ---
next prev parent reply other threads:[~2026-01-30 0:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 16:57 [PATCH v7 0/5] drm/xe: Privatize struct xe_ggtt Maarten Lankhorst
2026-01-28 16:57 ` [PATCH v7 1/5] drm/xe: Make xe_ggtt_node offset relative to starting offset Maarten Lankhorst
2026-01-28 16:57 ` [PATCH v7 2/5] drm/xe: Rewrite GGTT VF initialization Maarten Lankhorst
2026-01-30 0:18 ` Michal Wajdeczko
2026-01-28 16:57 ` [PATCH v7 3/5] drm/xe: Move struct xe_ggtt to xe_ggtt.c Maarten Lankhorst
2026-01-28 16:57 ` [PATCH v7 4/5] drm/xe: Make xe_ggtt_node_insert return a node Maarten Lankhorst
2026-01-28 16:57 ` [PATCH v7 5/5] drm/xe: Remove xe_ggtt_node_allocated Maarten Lankhorst
2026-01-30 0:20 ` Michal Wajdeczko [this message]
2026-01-28 20:28 ` ✗ CI.checkpatch: warning for drm/xe: Privatize struct xe_ggtt. (rev5) Patchwork
2026-01-28 20:29 ` ✓ CI.KUnit: success " Patchwork
2026-01-28 21:17 ` ✗ Xe.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5f5731f-5337-4c97-82ab-8392e9338b1c@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox