From: Matthew Auld <matthew.auld@intel.com>
To: Matthew Brost <matthew.brost@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe: Use local fence in error path of xe_migrate_clear
Date: Wed, 12 Mar 2025 09:49:49 +0000 [thread overview]
Message-ID: <c65c1209-7a1b-4a83-a299-856db2617e3d@intel.com> (raw)
In-Reply-To: <20250311182915.3606291-1-matthew.brost@intel.com>
On 11/03/2025 18:29, Matthew Brost wrote:
> The intent of the error path in xe_migrate_clear is to wait on locally
> generated fence and then return. The code is waiting on m->fence which
> could be the local fence but this is only stable under the job mutex
> leading to a possible UAF. Fix code to wait on local fence.
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2025-03-12 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 18:29 [PATCH] drm/xe: Use local fence in error path of xe_migrate_clear Matthew Brost
2025-03-11 21:14 ` ✓ CI.Patch_applied: success for " Patchwork
2025-03-11 21:15 ` ✓ CI.checkpatch: " Patchwork
2025-03-11 21:16 ` ✓ CI.KUnit: " Patchwork
2025-03-11 21:32 ` ✓ CI.Build: " Patchwork
2025-03-11 21:35 ` ✓ CI.Hooks: " Patchwork
2025-03-11 21:36 ` ✓ CI.checksparse: " Patchwork
2025-03-11 21:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-12 9:49 ` Matthew Auld [this message]
2025-03-12 13:18 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c65c1209-7a1b-4a83-a299-856db2617e3d@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox