Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Govindapillai, Vinod" <vinod.govindapillai@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Nikula, Jani" <jani.nikula@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [RESEND 3/6] drm/i915/wm: DG2 doesn't have dram info to look up wm_lv_0_adjust_needed
Date: Wed, 4 Jun 2025 13:33:14 +0000	[thread overview]
Message-ID: <c8088aeeee1a64fd66c02eb1e3116b02b39daced.camel@intel.com> (raw)
In-Reply-To: <a866641bff364dcfcaaabaa1d53c4a8cfa94ff3f.1748337870.git.jani.nikula@intel.com>

On Tue, 2025-05-27 at 12:25 +0300, Jani Nikula wrote:
> There's no dram info on DG2 that we could use. The struct dram_info is
> all zero on it, but be explicit about this.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/skl_watermark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> b/drivers/gpu/drm/i915/display/skl_watermark.c
> index f5600f4b7772..817939f6d4dd 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -3251,7 +3251,7 @@ adjust_wm_latency(struct intel_display *display,
>  	 * any underrun. If not able to get Dimm info assume 16GB dimm
>  	 * to avoid any underrun.
>  	 */
> -	if (dram_info->wm_lv_0_adjust_needed)
> +	if (!display->platform.dg2 && dram_info->wm_lv_0_adjust_needed)

For Disp version >= 12, wm_lv_0_adjust_needed is hard coded to false. So I don't think this explicit
DG2 check is needed here.. 

with that,

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>



>  		wm[0] += 1;
>  }
>  


  reply	other threads:[~2025-06-04 13:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-27  9:25 [RESEND 0/6] drm/i915/dram: dram_info refactoring Jani Nikula
2025-05-27  9:25 ` [RESEND 1/6] drm/i915/bw: pass struct dram_info pointer around Jani Nikula
2025-06-04 12:45   ` Govindapillai, Vinod
2025-06-04 16:14     ` Jani Nikula
2025-05-27  9:25 ` [RESEND 2/6] drm/i915/dram: add accessor for struct dram_info and use it Jani Nikula
2025-06-04 12:54   ` Govindapillai, Vinod
2025-05-27  9:25 ` [RESEND 3/6] drm/i915/wm: DG2 doesn't have dram info to look up wm_lv_0_adjust_needed Jani Nikula
2025-06-04 13:33   ` Govindapillai, Vinod [this message]
2025-06-04 13:41     ` Govindapillai, Vinod
2025-06-04 13:45     ` Jani Nikula
2025-05-27  9:25 ` [RESEND 4/6] drm/i915/dram: pass struct dram_info pointer around Jani Nikula
2025-06-04 13:37   ` Govindapillai, Vinod
2025-05-27  9:25 ` [RESEND 5/6] drm/i915/dram: add return value and handling to intel_dram_detect() Jani Nikula
2025-06-04 13:53   ` Govindapillai, Vinod
2025-05-27  9:25 ` [RESEND 6/6] drm/i915/dram: allocate struct dram_info dynamically Jani Nikula
2025-06-04 14:24   ` Govindapillai, Vinod
2025-05-27 16:08 ` ✓ CI.Patch_applied: success for drm/i915/dram: dram_info refactoring (rev2) Patchwork
2025-05-27 16:08 ` ✓ CI.checkpatch: " Patchwork
2025-05-27 16:09 ` ✓ CI.KUnit: " Patchwork
2025-05-27 16:23 ` ✓ CI.Build: " Patchwork
2025-05-27 16:24 ` ✓ CI.Hooks: " Patchwork
2025-05-27 16:26 ` ✓ CI.checksparse: " Patchwork
2025-05-27 16:57 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-27 19:06 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8088aeeee1a64fd66c02eb1e3116b02b39daced.camel@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox