From: Julia Filipchuk <julia.filipchuk@intel.com>
To: Zhanjun Dong <zhanjun.dong@intel.com>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v8 4/6] drm/xe/guc: Add GuC log event buffer output in LFD format
Date: Thu, 4 Dec 2025 12:55:20 -0800 [thread overview]
Message-ID: <c9ceb550-114d-43d6-a2b7-6db71378227a@intel.com> (raw)
In-Reply-To: <20251127170759.2620994-5-zhanjun.dong@intel.com>
On 11/27/2025 9:07 AM, Zhanjun Dong wrote:
> +static void
> +xe_guc_log_print_chunks(struct drm_printer *p, struct xe_guc_log_snapshot *snapshot,
> + u32 from, u32 to)
> +{
> + int chunk_from = from % GUC_LOG_CHUNK_SIZE;
> + int chunk_id = from / GUC_LOG_CHUNK_SIZE;
> + int to_chunk_id = to / GUC_LOG_CHUNK_SIZE;
> + int chunk_to = to % GUC_LOG_CHUNK_SIZE;
> + int pos = from;
> +
> + do {
> + size_t size = (to_chunk_id == chunk_id ? chunk_to : GUC_LOG_CHUNK_SIZE) -
> + chunk_from;
This check now uses '==' and expected '>=' based on previous discussion. With
the order of ternary reversed this looks to be correct since to_chunk_id is
never larger than chunk_id.
LGTM
Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
next prev parent reply other threads:[~2025-12-04 20:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 17:07 [PATCH v8 0/6] drm/xe/guc: Add LFD format output for guc log Zhanjun Dong
2025-11-27 17:07 ` [PATCH v8 1/6] drm/xe/guc: Add log init config abi definitions Zhanjun Dong
2025-11-27 17:07 ` [PATCH v8 2/6] drm/xe/guc: Add LFD related " Zhanjun Dong
2025-11-27 17:07 ` [PATCH v8 3/6] drm/xe/guc: Add GuC log init config in LFD format Zhanjun Dong
2025-11-27 17:07 ` [PATCH v8 4/6] drm/xe/guc: Add GuC log event buffer output " Zhanjun Dong
2025-12-04 20:55 ` Julia Filipchuk [this message]
2025-11-27 17:07 ` [PATCH v8 5/6] drm/xe/guc: Only add GuC crash dump if available Zhanjun Dong
2025-12-04 20:41 ` Julia Filipchuk
2025-11-27 17:07 ` [PATCH v8 6/6] drm/xe/guc: Add new debugfs entry for lfd format output Zhanjun Dong
2025-11-27 19:06 ` ✗ CI.checkpatch: warning for drm/xe/guc: Add LFD format output for guc log (rev8) Patchwork
2025-11-27 19:08 ` ✓ CI.KUnit: success " Patchwork
2025-11-27 20:22 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-27 22:18 ` ✗ Xe.CI.Full: failure " Patchwork
2025-12-04 21:25 ` Dong, Zhanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9ceb550-114d-43d6-a2b7-6db71378227a@intel.com \
--to=julia.filipchuk@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox