From: "Laguna, Lukasz" <lukasz.laguna@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [2/2] drm/xe/pf: Print configuration KLVs using debug printer
Date: Tue, 10 Jun 2025 08:11:02 +0200 [thread overview]
Message-ID: <c9e93180-72a0-4c33-99df-e699cd05dcc0@intel.com> (raw)
In-Reply-To: <20250604190021.725-3-michal.wajdeczko@intel.com>
On 6/4/2025 21:00, Michal Wajdeczko wrote:
> While we print VF's configuration KLVs only under DEBUG_SRIOV
> config, we should be doing it at debug level, not info level.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> index 3556c41c041b..3128d9adc10e 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> @@ -104,13 +104,13 @@ static int pf_push_vf_buf_klvs(struct xe_gt *gt, unsigned int vfid, u32 num_klvs
> }
>
> if (IS_ENABLED(CONFIG_DRM_XE_DEBUG_SRIOV)) {
> - struct drm_printer p = xe_gt_info_printer(gt);
> + struct drm_printer p = xe_gt_dbg_printer(gt);
> void *klvs = xe_guc_buf_cpu_ptr(buf);
> char name[8];
>
> - xe_gt_sriov_info(gt, "pushed %s config with %u KLV%s:\n",
> - xe_sriov_function_name(vfid, name, sizeof(name)),
> - num_klvs, str_plural(num_klvs));
> + xe_gt_sriov_dbg(gt, "pushed %s config with %u KLV%s:\n",
> + xe_sriov_function_name(vfid, name, sizeof(name)),
> + num_klvs, str_plural(num_klvs));
> xe_guc_klv_print(klvs, num_dwords, &p);
> }
>
Shouldn't xe_gt_sriov_pf_config_restore() be updated in the same way on
the occasion?
next prev parent reply other threads:[~2025-06-10 6:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 19:00 [PATCH 0/2] PF: Print debug stuff using debug printer Michal Wajdeczko
2025-06-04 19:00 ` [PATCH 1/2] drm/xe/pf: Print runtime registers " Michal Wajdeczko
2025-06-10 6:00 ` [1/2] " Laguna, Lukasz
2025-06-04 19:00 ` [PATCH 2/2] drm/xe/pf: Print configuration KLVs " Michal Wajdeczko
2025-06-10 6:11 ` Laguna, Lukasz [this message]
2025-07-03 14:57 ` [PATCH v2 " Michal Wajdeczko
2025-07-10 8:57 ` Laguna, Lukasz
2025-06-04 21:57 ` ✓ CI.Patch_applied: success for PF: Print debug stuff " Patchwork
2025-06-04 21:58 ` ✓ CI.checkpatch: " Patchwork
2025-06-04 21:59 ` ✓ CI.KUnit: " Patchwork
2025-06-04 22:09 ` ✓ CI.Build: " Patchwork
2025-06-04 22:12 ` ✓ CI.Hooks: " Patchwork
2025-06-04 22:13 ` ✓ CI.checksparse: " Patchwork
2025-06-04 23:24 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-05 23:43 ` ✓ Xe.CI.Full: " Patchwork
2025-06-06 8:20 ` ✗ Xe.CI.Full: failure " Patchwork
2025-07-03 15:58 ` ✓ CI.KUnit: success for PF: Print debug stuff using debug printer (rev2) Patchwork
2025-07-03 16:51 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-05 5:53 ` ✗ Xe.CI.Full: failure " Patchwork
2025-07-10 12:06 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9e93180-72a0-4c33-99df-e699cd05dcc0@intel.com \
--to=lukasz.laguna@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox