From: "Michał Grzelak" <michal.grzelak@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 6/6] drm/i915/cdclk: Use the TGL+ CD2x pipe select bits also on ICL
Date: Tue, 16 Jun 2026 10:26:57 +0200 (CEST) [thread overview]
Message-ID: <cd373ac6-04aa-3fe0-bb67-a25c906ea5f2@intel.com> (raw)
In-Reply-To: <20260612173653.7830-7-ville.syrjala@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On Fri, 12 Jun 2026, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Turns out both CDCLK_CTL pipe select 0b110 (what Bspec lists for
> pipe C on ICL) and 0b100 (what BSpec lists for pipe C on TGL+)
> actually select pipe C on ICL. So we can get rid of the weird
> ICL special case and just use the simpler TGL+ definition of
> the pipe select bits.
>
> This was reverse engineered with a hacked up intel_display_poller.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>
BR,
Michał
next prev parent reply other threads:[~2026-06-16 8:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 17:36 [PATCH 0/6] drm/i915/cdclk: CDCLK sanitization stuff Ville Syrjala
2026-06-12 17:36 ` [PATCH 1/6] drm/i915/cdclk: Fix up CDCLK_FREQ_DECIMAL without a full PLL re-enable Ville Syrjala
2026-06-16 8:25 ` Michał Grzelak
2026-06-12 17:36 ` [PATCH 2/6] drm/i915/cdclk: Print the reason for the CDCLK sanitization Ville Syrjala
2026-06-16 8:25 ` Michał Grzelak
2026-06-12 17:36 ` [PATCH 3/6] drm/i915/cdclk Clean up CDCLK_CTL defines Ville Syrjala
2026-06-16 8:26 ` Michał Grzelak
2026-06-12 17:36 ` [PATCH 4/6] drm/i915/cdclk: Document CDCLK_CTL bits Ville Syrjala
2026-06-16 8:26 ` Michał Grzelak
2026-06-12 17:36 ` [PATCH 6/6] drm/i915/cdclk: Use the TGL+ CD2x pipe select bits also on ICL Ville Syrjala
2026-06-16 8:26 ` Michał Grzelak [this message]
2026-06-12 18:43 ` ✗ CI.checkpatch: warning for drm/i915/cdclk: CDCLK sanitization stuff Patchwork
2026-06-12 18:45 ` ✓ CI.KUnit: success " Patchwork
2026-06-12 19:38 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-13 12:38 ` ✗ Xe.CI.FULL: failure " Patchwork
[not found] ` <20260612173653.7830-6-ville.syrjala@linux.intel.com>
2026-06-16 8:26 ` [PATCH 5/6] drm/i915/cdclk: Introduce bxt_cdclk_cd2x_pipe_mask() and use it Michał Grzelak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd373ac6-04aa-3fe0-bb67-a25c906ea5f2@intel.com \
--to=michal.grzelak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox