From: "Knop, Ryszard" <ryszard.knop@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"Auld, Matthew" <matthew.auld@intel.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Brost, Matthew" <matthew.brost@intel.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"airlied@redhat.com" <airlied@redhat.com>
Subject: Re: drm/ttm/tests: fix lru_count ASSERT
Date: Thu, 9 Apr 2026 12:07:48 +0000 [thread overview]
Message-ID: <cd648ad183c346a8a71d84f929c1d4fe5468ad4c.camel@intel.com> (raw)
In-Reply-To: <20260409111032.72141-2-matthew.auld@intel.com>
LGTM, verified locally this fixes 2 KUnit errors. A few missing
expected subtests still remain though.
Reviewed-by: Ryszard Knop <ryszard.knop@intel.com>
On Thu, 2026-04-09 at 12:10 +0100, Matthew Auld wrote:
> On pool init we should expect the lru_count for each node to be zeroed
> as per __list_lru_init -> init_one_lru, but here we are asserting the
> opposite.
>
> Currently our CI is blowing up with:
>
> 10:23:33] # ttm_device_init_pools: ASSERTION FAILED at drivers/gpu/drm/ttm/tests/ttm_device_test.c:178
> [10:23:33] Expected !list_lru_count(&pt.pages) to be false, but is true
> [10:23:33] [FAILED] DMA allocations, DMA32 required
> [10:23:33] [PASSED] No DMA allocations, DMA32 required
> [10:23:33] # ttm_device_init_pools: ASSERTION FAILED at drivers/gpu/drm/ttm/tests/ttm_device_test.c:178
> [10:23:33] Expected !list_lru_count(&pt.pages) to be false, but is true
>
> Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)")
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/ttm/tests/ttm_device_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> index db4b4a09a73f..8bcac84e9846 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
> @@ -176,7 +176,7 @@ static void ttm_device_init_pools(struct kunit *test)
>
> if (ttm_pool_uses_dma_alloc(pool))
> KUNIT_ASSERT_FALSE(test,
> - !list_lru_count(&pt.pages));
> + list_lru_count(&pt.pages));
> }
> }
> }
next prev parent reply other threads:[~2026-04-09 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 11:10 [PATCH] drm/ttm/tests: fix lru_count ASSERT Matthew Auld
2026-04-09 11:16 ` ✗ CI.checkpatch: warning for " Patchwork
2026-04-09 11:17 ` ✗ CI.KUnit: failure " Patchwork
2026-04-09 12:07 ` Knop, Ryszard [this message]
2026-04-09 12:18 ` [PATCH] " Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd648ad183c346a8a71d84f929c1d4fe5468ad4c.camel@intel.com \
--to=ryszard.knop@intel.com \
--cc=airlied@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox