Re: [PATCH 1/2] drm/i915/display: drop a few unnecessary i915_drv.h includes

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 23 Oct 2025, "Hogander, Jouni" <jouni.hogander@intel.com> wrote:
> On Wed, 2025-10-22 at 15:14 +0300, Jani Nikula wrote:
>> We've stopped using struct drm_i915_private in intel_fb.c and
>> skl_universal_plane.c, so we can drop the i915_drv.h includes.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

Thanks for the reviews, pushed to din.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_fb.c            | 1 -
>>  drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 ++-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c
>> b/drivers/gpu/drm/i915/display/intel_fb.c
>> index 3958628c73e9..6ade38198f39 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fb.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
>> @@ -10,7 +10,6 @@
>>  #include <drm/drm_gem.h>
>>  #include <drm/drm_modeset_helper.h>
>>  
>> -#include "i915_drv.h"
>>  #include "i915_utils.h"
>>  #include "intel_bo.h"
>>  #include "intel_display.h"
>> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> b/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> index 0319174adf95..765d288cce2b 100644
>> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> @@ -7,9 +7,9 @@
>>  #include <drm/drm_blend.h>
>>  #include <drm/drm_damage_helper.h>
>>  #include <drm/drm_fourcc.h>
>> +#include <drm/drm_print.h>
>>  
>>  #include "pxp/intel_pxp.h"
>> -#include "i915_drv.h"
>>  #include "i915_utils.h"
>>  #include "intel_bo.h"
>>  #include "intel_de.h"
>> @@ -24,6 +24,7 @@
>>  #include "intel_plane.h"
>>  #include "intel_psr.h"
>>  #include "intel_psr_regs.h"
>> +#include "intel_step.h"
>>  #include "skl_scaler.h"
>>  #include "skl_universal_plane.h"
>>  #include "skl_universal_plane_regs.h"
>

-- 
Jani Nikula, Intel