Re: [PATCH 1/2] drm/xe/guc: Drop unused legacy GuC message ABI definitions

[Nirmoy Das <nirmoy.das@linux.intel.com>]

On 6/10/2024 2:04 PM, Michal Wajdeczko wrote:
> Those were copy-pasted from i915 code and never used in Xe driver.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>


> ---
>   drivers/gpu/drm/xe/abi/guc_messages_abi.h | 13 -------------
>   1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/abi/guc_messages_abi.h b/drivers/gpu/drm/xe/abi/guc_messages_abi.h
> index 534a39db7772..e32142e3fe41 100644
> --- a/drivers/gpu/drm/xe/abi/guc_messages_abi.h
> +++ b/drivers/gpu/drm/xe/abi/guc_messages_abi.h
> @@ -220,17 +220,4 @@
>   #define GUC_HXG_RESPONSE_MSG_0_DATA0		GUC_HXG_MSG_0_AUX
>   #define GUC_HXG_RESPONSE_MSG_n_DATAn		GUC_HXG_MSG_n_PAYLOAD
>   
> -/* deprecated */
> -#define INTEL_GUC_MSG_TYPE_SHIFT	28
> -#define INTEL_GUC_MSG_TYPE_MASK		(0xF << INTEL_GUC_MSG_TYPE_SHIFT)
> -#define INTEL_GUC_MSG_DATA_SHIFT	16
> -#define INTEL_GUC_MSG_DATA_MASK		(0xFFF << INTEL_GUC_MSG_DATA_SHIFT)
> -#define INTEL_GUC_MSG_CODE_SHIFT	0
> -#define INTEL_GUC_MSG_CODE_MASK		(0xFFFF << INTEL_GUC_MSG_CODE_SHIFT)
> -
> -enum intel_guc_msg_type {
> -	INTEL_GUC_MSG_TYPE_REQUEST = 0x0,
> -	INTEL_GUC_MSG_TYPE_RESPONSE = 0xF,
> -};
> -
>   #endif