Re: [PATCH v6 4/7] drm/xe: Convert multiple bind ops into single job

[Matthew Auld <matthew.auld@intel.com>]

On 26/06/2024 22:15, Matthew Brost wrote:
> This aligns with the uAPI of an array of binds or single bind that
> results in multiple GPUVA ops to be considered a single atomic
> operations.
> 
> The bind-array-enobufs is roughly:
> - xe_vma_ops is a list of xe_vma_op (GPUVA op)
> - each xe_vma_op resolves to 0-3 PT ops
> - xe_vma_ops creates a single job
> - if at any point during binding a failure occurs, xe_vma_ops contains
>    the information necessary unwind the PT and VMA (GPUVA) state
> 
> v2:
>   - add missing dma-resv slot reservation (CI, testing)
> v4:
>   - Fix TLB invalidation (Paulo)
>   - Add missing xe_sched_job_last_fence_add/test_dep check (Inspection)
> v5:
>   - Invert i, j usage (Matthew Auld)
>   - Add helper to test and add job dep (Matthew Auld)
>   - Return on anything but -ETIME for cpu bind (Matthew Auld)
>   - Return -ENOBUFS if suballoc of BB fails due to size (Matthew Auld)
>   - s/do/Do (Matthew Auld)
>   - Add missing comma (Matthew Auld)
>   - Do not assign return value to xe_range_fence_insert (Matthew Auld)
> v6:
>   - s/0x1ff/MAX_PTE_PER_SDI (Matthew Auld, CI)
>   - Check to large of SA in Xe to avoid triggering WARN (Matthew Auld)
>   - Fix checkpatch issues
> 
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Auld <matthew.auld@intel.com>