From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF976C5321E for ; Mon, 26 Aug 2024 16:45:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A6CE10E24E; Mon, 26 Aug 2024 16:45:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="X+oNNBAT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 192E810E24E for ; Mon, 26 Aug 2024 16:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724690740; x=1756226740; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EYrd1jfwbmLHZ8mh491PCQak+B6WD20AQzXXqYHBKWc=; b=X+oNNBATxGzDndBHNKF8wyTjoDbLx7NxlPkfiIAvgHBm6lR2il1k49k/ aRz0yB4lX/AYCWdpVZcTwY7ul4KyYn6yl9yixWOq519XYCw+ifvLqWsCs WN2D+VcD8ran0dmCW1EsYaGH/eHbg27UdTAV4Uz+j//ms06VGheJeC3Ke X808ufKRNtEMth/X6JQnPZYVWAOpQRZhQjasHz7vyhBmX5tOb2Nsjm/Rh MhAobZAApyhA8BjQBGaptDzsHaQes458g1BQaYE4YXi2s4dnrgc3ddcDo aZB016eVWEGl367G3t8zLnu/Llygkh3zgw9SY7GgGH9e40YU9lrEbuDoc A==; X-CSE-ConnectionGUID: IImaV8PaTS+Lzx40+SLfTw== X-CSE-MsgGUID: zRUT5CjJRLyvoXKCOHv9TQ== X-IronPort-AV: E=McAfee;i="6700,10204,11176"; a="26922503" X-IronPort-AV: E=Sophos;i="6.10,178,1719903600"; d="scan'208";a="26922503" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2024 09:45:39 -0700 X-CSE-ConnectionGUID: nyz/x6n/RzOvNOi01e71YA== X-CSE-MsgGUID: 8nnHs0NUToSjHOUbQZpgzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,178,1719903600"; d="scan'208";a="62561848" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.246.18.111]) ([10.246.18.111]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2024 09:45:37 -0700 Message-ID: Date: Mon, 26 Aug 2024 18:45:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2.5] drm/xe/eudebug: implement userptr_vma access To: Matthew Brost Cc: Mika Kuoppala , intel-xe@lists.freedesktop.org, Maciej Patelczyk , Jonathan Cavitt References: <20240826144000.302353-1-andrzej.hajda@intel.com> Content-Language: en-US From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20240826144000.302353-1-andrzej.hajda@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 26.08.2024 16:40, Andrzej Hajda wrote: > Debugger needs to read/write program's vmas including userptr_vma. > > v2.5: use access_process_vm > > Signed-off-by: Andrzej Hajda > Signed-off-by: Maciej Patelczyk > Signed-off-by: Mika Kuoppala > Reviewed-by: Jonathan Cavitt Ups, these three tags are not valid in this case. Regards Andrzej > --- > Hi Matthew, > > With recent changes in drm(?) v1 and v2 versions do not work anymore. > I am wondering if using access_process_vm could be alternative approach, > at least igt tests do not fail :) > > Regards > Andrzej > --- > drivers/gpu/drm/xe/xe_eudebug.c | 2 +- > drivers/gpu/drm/xe/xe_vm.c | 12 ++++++++++++ > drivers/gpu/drm/xe/xe_vm.h | 3 +++ > 3 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_eudebug.c b/drivers/gpu/drm/xe/xe_eudebug.c > index 7e62b0ffca83..39b33bb7893d 100644 > --- a/drivers/gpu/drm/xe/xe_eudebug.c > +++ b/drivers/gpu/drm/xe/xe_eudebug.c > @@ -3392,7 +3392,7 @@ static int xe_eudebug_vma_access(struct xe_vma *vma, u64 offset, > if (bo) > return xe_eudebug_bovma_access(bo, offset, buf, bytes, write); > > - return -EOPNOTSUPP; > + return xe_uvma_access(to_userptr_vma(vma), offset, buf, bytes, write); > } > > static int xe_eudebug_vm_access(struct xe_vm *vm, u64 offset, > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c > index ec4dd2c611d3..ee6e2ee078f9 100644 > --- a/drivers/gpu/drm/xe/xe_vm.c > +++ b/drivers/gpu/drm/xe/xe_vm.c > @@ -3607,3 +3607,15 @@ void xe_vm_snapshot_free(struct xe_vm_snapshot *snap) > } > kvfree(snap); > } > + > +int xe_uvma_access(struct xe_userptr_vma *uvma, u64 offset, > + void *buf, u64 len, bool write) > +{ > + struct mm_struct *mm = uvma->userptr.notifier.mm; > + unsigned long addr = uvma->vma.gpuva.gem.offset; > + > + if (!mm || !mm->owner) > + return -EINVAL; > + > + return access_process_vm(mm->owner, addr, buf, len, write ? FOLL_WRITE : 0); > +} > diff --git a/drivers/gpu/drm/xe/xe_vm.h b/drivers/gpu/drm/xe/xe_vm.h > index c864dba35e1d..99b9a9b011de 100644 > --- a/drivers/gpu/drm/xe/xe_vm.h > +++ b/drivers/gpu/drm/xe/xe_vm.h > @@ -281,3 +281,6 @@ struct xe_vm_snapshot *xe_vm_snapshot_capture(struct xe_vm *vm); > void xe_vm_snapshot_capture_delayed(struct xe_vm_snapshot *snap); > void xe_vm_snapshot_print(struct xe_vm_snapshot *snap, struct drm_printer *p); > void xe_vm_snapshot_free(struct xe_vm_snapshot *snap); > + > +int xe_uvma_access(struct xe_userptr_vma *uvma, u64 offset, > + void *buf, u64 len, bool write);