From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24C50C41513 for ; Wed, 17 Jul 2024 05:21:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B12D210E61F; Wed, 17 Jul 2024 05:21:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="EhhuLn3J"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27AAE10E61F for ; Wed, 17 Jul 2024 05:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721193702; x=1752729702; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=vS2oSJcV5n8Afgzswp16WhhuHIXOfQ/6HHj9f12TQ0U=; b=EhhuLn3JkXUM9zUwSY8XIAToXL+GMmVbwdawZO6lh82wJbd9yvPbrrVV /+4wjCzaW/KehvDzeZhuZQfVz/DoSVDNiyN6QtF3uKMsQ/+PUMecur135 d9OU15Q1crZjSasO43DRRBlD/vzKVfbS70CI4/7TDwaU+M2KkpK4FIzaw YQ7+ukJ0dcDpURDHMIawDAfJ3bbKeayN6x0kuwxIlm8UqvCl8eO7ugaKA M6eS+/SMFf2wLCwpNpAyzvjK3K3yVcfUPoQx0VB+YUiHUFIVT4jb87LGX JCQwpbX1snrZsHmbxy1tkSYqeXTJjklAIvbHkfGNyXk4jz5ScUcfCnnDi g==; X-CSE-ConnectionGUID: HpuhSYiJQAmRM8kK3ppYWg== X-CSE-MsgGUID: 3hJR33xBRgu59FzXBDX4qA== X-IronPort-AV: E=McAfee;i="6700,10204,11135"; a="29281143" X-IronPort-AV: E=Sophos;i="6.09,213,1716274800"; d="scan'208";a="29281143" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2024 22:21:42 -0700 X-CSE-ConnectionGUID: o2qNyV3TQT6YgXzNQxVW6g== X-CSE-MsgGUID: i3AEkLWqSeCWeSRFF3nMHw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,213,1716274800"; d="scan'208";a="55124773" Received: from dut1107bmgfrd.igk.intel.com ([10.211.177.88]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2024 22:21:40 -0700 From: Akshata Jahagirdar To: intel-xe@lists.freedesktop.org Cc: akshatajahagirdar6@gmail.com, matthew.brost@intel.com, Akshata Jahagirdar Subject: [PATCH v6 0/8] Implement compression support on BMG Date: Wed, 17 Jul 2024 05:21:25 +0000 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Xe2+ has unified compression (exactly one compression mode/format), where compression is now controlled via PAT at PTE level. This simplifies KMD operations, as it can now decompress freely without concern for the buffer's original compression format—unlike DG2, which had multiple compression formats and thus required copying the raw CCS state during VRAM eviction. In addition mixed VRAM and system memory buffers were not supported with compression enabled. On Xe2 dGPU compression is still only supported with VRAM, however we can now support compression with VRAM and system memory buffers, with GPU access being seamless underneath. So long as when doing VRAM -> system memory the KMD uses compressed -> uncompressed, to decompress it. This also allows CPU access to such buffers, assuming that userspace first decompress the corresponding pages being accessed. If the pages are already in system memory then KMD would have already decompressed them. When restoring such buffers with sysmem -> VRAM the KMD can't easily know which pages were originally compressed, so we always use uncompressed -> uncompressed here. With this it also means we can drop all the raw CCS handling on such platforms (including needing to allocate extra CCS storage). In order to support this we now need to have two different identity mappings for compressed and uncompressed VRAM. In this patch, we set up the additional identity map for the VRAM with compressed pat_index. We then select the appropriate mapping during migration/clear. During eviction (vram->sysmem), we use the mapping from compressed -> uncompressed. During restore (sysmem->vram), we need the mapping from uncompressed -> uncompressed. Therefore, we need to have two different mappings for compressed and uncompressed vram. We set up an additional identity map for the vram with compressed pat_index. We then select the appropriate mapping during migration/clear. Akshata Jahagirdar (8): drm/xe/migrate: Handle clear ccs logic for xe2 dgfx drm/xe/migrate: Add kunit to test clear functionality drm/xe/migrate: Add helper function to program identity map drm/xe/xe2: Introduce identity map for compressed pat for vram drm/xe/xe_migrate: Handle migration logic for xe2+ dgfx drm/xe/migrate: Add kunit to test migration functionality for BMG drm/xe/xe2: Do not run xe_bo_test for xe2+ dgfx drm/xe/migrate: Parameterize ccs and bo data clear in xe_migrate_clear() drivers/gpu/drm/xe/tests/xe_bo.c | 9 +- drivers/gpu/drm/xe/tests/xe_migrate.c | 403 +++++++++++++++++++++++++- drivers/gpu/drm/xe/xe_bo.c | 10 +- drivers/gpu/drm/xe/xe_migrate.c | 211 +++++++++----- drivers/gpu/drm/xe/xe_migrate.h | 3 +- 5 files changed, 556 insertions(+), 80 deletions(-) -- 2.34.1