Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com,
	michal.grzelak@intel.com
Subject: [PATCH v2 00/15] drm/i915: vlv clock cleanups
Date: Fri, 12 Sep 2025 17:48:39 +0300	[thread overview]
Message-ID: <cover.1757688216.git.jani.nikula@intel.com> (raw)

This is v2 of [1]. There were issues with sideband get/put, discovered
in CI, so I ended up doing what Ville suggested in [2], and handling
sideband get/put inside the functions. This is done in new patches 1-2,
which obviously caused some rebase churn in the rest. I also removed
vlv_get_cck_clock_hpll() completely, this is new patch 11.

I added r-b/ack from the previous version in some patches, dropped them
from others, depending on how much changes there were. Sorry about the
trouble, please look into this again.

BR,
Jani.

[1] https://lore.kernel.org/r/cover.1755607980.git.jani.nikula@intel.com
[2] https://lore.kernel.org/r/aMAqlVAw2NqlwQ5_@intel.com

Jani Nikula (15):
  drm/i915: do cck get/put inside vlv_get_hpll_vco()
  drm/i915: do cck get/put inside vlv_get_cck_clock()
  drm/i915: add vlv_clock_get_gpll()
  drm/i915: add vlv_clock_get_czclk()
  drm/i915: add vlv_clock_get_hrawclk()
  drm/i915: make vlv_get_cck_clock_hpll() static
  drm/i915: add vlv_clock_get_cdclk()
  drm/i915: make vlv_get_cck_clock() static
  drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco()
  drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it
    more
  drm/i915: remove vlv_get_cck_clock_hpll()
  drm/i915: remove intel_update_czclk() as unnecessary
  drm/i915: log HPLL frequency similar to CZCLK
  drm/i915: move hpll and czclk caching under display
  drm/i915: split out vlv_clock.[ch]

 drivers/gpu/drm/i915/Makefile                 |  1 +
 drivers/gpu/drm/i915/display/intel_cdclk.c    | 36 +++------
 drivers/gpu/drm/i915/display/intel_display.c  | 61 --------------
 drivers/gpu/drm/i915/display/intel_display.h  |  6 --
 .../gpu/drm/i915/display/intel_display_core.h |  5 ++
 .../drm/i915/display/intel_display_driver.c   |  1 -
 drivers/gpu/drm/i915/display/vlv_clock.c      | 81 +++++++++++++++++++
 drivers/gpu/drm/i915/display/vlv_clock.h      | 38 +++++++++
 drivers/gpu/drm/i915/gt/intel_rc6.c           |  3 +-
 drivers/gpu/drm/i915/gt/intel_rps.c           | 18 ++---
 drivers/gpu/drm/i915/i915_drv.h               |  3 -
 drivers/gpu/drm/xe/xe_device_types.h          |  6 --
 12 files changed, 145 insertions(+), 114 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.c
 create mode 100644 drivers/gpu/drm/i915/display/vlv_clock.h

-- 
2.47.3


             reply	other threads:[~2025-09-12 14:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12 14:48 Jani Nikula [this message]
2025-09-12 14:48 ` [PATCH v2 01/15] drm/i915: do cck get/put inside vlv_get_hpll_vco() Jani Nikula
2025-09-18 10:54   ` Michał Grzelak
2025-09-12 14:48 ` [PATCH v2 02/15] drm/i915: do cck get/put inside vlv_get_cck_clock() Jani Nikula
2025-09-18 10:59   ` Michał Grzelak
2025-09-12 14:48 ` [PATCH v2 03/15] drm/i915: add vlv_clock_get_gpll() Jani Nikula
2025-09-12 14:48 ` [PATCH v2 04/15] drm/i915: add vlv_clock_get_czclk() Jani Nikula
2025-09-12 14:48 ` [PATCH v2 05/15] drm/i915: add vlv_clock_get_hrawclk() Jani Nikula
2025-09-12 14:48 ` [PATCH v2 06/15] drm/i915: make vlv_get_cck_clock_hpll() static Jani Nikula
2025-09-12 14:48 ` [PATCH v2 07/15] drm/i915: add vlv_clock_get_cdclk() Jani Nikula
2025-09-12 14:48 ` [PATCH v2 08/15] drm/i915: make vlv_get_cck_clock() static Jani Nikula
2025-09-12 14:48 ` [PATCH v2 09/15] drm/i915: rename vlv_get_hpll_vco() to vlv_clock_get_hpll_vco() Jani Nikula
2025-09-12 14:48 ` [PATCH v2 10/15] drm/i915: cache the results in vlv_clock_get_hpll_vco() and use it more Jani Nikula
2025-09-16 19:51   ` Ville Syrjälä
2025-09-17 13:57     ` Jani Nikula
2025-09-18 11:17   ` Michał Grzelak
2025-09-12 14:48 ` [PATCH v2 11/15] drm/i915: remove vlv_get_cck_clock_hpll() Jani Nikula
2025-09-18 11:24   ` Michał Grzelak
2025-09-12 14:48 ` [PATCH v2 12/15] drm/i915: remove intel_update_czclk() as unnecessary Jani Nikula
2025-09-18 11:26   ` Michał Grzelak
2025-09-12 14:48 ` [PATCH v2 13/15] drm/i915: log HPLL frequency similar to CZCLK Jani Nikula
2025-09-12 14:48 ` [PATCH v2 14/15] drm/i915: move hpll and czclk caching under display Jani Nikula
2025-09-18 11:28   ` Michał Grzelak
2025-09-12 14:48 ` [PATCH v2 15/15] drm/i915: split out vlv_clock.[ch] Jani Nikula
2025-09-18 11:32   ` Michał Grzelak
2025-09-12 14:56 ` ✗ CI.checkpatch: warning for drm/i915: vlv clock cleanups (rev3) Patchwork
2025-09-12 14:57 ` ✓ CI.KUnit: success " Patchwork
2025-09-12 15:12 ` ✗ CI.checksparse: warning " Patchwork
2025-09-12 15:35 ` ✓ Xe.CI.BAT: success " Patchwork
2025-09-12 17:25 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-18 12:01 ` [PATCH v2 00/15] drm/i915: vlv clock cleanups Michał Grzelak
2025-09-18 12:28   ` Jani Nikula
2025-09-19 22:00     ` Michał Grzelak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1757688216.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.grzelak@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox