intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/6] drm/i915: i915_utils.h refactoring
@ 2025-10-22 15:17 Jani Nikula
  2025-10-22 15:17 ` [PATCH 1/6] drm/i915: split out separate files for jiffies timeout and wait helpers Jani Nikula
                   ` (10 more replies)
  0 siblings, 11 replies; 23+ messages in thread
From: Jani Nikula @ 2025-10-22 15:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula


Jani Nikula (6):
  drm/i915: split out separate files for jiffies timeout and wait
    helpers
  drm/i915/display: create intel_display_utils.h
  drm/i915/display: add intel_display_run_as_guest()
  drm/i915/display: add intel_display_vtd_active()
  drm/i915/display: switch to intel_display_utils.h
  drm/xe/compat: reduce i915_utils.[ch]

 drivers/gpu/drm/i915/Makefile                 |  1 +
 drivers/gpu/drm/i915/display/g4x_dp.c         |  2 +-
 drivers/gpu/drm/i915/display/i9xx_plane.c     |  2 +-
 drivers/gpu/drm/i915/display/icl_dsi.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_acpi.c     |  2 +-
 .../gpu/drm/i915/display/intel_backlight.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_bios.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_bw.c       |  5 +--
 drivers/gpu/drm/i915/display/intel_cdclk.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_color.c    |  2 +-
 .../gpu/drm/i915/display/intel_combo_phy.c    |  2 +-
 .../gpu/drm/i915/display/intel_connector.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_cursor.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_cx0_phy.c  |  2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  2 +-
 .../drm/i915/display/intel_ddi_buf_trans.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_display.c  |  9 ++--
 .../drm/i915/display/intel_display_driver.c   |  3 +-
 .../drm/i915/display/intel_display_jiffies.h  | 43 +++++++++++++++++++
 .../drm/i915/display/intel_display_power.c    |  2 +-
 .../drm/i915/display/intel_display_utils.c    | 32 ++++++++++++++
 .../drm/i915/display/intel_display_utils.h    | 31 +++++++++++++
 drivers/gpu/drm/i915/display/intel_dmc.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  3 +-
 drivers/gpu/drm/i915/display/intel_dp_aux.c   |  2 +-
 .../drm/i915/display/intel_dp_link_training.c |  3 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |  2 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |  2 +-
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c  |  2 +-
 drivers/gpu/drm/i915/display/intel_dvo.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_fb.c       |  2 +-
 drivers/gpu/drm/i915/display/intel_fbc.c      |  5 ++-
 drivers/gpu/drm/i915/display/intel_fdi.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_flipq.c    |  6 +--
 drivers/gpu/drm/i915/display/intel_hdcp.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_hdcp_gsc.c |  1 -
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_hotplug.c  |  4 +-
 .../gpu/drm/i915/display/intel_hotplug_irq.c  |  2 +-
 drivers/gpu/drm/i915/display/intel_lspcon.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_pch.c      |  4 +-
 .../gpu/drm/i915/display/intel_pch_refclk.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_pfit.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_pmdemand.c |  3 +-
 drivers/gpu/drm/i915/display/intel_pps.c      |  3 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |  2 +-
 .../gpu/drm/i915/display/intel_qp_tables.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_snps_phy.c |  2 +-
 drivers/gpu/drm/i915/display/intel_sprite.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_tc.c       |  2 +-
 drivers/gpu/drm/i915/display/intel_vblank.c   |  3 +-
 drivers/gpu/drm/i915/display/intel_vdsc.c     |  2 +-
 drivers/gpu/drm/i915/display/skl_scaler.c     |  2 +-
 .../drm/i915/display/skl_universal_plane.c    |  2 +-
 drivers/gpu/drm/i915/display/skl_watermark.c  |  2 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c        |  2 +-
 drivers/gpu/drm/i915/gem/i915_gem_mman.c      |  5 ++-
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c       |  1 +
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |  1 +
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |  1 +
 drivers/gpu/drm/i915/i915_config.c            |  2 +-
 drivers/gpu/drm/i915/i915_jiffies.h           | 16 +++++++
 drivers/gpu/drm/i915/i915_utils.h             | 41 ++----------------
 .../gpu/drm/i915/selftests/i915_selftest.c    |  1 +
 drivers/gpu/drm/xe/Makefile                   |  2 +-
 .../drm/xe/compat-i915-headers/i915_utils.h   |  9 +++-
 drivers/gpu/drm/xe/display/ext/i915_utils.c   | 27 ------------
 68 files changed, 211 insertions(+), 134 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_jiffies.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.h
 create mode 100644 drivers/gpu/drm/i915/i915_jiffies.h
 delete mode 100644 drivers/gpu/drm/xe/display/ext/i915_utils.c

-- 
2.47.3


^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 1/6] drm/i915: split out separate files for jiffies timeout and wait helpers
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
@ 2025-10-22 15:17 ` Jani Nikula
  2025-10-30  7:53   ` Luca Coelho
  2025-10-22 15:17 ` [PATCH 2/6] drm/i915/display: create intel_display_utils.h Jani Nikula
                   ` (9 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-22 15:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula

Add i915_jiffies.h and intel_display_jiffies.h for jiffies timeout and
wait helpers, and use them separately from i915 and display. This helps
reduce the display dependency on i915_utils.h.

Long term, both msecs_to_jiffies_timeout() and
wait_remaining_ms_from_jiffies() really belong in core kernel headers,
but for now unblock display refactoring.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 .../drm/i915/display/intel_display_jiffies.h  | 43 +++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dp.c       |  1 +
 .../drm/i915/display/intel_dp_link_training.c |  1 +
 drivers/gpu/drm/i915/display/intel_hdcp.c     |  1 +
 drivers/gpu/drm/i915/display/intel_pmdemand.c |  1 +
 drivers/gpu/drm/i915/display/intel_pps.c      |  1 +
 drivers/gpu/drm/i915/display/intel_vblank.c   |  1 +
 drivers/gpu/drm/i915/gem/i915_gem_mman.c      |  5 ++-
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c       |  1 +
 .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |  1 +
 drivers/gpu/drm/i915/gt/selftest_execlists.c  |  1 +
 drivers/gpu/drm/i915/i915_config.c            |  2 +-
 drivers/gpu/drm/i915/i915_jiffies.h           | 16 +++++++
 drivers/gpu/drm/i915/i915_utils.h             | 34 ---------------
 .../gpu/drm/i915/selftests/i915_selftest.c    |  1 +
 15 files changed, 73 insertions(+), 37 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_jiffies.h
 create mode 100644 drivers/gpu/drm/i915/i915_jiffies.h

diff --git a/drivers/gpu/drm/i915/display/intel_display_jiffies.h b/drivers/gpu/drm/i915/display/intel_display_jiffies.h
new file mode 100644
index 000000000000..c060c567e262
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_display_jiffies.h
@@ -0,0 +1,43 @@
+/* SPDX-License-Identifier: MIT */
+/* Copyright © 2025 Intel Corporation */
+
+#ifndef __INTEL_DISPLAY_JIFFIES_H__
+#define __INTEL_DISPLAY_JIFFIES_H__
+
+#include <linux/jiffies.h>
+
+static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
+{
+	unsigned long j = msecs_to_jiffies(m);
+
+	return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
+}
+
+/*
+ * If you need to wait X milliseconds between events A and B, but event B
+ * doesn't happen exactly after event A, you record the timestamp (jiffies) of
+ * when event A happened, then just before event B you call this function and
+ * pass the timestamp as the first argument, and X as the second argument.
+ */
+static inline void
+wait_remaining_ms_from_jiffies(unsigned long timestamp_jiffies, int to_wait_ms)
+{
+	unsigned long target_jiffies, tmp_jiffies, remaining_jiffies;
+
+	/*
+	 * Don't re-read the value of "jiffies" every time since it may change
+	 * behind our back and break the math.
+	 */
+	tmp_jiffies = jiffies;
+	target_jiffies = timestamp_jiffies +
+			 msecs_to_jiffies_timeout(to_wait_ms);
+
+	if (time_after(target_jiffies, tmp_jiffies)) {
+		remaining_jiffies = target_jiffies - tmp_jiffies;
+		while (remaining_jiffies)
+			remaining_jiffies =
+			    schedule_timeout_uninterruptible(remaining_jiffies);
+	}
+}
+
+#endif /* __INTEL_DISPLAY_JIFFIES_H__ */
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index b0aeb6c2de86..78e21bfd29bd 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -64,6 +64,7 @@
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
+#include "intel_display_jiffies.h"
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index 27f3716bdc1f..316b42b5a946 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -29,6 +29,7 @@
 
 #include "i915_utils.h"
 #include "intel_display_core.h"
+#include "intel_display_jiffies.h"
 #include "intel_display_types.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index 531ee122bf82..0f624004104f 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -22,6 +22,7 @@
 #include "i915_utils.h"
 #include "intel_connector.h"
 #include "intel_de.h"
+#include "intel_display_jiffies.h"
 #include "intel_display_power.h"
 #include "intel_display_power_well.h"
 #include "intel_display_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c b/drivers/gpu/drm/i915/display/intel_pmdemand.c
index d806c15db7ce..7ade35e05eb5 100644
--- a/drivers/gpu/drm/i915/display/intel_pmdemand.c
+++ b/drivers/gpu/drm/i915/display/intel_pmdemand.c
@@ -12,6 +12,7 @@
 #include "intel_bw.h"
 #include "intel_cdclk.h"
 #include "intel_de.h"
+#include "intel_display_jiffies.h"
 #include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_pmdemand.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 327e0de86f1e..0c2f48626d0c 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -12,6 +12,7 @@
 #include "i915_reg.h"
 #include "i915_utils.h"
 #include "intel_de.h"
+#include "intel_display_jiffies.h"
 #include "intel_display_power_well.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 2fc0c1c0bb87..0e534be375ca 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -12,6 +12,7 @@
 #include "intel_color.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
+#include "intel_display_jiffies.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
 #include "intel_vblank.h"
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
index 75f5b0e871ef..4542135b20d5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
@@ -16,12 +16,13 @@
 #include "i915_gem_evict.h"
 #include "i915_gem_gtt.h"
 #include "i915_gem_ioctls.h"
-#include "i915_gem_object.h"
 #include "i915_gem_mman.h"
+#include "i915_gem_object.h"
+#include "i915_gem_ttm.h"
+#include "i915_jiffies.h"
 #include "i915_mm.h"
 #include "i915_trace.h"
 #include "i915_user_extensions.h"
-#include "i915_gem_ttm.h"
 #include "i915_vma.h"
 
 static inline bool
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 57bb111d65da..d119e54e5be1 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -10,6 +10,7 @@
 #include <drm/drm_buddy.h>
 
 #include "i915_drv.h"
+#include "i915_jiffies.h"
 #include "i915_ttm_buddy_manager.h"
 #include "intel_memory_region.h"
 #include "intel_region_ttm.h"
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
index 8d4bb95f8424..dcd3a3047aa4 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
@@ -4,6 +4,7 @@
  */
 
 #include "i915_drv.h"
+#include "i915_jiffies.h"
 #include "i915_request.h"
 
 #include "intel_context.h"
diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
index 0454eb1814bb..376f201a7650 100644
--- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
+++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
@@ -11,6 +11,7 @@
 #include "gt/intel_reset.h"
 #include "gt/selftest_engine_heartbeat.h"
 
+#include "i915_jiffies.h"
 #include "i915_selftest.h"
 #include "selftests/i915_random.h"
 #include "selftests/igt_flush_test.h"
diff --git a/drivers/gpu/drm/i915/i915_config.c b/drivers/gpu/drm/i915/i915_config.c
index 24e5bb8a670e..3cb615ffa96d 100644
--- a/drivers/gpu/drm/i915/i915_config.c
+++ b/drivers/gpu/drm/i915/i915_config.c
@@ -6,7 +6,7 @@
 #include <linux/kernel.h>
 
 #include "i915_config.h"
-#include "i915_utils.h"
+#include "i915_jiffies.h"
 
 unsigned long
 i915_fence_context_timeout(const struct drm_i915_private *i915, u64 context)
diff --git a/drivers/gpu/drm/i915/i915_jiffies.h b/drivers/gpu/drm/i915/i915_jiffies.h
new file mode 100644
index 000000000000..18a4eaea897a
--- /dev/null
+++ b/drivers/gpu/drm/i915/i915_jiffies.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: MIT */
+/* Copyright © 2025 Intel Corporation */
+
+#ifndef __I915_JIFFIES_H__
+#define __I915_JIFFIES_H__
+
+#include <linux/jiffies.h>
+
+static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
+{
+	unsigned long j = msecs_to_jiffies(m);
+
+	return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
+}
+
+#endif /* __I915_JIFFIES_H__ */
diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
index a0c892e4c40d..44de4a4aa84a 100644
--- a/drivers/gpu/drm/i915/i915_utils.h
+++ b/drivers/gpu/drm/i915/i915_utils.h
@@ -100,40 +100,6 @@ static inline bool is_power_of_2_u64(u64 n)
 	return (n != 0 && ((n & (n - 1)) == 0));
 }
 
-static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
-{
-	unsigned long j = msecs_to_jiffies(m);
-
-	return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
-}
-
-/*
- * If you need to wait X milliseconds between events A and B, but event B
- * doesn't happen exactly after event A, you record the timestamp (jiffies) of
- * when event A happened, then just before event B you call this function and
- * pass the timestamp as the first argument, and X as the second argument.
- */
-static inline void
-wait_remaining_ms_from_jiffies(unsigned long timestamp_jiffies, int to_wait_ms)
-{
-	unsigned long target_jiffies, tmp_jiffies, remaining_jiffies;
-
-	/*
-	 * Don't re-read the value of "jiffies" every time since it may change
-	 * behind our back and break the math.
-	 */
-	tmp_jiffies = jiffies;
-	target_jiffies = timestamp_jiffies +
-			 msecs_to_jiffies_timeout(to_wait_ms);
-
-	if (time_after(target_jiffies, tmp_jiffies)) {
-		remaining_jiffies = target_jiffies - tmp_jiffies;
-		while (remaining_jiffies)
-			remaining_jiffies =
-			    schedule_timeout_uninterruptible(remaining_jiffies);
-	}
-}
-
 #define KHz(x) (1000 * (x))
 #define MHz(x) KHz(1000 * (x))
 
diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
index 9c276c9d0a75..8460f0a70d04 100644
--- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
+++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
@@ -30,6 +30,7 @@
 
 #include "i915_driver.h"
 #include "i915_drv.h"
+#include "i915_jiffies.h"
 #include "i915_selftest.h"
 #include "i915_wait_util.h"
 #include "igt_flush_test.h"
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/6] drm/i915/display: create intel_display_utils.h
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
  2025-10-22 15:17 ` [PATCH 1/6] drm/i915: split out separate files for jiffies timeout and wait helpers Jani Nikula
@ 2025-10-22 15:17 ` Jani Nikula
  2025-10-30  7:51   ` Luca Coelho
  2025-10-22 15:17 ` [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest() Jani Nikula
                   ` (8 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-22 15:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula

Start a file for display specific generic utilities.

Move KHz() and MHz() helpers there first.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_backlight.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c           |  1 +
 drivers/gpu/drm/i915/display/intel_display_utils.h | 10 ++++++++++
 drivers/gpu/drm/i915/display/intel_dp_mst.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |  1 +
 drivers/gpu/drm/i915/i915_utils.h                  |  3 ---
 6 files changed, 14 insertions(+), 5 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.h

diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
index 3b14f929825a..a68fdbd2acb9 100644
--- a/drivers/gpu/drm/i915/display/intel_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_backlight.c
@@ -13,7 +13,6 @@
 #include <drm/drm_print.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_backlight.h"
 #include "intel_backlight_regs.h"
 #include "intel_connector.h"
@@ -21,6 +20,7 @@
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp_aux_backlight.h"
 #include "intel_dsi_dcs_backlight.h"
 #include "intel_panel.h"
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 870140340342..cd9fc3d1f36a 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -53,6 +53,7 @@
 #include "intel_display_power.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dkl_phy.h"
 #include "intel_dkl_phy_regs.h"
 #include "intel_dp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
new file mode 100644
index 000000000000..0a2b603ea856
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: MIT */
+/* Copyright © 2025 Intel Corporation */
+
+#ifndef __INTEL_DISPLAY_UTILS__
+#define __INTEL_DISPLAY_UTILS__
+
+#define KHz(x) (1000 * (x))
+#define MHz(x) KHz(1000 * (x))
+
+#endif /* __INTEL_DISPLAY_UTILS__ */
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index a845b2612a3f..8d11a989cf79 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -33,7 +33,6 @@
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_audio.h"
 #include "intel_connector.h"
@@ -43,6 +42,7 @@
 #include "intel_display_driver.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_dp_hdcp.h"
 #include "intel_dp_link_training.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index 8ea96cc524a1..900a945ff8ab 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -32,6 +32,7 @@
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dkl_phy.h"
 #include "intel_dkl_phy_regs.h"
 #include "intel_dpio_phy.h"
diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
index 44de4a4aa84a..c1f978a7c141 100644
--- a/drivers/gpu/drm/i915/i915_utils.h
+++ b/drivers/gpu/drm/i915/i915_utils.h
@@ -100,9 +100,6 @@ static inline bool is_power_of_2_u64(u64 n)
 	return (n != 0 && ((n & (n - 1)) == 0));
 }
 
-#define KHz(x) (1000 * (x))
-#define MHz(x) KHz(1000 * (x))
-
 void add_taint_for_CI(struct drm_i915_private *i915, unsigned int taint);
 static inline void __add_taint_for_CI(unsigned int taint)
 {
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest()
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
  2025-10-22 15:17 ` [PATCH 1/6] drm/i915: split out separate files for jiffies timeout and wait helpers Jani Nikula
  2025-10-22 15:17 ` [PATCH 2/6] drm/i915/display: create intel_display_utils.h Jani Nikula
@ 2025-10-22 15:17 ` Jani Nikula
  2025-10-30  7:57   ` Luca Coelho
  2025-10-22 15:17 ` [PATCH 4/6] drm/i915/display: add intel_display_vtd_active() Jani Nikula
                   ` (7 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-22 15:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula

Add intel_display_utils.c for display utilities that need more than a
header.

Start off with intel_display_run_as_guest(). The implementation is
intentional duplication of the i915_utils.h i915_run_as_guest(), with
the idea that it's small enough to not matter.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/Makefile                  |  1 +
 .../gpu/drm/i915/display/intel_display_utils.c | 18 ++++++++++++++++++
 .../gpu/drm/i915/display/intel_display_utils.h |  6 ++++++
 drivers/gpu/drm/i915/display/intel_pch.c       |  4 ++--
 drivers/gpu/drm/xe/Makefile                    |  1 +
 5 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.c

diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 47bac9b2c611..046f9282fb65 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -255,6 +255,7 @@ i915-y += \
 	display/intel_display_rpm.o \
 	display/intel_display_rps.o \
 	display/intel_display_snapshot.o \
+	display/intel_display_utils.o \
 	display/intel_display_wa.o \
 	display/intel_dmc.o \
 	display/intel_dmc_wl.o \
diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
new file mode 100644
index 000000000000..13d3999dd580
--- /dev/null
+++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: MIT
+/* Copyright © 2025 Intel Corporation */
+
+#ifdef CONFIG_X86
+#include <asm/hypervisor.h>
+#endif
+
+#include "intel_display_utils.h"
+
+bool intel_display_run_as_guest(struct intel_display *display)
+{
+#if IS_ENABLED(CONFIG_X86)
+	return !hypervisor_is_type(X86_HYPER_NATIVE);
+#else
+	/* Not supported yet */
+	return false;
+#endif
+}
diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
index 0a2b603ea856..e54e69afd959 100644
--- a/drivers/gpu/drm/i915/display/intel_display_utils.h
+++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
@@ -4,7 +4,13 @@
 #ifndef __INTEL_DISPLAY_UTILS__
 #define __INTEL_DISPLAY_UTILS__
 
+#include <linux/types.h>
+
+struct intel_display;
+
 #define KHz(x) (1000 * (x))
 #define MHz(x) KHz(1000 * (x))
 
+bool intel_display_run_as_guest(struct intel_display *display);
+
 #endif /* __INTEL_DISPLAY_UTILS__ */
diff --git a/drivers/gpu/drm/i915/display/intel_pch.c b/drivers/gpu/drm/i915/display/intel_pch.c
index 469e8a3cfb49..65359a36df48 100644
--- a/drivers/gpu/drm/i915/display/intel_pch.c
+++ b/drivers/gpu/drm/i915/display/intel_pch.c
@@ -5,8 +5,8 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_display_core.h"
+#include "intel_display_utils.h"
 #include "intel_pch.h"
 
 #define INTEL_PCH_DEVICE_ID_MASK		0xff80
@@ -328,7 +328,7 @@ void intel_pch_detect(struct intel_display *display)
 			    "Display disabled, reverting to NOP PCH\n");
 		display->pch_type = PCH_NOP;
 	} else if (!pch) {
-		if (i915_run_as_guest() && HAS_DISPLAY(display)) {
+		if (intel_display_run_as_guest(display) && HAS_DISPLAY(display)) {
 			intel_virt_detect_pch(display, &id, &pch_type);
 			display->pch_type = pch_type;
 		} else {
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index 82c6b3d29676..feb8225d4d79 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -257,6 +257,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	i915-display/intel_display_power_map.o \
 	i915-display/intel_display_power_well.o \
 	i915-display/intel_display_trace.o \
+	i915-display/intel_display_utils.o \
 	i915-display/intel_display_wa.o \
 	i915-display/intel_dkl_phy.o \
 	i915-display/intel_dmc.o \
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 4/6] drm/i915/display: add intel_display_vtd_active()
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (2 preceding siblings ...)
  2025-10-22 15:17 ` [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest() Jani Nikula
@ 2025-10-22 15:17 ` Jani Nikula
  2025-10-30  8:00   ` Luca Coelho
  2025-10-22 15:17 ` [PATCH 5/6] drm/i915/display: switch to intel_display_utils.h Jani Nikula
                   ` (6 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-22 15:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula

Add intel_display_vtd_active() to utils. It's intentional duplication
with i915_utils.h i915_vtd_active(), but reduces duplication with
xe. Win some, lose some.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_bw.c            |  4 ++--
 drivers/gpu/drm/i915/display/intel_display.c       |  8 +++-----
 drivers/gpu/drm/i915/display/intel_display_utils.c | 14 ++++++++++++++
 drivers/gpu/drm/i915/display/intel_display_utils.h |  1 +
 drivers/gpu/drm/i915/display/intel_fbc.c           |  4 +++-
 drivers/gpu/drm/xe/display/ext/i915_utils.c        | 10 ----------
 6 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 92a060e02cf3..640a40805f18 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -13,6 +13,7 @@
 #include "intel_display_core.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_mchbar_regs.h"
 #include "intel_pcode.h"
 #include "intel_uncore.h"
@@ -842,14 +843,13 @@ static unsigned int intel_bw_num_active_planes(struct intel_display *display,
 static unsigned int intel_bw_data_rate(struct intel_display *display,
 				       const struct intel_bw_state *bw_state)
 {
-	struct drm_i915_private *i915 = to_i915(display->drm);
 	unsigned int data_rate = 0;
 	enum pipe pipe;
 
 	for_each_pipe(display, pipe)
 		data_rate += bw_state->data_rate[pipe];
 
-	if (DISPLAY_VER(display) >= 13 && i915_vtd_active(i915))
+	if (DISPLAY_VER(display) >= 13 && intel_display_vtd_active(display))
 		data_rate = DIV_ROUND_UP(data_rate * 105, 100);
 
 	return data_rate;
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index a8b4619de347..33174fb46ecb 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -76,6 +76,7 @@
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_display_wa.h"
 #include "intel_dmc.h"
 #include "intel_dp.h"
@@ -830,9 +831,8 @@ static void intel_async_flip_vtd_wa(struct intel_display *display,
 static bool needs_async_flip_vtd_wa(const struct intel_crtc_state *crtc_state)
 {
 	struct intel_display *display = to_intel_display(crtc_state);
-	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
 
-	return crtc_state->uapi.async_flip && i915_vtd_active(i915) &&
+	return crtc_state->uapi.async_flip && intel_display_vtd_active(display) &&
 		(DISPLAY_VER(display) == 9 || display->platform.broadwell ||
 		 display->platform.haswell);
 }
@@ -8313,7 +8313,5 @@ void i830_disable_pipe(struct intel_display *display, enum pipe pipe)
 
 bool intel_scanout_needs_vtd_wa(struct intel_display *display)
 {
-	struct drm_i915_private *i915 = to_i915(display->drm);
-
-	return IS_DISPLAY_VER(display, 6, 11) && i915_vtd_active(i915);
+	return IS_DISPLAY_VER(display, 6, 11) && intel_display_vtd_active(display);
 }
diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
index 13d3999dd580..04d010f7c23e 100644
--- a/drivers/gpu/drm/i915/display/intel_display_utils.c
+++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
@@ -1,10 +1,15 @@
 // SPDX-License-Identifier: MIT
 /* Copyright © 2025 Intel Corporation */
 
+#include <linux/device.h>
+
+#include <drm/drm_device.h>
+
 #ifdef CONFIG_X86
 #include <asm/hypervisor.h>
 #endif
 
+#include "intel_display_core.h"
 #include "intel_display_utils.h"
 
 bool intel_display_run_as_guest(struct intel_display *display)
@@ -16,3 +21,12 @@ bool intel_display_run_as_guest(struct intel_display *display)
 	return false;
 #endif
 }
+
+bool intel_display_vtd_active(struct intel_display *display)
+{
+	if (device_iommu_mapped(display->drm->dev))
+		return true;
+
+	/* Running as a guest, we assume the host is enforcing VT'd */
+	return intel_display_run_as_guest(display);
+}
diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
index e54e69afd959..af1e34bac720 100644
--- a/drivers/gpu/drm/i915/display/intel_display_utils.h
+++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
@@ -12,5 +12,6 @@ struct intel_display;
 #define MHz(x) KHz(1000 * (x))
 
 bool intel_display_run_as_guest(struct intel_display *display);
+bool intel_display_vtd_active(struct intel_display *display);
 
 #endif /* __INTEL_DISPLAY_UTILS__ */
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 10ef3136dadc..6f2cc01ea4a0 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -59,6 +59,7 @@
 #include "intel_display_rpm.h"
 #include "intel_display_trace.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_display_wa.h"
 #include "intel_fbc.h"
 #include "intel_fbc_regs.h"
@@ -1472,7 +1473,8 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
 	}
 
 	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
-	if (i915_vtd_active(i915) && (display->platform.skylake || display->platform.broxton)) {
+	if (intel_display_vtd_active(display) &&
+	    (display->platform.skylake || display->platform.broxton)) {
 		plane_state->no_fbc_reason = "VT-d enabled";
 		return 0;
 	}
diff --git a/drivers/gpu/drm/xe/display/ext/i915_utils.c b/drivers/gpu/drm/xe/display/ext/i915_utils.c
index 1421c2a7b64d..af9ec2abbaa1 100644
--- a/drivers/gpu/drm/xe/display/ext/i915_utils.c
+++ b/drivers/gpu/drm/xe/display/ext/i915_utils.c
@@ -3,18 +3,8 @@
  * Copyright © 2023 Intel Corporation
  */
 
-#include "i915_drv.h"
 #include "i915_utils.h"
 
-bool i915_vtd_active(struct drm_i915_private *i915)
-{
-	if (device_iommu_mapped(i915->drm.dev))
-		return true;
-
-	/* Running as a guest, we assume the host is enforcing VT'd */
-	return i915_run_as_guest();
-}
-
 #if IS_ENABLED(CONFIG_DRM_I915_DEBUG)
 
 /* i915 specific, just put here for shutting it up */
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 5/6] drm/i915/display: switch to intel_display_utils.h
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (3 preceding siblings ...)
  2025-10-22 15:17 ` [PATCH 4/6] drm/i915/display: add intel_display_vtd_active() Jani Nikula
@ 2025-10-22 15:17 ` Jani Nikula
  2025-10-30  8:03   ` Luca Coelho
  2025-10-22 15:17 ` [PATCH 6/6] drm/xe/compat: reduce i915_utils.[ch] Jani Nikula
                   ` (5 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-22 15:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula

The remaining utils display needs from i915_utils.h are primarily
MISSING_CASE() and fetch_and_zero(), with a couple of
i915_inject_probe_failure() uses.

To avoid excessive churn, add duplicates of MISSING_CASE() and
fetch_and_zero() to intel_display_utils.h, and switch display to use the
display utils.

As long as there are display files that include i915_drv.h, which
includes i915_utils.h, we'll need #ifndef guards for MISSING_CASE() and
fetch_and_zero() in both utils headers. We can remove them once display
no longer depends on i915_drv.h.

A couple of files in display still need i915_utils.h for
i915_inject_probe_failure(). Annotate this. They will be handled
separately.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/g4x_dp.c              |  2 +-
 drivers/gpu/drm/i915/display/i9xx_plane.c          |  2 +-
 drivers/gpu/drm/i915/display/icl_dsi.c             |  2 +-
 drivers/gpu/drm/i915/display/intel_acpi.c          |  2 +-
 drivers/gpu/drm/i915/display/intel_bios.c          |  2 +-
 drivers/gpu/drm/i915/display/intel_bw.c            |  1 -
 drivers/gpu/drm/i915/display/intel_cdclk.c         |  2 +-
 drivers/gpu/drm/i915/display/intel_color.c         |  2 +-
 drivers/gpu/drm/i915/display/intel_combo_phy.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_connector.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_cursor.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_cx0_phy.c       |  2 +-
 drivers/gpu/drm/i915/display/intel_ddi.c           |  1 -
 drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c |  2 +-
 drivers/gpu/drm/i915/display/intel_display.c       |  1 -
 .../gpu/drm/i915/display/intel_display_driver.c    |  3 ++-
 drivers/gpu/drm/i915/display/intel_display_power.c |  2 +-
 drivers/gpu/drm/i915/display/intel_display_utils.h | 14 ++++++++++++++
 drivers/gpu/drm/i915/display/intel_dmc.c           |  2 +-
 drivers/gpu/drm/i915/display/intel_dp.c            |  2 +-
 drivers/gpu/drm/i915/display/intel_dp_aux.c        |  2 +-
 .../gpu/drm/i915/display/intel_dp_link_training.c  |  2 +-
 drivers/gpu/drm/i915/display/intel_dpio_phy.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |  1 -
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c       |  2 +-
 drivers/gpu/drm/i915/display/intel_dvo.c           |  2 +-
 drivers/gpu/drm/i915/display/intel_fb.c            |  2 +-
 drivers/gpu/drm/i915/display/intel_fbc.c           |  1 -
 drivers/gpu/drm/i915/display/intel_fdi.c           |  2 +-
 drivers/gpu/drm/i915/display/intel_flipq.c         |  6 +++---
 drivers/gpu/drm/i915/display/intel_hdcp.c          |  1 -
 drivers/gpu/drm/i915/display/intel_hdcp_gsc.c      |  1 -
 drivers/gpu/drm/i915/display/intel_hdmi.c          |  2 +-
 drivers/gpu/drm/i915/display/intel_hotplug.c       |  4 ++--
 drivers/gpu/drm/i915/display/intel_hotplug_irq.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_lspcon.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_pch_refclk.c    |  2 +-
 drivers/gpu/drm/i915/display/intel_pfit.c          |  2 +-
 drivers/gpu/drm/i915/display/intel_pmdemand.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_pps.c           |  2 +-
 drivers/gpu/drm/i915/display/intel_psr.c           |  2 +-
 drivers/gpu/drm/i915/display/intel_qp_tables.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_snps_phy.c      |  2 +-
 drivers/gpu/drm/i915/display/intel_sprite.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_tc.c            |  2 +-
 drivers/gpu/drm/i915/display/intel_vblank.c        |  2 +-
 drivers/gpu/drm/i915/display/intel_vdsc.c          |  2 +-
 drivers/gpu/drm/i915/display/skl_scaler.c          |  2 +-
 drivers/gpu/drm/i915/display/skl_universal_plane.c |  2 +-
 drivers/gpu/drm/i915/display/skl_watermark.c       |  2 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c             |  2 +-
 drivers/gpu/drm/i915/i915_utils.h                  |  4 ++++
 52 files changed, 65 insertions(+), 53 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
index aa159f9ce12f..a3ff21b2f69f 100644
--- a/drivers/gpu/drm/i915/display/g4x_dp.c
+++ b/drivers/gpu/drm/i915/display/g4x_dp.c
@@ -11,7 +11,6 @@
 
 #include "g4x_dp.h"
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_audio.h"
 #include "intel_backlight.h"
 #include "intel_connector.h"
@@ -20,6 +19,7 @@
 #include "intel_display_power.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_dp_aux.h"
 #include "intel_dp_link_training.h"
diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
index 407deb5dfb57..6e39d7f2e0c2 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane.c
+++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
@@ -11,7 +11,6 @@
 #include <drm/drm_print.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "i9xx_plane.h"
 #include "i9xx_plane_regs.h"
 #include "intel_atomic.h"
@@ -19,6 +18,7 @@
 #include "intel_display_irq.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_fb.h"
 #include "intel_fbc.h"
 #include "intel_frontbuffer.h"
diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index 297368ff42a5..70d4c1bc70fc 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -35,7 +35,6 @@
 #include <drm/drm_probe_helper.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "icl_dsi.h"
 #include "icl_dsi_regs.h"
 #include "intel_atomic.h"
@@ -48,6 +47,7 @@
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
+#include "intel_display_utils.h"
 #include "intel_dsi.h"
 #include "intel_dsi_vbt.h"
 #include "intel_panel.h"
diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
index 1addd6288241..68c01932f7b4 100644
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -11,10 +11,10 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_acpi.h"
 #include "intel_display_core.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 
 #define INTEL_DSM_REVISION_ID 1 /* For Calpella anyway... */
 #define INTEL_DSM_FN_PLATFORM_MUX_INFO 1 /* No args */
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index 3596dce84c28..e2b51fa21d93 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -36,11 +36,11 @@
 #include "soc/intel_rom.h"
 
 #include "i915_drv.h"
-#include "i915_utils.h"
 #include "intel_display.h"
 #include "intel_display_core.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_gmbus.h"
 
 #define _INTEL_BIOS_PRIVATE
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 640a40805f18..3033c53e61d1 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -7,7 +7,6 @@
 
 #include "i915_drv.h"
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_bw.h"
 #include "intel_crtc.h"
 #include "intel_display_core.h"
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index e92e7fd9fd13..d4435fe53d8d 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -32,7 +32,6 @@
 #include "hsw_ips.h"
 #include "i915_drv.h"
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_audio.h"
 #include "intel_cdclk.h"
@@ -41,6 +40,7 @@
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_mchbar_regs.h"
 #include "intel_pci_config.h"
 #include "intel_pcode.h"
diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index 51db70d07fae..1e97020e7304 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -24,12 +24,12 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "i9xx_plane_regs.h"
 #include "intel_color.h"
 #include "intel_color_regs.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dsb.h"
 #include "intel_vrr.h"
 
diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index 112749f97c26..f401558ac14e 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -5,12 +5,12 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_combo_phy.h"
 #include "intel_combo_phy_regs.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 
 #define for_each_combo_phy(__display, __phy) \
 	for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)	\
diff --git a/drivers/gpu/drm/i915/display/intel_connector.c b/drivers/gpu/drm/i915/display/intel_connector.c
index 6a55854db5b6..647e6e1f8c68 100644
--- a/drivers/gpu/drm/i915/display/intel_connector.c
+++ b/drivers/gpu/drm/i915/display/intel_connector.c
@@ -31,7 +31,7 @@
 #include <drm/drm_probe_helper.h>
 
 #include "i915_drv.h"
-#include "i915_utils.h"
+#include "i915_utils.h" /* for i915_inject_probe_failure() */
 #include "intel_connector.h"
 #include "intel_display_core.h"
 #include "intel_display_debugfs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c
index c47c84935871..7aa14348aa6d 100644
--- a/drivers/gpu/drm/i915/display/intel_cursor.c
+++ b/drivers/gpu/drm/i915/display/intel_cursor.c
@@ -12,13 +12,13 @@
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
 
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_cursor.h"
 #include "intel_cursor_regs.h"
 #include "intel_de.h"
 #include "intel_display.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_fb.h"
 #include "intel_fb_pin.h"
 #include "intel_frontbuffer.h"
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index a74c1be225ac..f57f6d90a9da 100644
--- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
@@ -8,7 +8,6 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_alpm.h"
 #include "intel_cx0_phy.h"
 #include "intel_cx0_phy_regs.h"
@@ -16,6 +15,7 @@
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_hdmi.h"
 #include "intel_panel.h"
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index cd9fc3d1f36a..1fac0ac6273b 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -35,7 +35,6 @@
 #include <drm/drm_privacy_screen_consumer.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "icl_dsi.h"
 #include "intel_alpm.h"
 #include "intel_audio.h"
diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
index a238be5bc455..629502947222 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
@@ -3,12 +3,12 @@
  * Copyright © 2020 Intel Corporation
  */
 
-#include "i915_utils.h"
 #include "intel_cx0_phy.h"
 #include "intel_ddi.h"
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 
 /* HDMI/DVI modes ignore everything but the last 2 items. So we share
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 33174fb46ecb..cdeb46d5fd7c 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -51,7 +51,6 @@
 #include "i915_config.h"
 #include "i915_drv.h"
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "i9xx_plane.h"
 #include "i9xx_plane_regs.h"
 #include "i9xx_wm.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
index 38672d2896e3..eb0727b9a0f6 100644
--- a/drivers/gpu/drm/i915/display/intel_display_driver.c
+++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
@@ -18,7 +18,7 @@
 #include <drm/drm_vblank.h>
 
 #include "i915_drv.h"
-#include "i915_utils.h"
+#include "i915_utils.h" /* for i915_inject_probe_failure() */
 #include "i9xx_wm.h"
 #include "intel_acpi.h"
 #include "intel_atomic.h"
@@ -35,6 +35,7 @@
 #include "intel_display_irq.h"
 #include "intel_display_power.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_display_wa.h"
 #include "intel_dkl_phy.h"
 #include "intel_dmc.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index da4babfd6bcb..ebe6225470d0 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -11,7 +11,6 @@
 #include "i915_drv.h"
 #include "i915_irq.h"
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_backlight_regs.h"
 #include "intel_cdclk.h"
 #include "intel_clock_gating.h"
@@ -23,6 +22,7 @@
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dmc.h"
 #include "intel_mchbar_regs.h"
 #include "intel_pch_refclk.h"
diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
index af1e34bac720..2a18f160320c 100644
--- a/drivers/gpu/drm/i915/display/intel_display_utils.h
+++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
@@ -4,10 +4,24 @@
 #ifndef __INTEL_DISPLAY_UTILS__
 #define __INTEL_DISPLAY_UTILS__
 
+#include <linux/bug.h>
 #include <linux/types.h>
 
 struct intel_display;
 
+#ifndef MISSING_CASE
+#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
+			     __stringify(x), (long)(x))
+#endif
+
+#ifndef fetch_and_zero
+#define fetch_and_zero(ptr) ({						\
+	typeof(*ptr) __T = *(ptr);					\
+	*(ptr) = (typeof(*ptr))0;					\
+	__T;								\
+})
+#endif
+
 #define KHz(x) (1000 * (x))
 #define MHz(x) KHz(1000 * (x))
 
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index be6d37ea1139..22f74974a79e 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -30,13 +30,13 @@
 #include <drm/drm_print.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_power_well.h"
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dmc.h"
 #include "intel_dmc_regs.h"
 #include "intel_flipq.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 78e21bfd29bd..b0d9631bfb0a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -51,7 +51,6 @@
 #include <drm/drm_probe_helper.h>
 
 #include "g4x_dp.h"
-#include "i915_utils.h"
 #include "intel_alpm.h"
 #include "intel_atomic.h"
 #include "intel_audio.h"
@@ -65,6 +64,7 @@
 #include "intel_de.h"
 #include "intel_display_driver.h"
 #include "intel_display_jiffies.h"
+#include "intel_display_utils.h"
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index 829a7c0fbe4f..2e7dbaf511b9 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -5,9 +5,9 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_dp_aux.h"
 #include "intel_dp_aux_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index 316b42b5a946..aad5fe14962f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -27,10 +27,10 @@
 #include <drm/display/drm_dp_helper.h>
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_display_core.h"
 #include "intel_display_jiffies.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_dp_link_training.h"
 #include "intel_encoder.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dpio_phy.c b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
index 3f77ad92c156..5df6347a420d 100644
--- a/drivers/gpu/drm/i915/display/intel_dpio_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
@@ -24,13 +24,13 @@
 #include <drm/drm_print.h>
 
 #include "bxt_dpio_phy_regs.h"
-#include "i915_utils.h"
 #include "intel_ddi.h"
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
 #include "intel_display_power_well.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_dpio_phy.h"
 #include "vlv_dpio_phy_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index 900a945ff8ab..92c433f7b7e2 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -27,7 +27,6 @@
 #include <drm/drm_print.h>
 
 #include "bxt_dpio_phy_regs.h"
-#include "i915_utils.h"
 #include "intel_cx0_phy.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 23402408e172..35ccf6a528fb 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -38,10 +38,10 @@
 #include <drm/drm_print.h>
 #include <video/mipi_display.h>
 
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dsi.h"
 #include "intel_dsi_vbt.h"
 #include "intel_gmbus_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/display/intel_dvo.c
index 08b48e36aca6..c2663d6e2c92 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo.c
+++ b/drivers/gpu/drm/i915/display/intel_dvo.c
@@ -34,12 +34,12 @@
 #include <drm/drm_print.h>
 #include <drm/drm_probe_helper.h>
 
-#include "i915_utils.h"
 #include "intel_connector.h"
 #include "intel_de.h"
 #include "intel_display_driver.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dvo.h"
 #include "intel_dvo_dev.h"
 #include "intel_dvo_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
index 3958628c73e9..ada4fdda70bb 100644
--- a/drivers/gpu/drm/i915/display/intel_fb.c
+++ b/drivers/gpu/drm/i915/display/intel_fb.c
@@ -11,11 +11,11 @@
 #include <drm/drm_modeset_helper.h>
 
 #include "i915_drv.h"
-#include "i915_utils.h"
 #include "intel_bo.h"
 #include "intel_display.h"
 #include "intel_display_core.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dpt.h"
 #include "intel_fb.h"
 #include "intel_fb_bo.h"
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 6f2cc01ea4a0..6e5cf522ef5b 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -49,7 +49,6 @@
 #include "gt/intel_gt_types.h"
 
 #include "i915_drv.h"
-#include "i915_utils.h"
 #include "i915_vgpu.h"
 #include "i915_vma.h"
 #include "i9xx_plane_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c
index 59a36b3a22c1..5bb0090dd5ed 100644
--- a/drivers/gpu/drm/i915/display/intel_fdi.c
+++ b/drivers/gpu/drm/i915/display/intel_fdi.c
@@ -9,13 +9,13 @@
 #include <drm/drm_print.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_crtc.h"
 #include "intel_ddi.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_fdi.h"
 #include "intel_fdi_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_flipq.c b/drivers/gpu/drm/i915/display/intel_flipq.c
index 6ab2272ab2df..f162614a925d 100644
--- a/drivers/gpu/drm/i915/display/intel_flipq.c
+++ b/drivers/gpu/drm/i915/display/intel_flipq.c
@@ -7,16 +7,16 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
-#include "intel_step.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_core.h"
 #include "intel_display_types.h"
-#include "intel_flipq.h"
+#include "intel_display_utils.h"
 #include "intel_dmc.h"
 #include "intel_dmc_regs.h"
 #include "intel_dsb.h"
+#include "intel_flipq.h"
+#include "intel_step.h"
 #include "intel_vblank.h"
 #include "intel_vrr.h"
 
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index 0f624004104f..7195e8cf671c 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -19,7 +19,6 @@
 #include <drm/intel/i915_component.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_connector.h"
 #include "intel_de.h"
 #include "intel_display_jiffies.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
index 6a22862d6be1..17aa5e0cd51a 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
@@ -9,7 +9,6 @@
 #include "gt/intel_gt.h"
 #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h"
 #include "i915_drv.h"
-#include "i915_utils.h"
 #include "intel_hdcp_gsc.h"
 
 struct intel_hdcp_gsc_context {
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 4ab7e2e3bfd4..0acf2f63ada4 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -45,7 +45,6 @@
 #include <media/cec-notifier.h>
 
 #include "g4x_hdmi.h"
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_audio.h"
 #include "intel_connector.h"
@@ -55,6 +54,7 @@
 #include "intel_display_driver.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_gmbus.h"
 #include "intel_hdcp.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
index 4451a792600a..3e508bb9ecdd 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
@@ -28,12 +28,12 @@
 
 #include "i915_drv.h"
 #include "i915_irq.h"
-#include "i915_utils.h"
 #include "intel_connector.h"
-#include "intel_display_power.h"
 #include "intel_display_core.h"
+#include "intel_display_power.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_hdcp.h"
 #include "intel_hotplug.h"
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
index 9a4da818ad61..46c47b3d6f42 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
@@ -6,11 +6,11 @@
 #include <drm/drm_print.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp_aux.h"
 #include "intel_gmbus.h"
 #include "intel_hotplug.h"
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index d56026c4efdd..9ceabbc981a1 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -31,10 +31,10 @@
 #include <drm/drm_edid.h>
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_hdmi.h"
 #include "intel_lspcon.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pch_refclk.c b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
index 9ae53679a041..cca880c7eed4 100644
--- a/drivers/gpu/drm/i915/display/intel_pch_refclk.c
+++ b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
@@ -6,10 +6,10 @@
 #include <drm/drm_print.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_panel.h"
 #include "intel_pch_refclk.h"
 #include "intel_sbi.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pfit.c b/drivers/gpu/drm/i915/display/intel_pfit.c
index 68539e7c2a24..6dda496190e0 100644
--- a/drivers/gpu/drm/i915/display/intel_pfit.c
+++ b/drivers/gpu/drm/i915/display/intel_pfit.c
@@ -5,12 +5,12 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_core.h"
 #include "intel_display_driver.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_lvds_regs.h"
 #include "intel_pfit.h"
 #include "intel_pfit_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c b/drivers/gpu/drm/i915/display/intel_pmdemand.c
index 7ade35e05eb5..f52abd4e2eb0 100644
--- a/drivers/gpu/drm/i915/display/intel_pmdemand.c
+++ b/drivers/gpu/drm/i915/display/intel_pmdemand.c
@@ -7,7 +7,6 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_bw.h"
 #include "intel_cdclk.h"
@@ -15,6 +14,7 @@
 #include "intel_display_jiffies.h"
 #include "intel_display_regs.h"
 #include "intel_display_trace.h"
+#include "intel_display_utils.h"
 #include "intel_pmdemand.h"
 #include "intel_step.h"
 #include "skl_watermark.h"
diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
index 0c2f48626d0c..25692a547764 100644
--- a/drivers/gpu/drm/i915/display/intel_pps.c
+++ b/drivers/gpu/drm/i915/display/intel_pps.c
@@ -10,12 +10,12 @@
 
 #include "g4x_dp.h"
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_jiffies.h"
 #include "intel_display_power_well.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_dpio_phy.h"
 #include "intel_dpll.h"
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index cfc8b04f98fa..0ca2b06d18b5 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -29,7 +29,6 @@
 #include <drm/drm_vblank.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_alpm.h"
 #include "intel_atomic.h"
 #include "intel_crtc.h"
@@ -40,6 +39,7 @@
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dmc.h"
 #include "intel_dp.h"
 #include "intel_dp_aux.h"
diff --git a/drivers/gpu/drm/i915/display/intel_qp_tables.c b/drivers/gpu/drm/i915/display/intel_qp_tables.c
index 600c815e37e4..c05d4beb91d8 100644
--- a/drivers/gpu/drm/i915/display/intel_qp_tables.c
+++ b/drivers/gpu/drm/i915/display/intel_qp_tables.c
@@ -5,7 +5,7 @@
 
 #include <drm/display/drm_dsc.h>
 
-#include "i915_utils.h"
+#include "intel_display_utils.h"
 #include "intel_qp_tables.h"
 
 /* from BPP 6 to 24 in steps of 0.5 */
diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index b2dd69a11124..4f028e6a91cd 100644
--- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
@@ -7,12 +7,12 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_ddi.h"
 #include "intel_ddi_buf_trans.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_snps_hdmi_pll.h"
 #include "intel_snps_phy.h"
 #include "intel_snps_phy_regs.h"
diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index 75bbaa923204..60f1d9ed181e 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -39,10 +39,10 @@
 #include <drm/drm_print.h>
 #include <drm/drm_rect.h>
 
-#include "i915_utils.h"
 #include "i9xx_plane.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_fb.h"
 #include "intel_frontbuffer.h"
 #include "intel_plane.h"
diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
index c4a5601c5107..f1ed50be3247 100644
--- a/drivers/gpu/drm/i915/display/intel_tc.c
+++ b/drivers/gpu/drm/i915/display/intel_tc.c
@@ -8,7 +8,6 @@
 #include <drm/drm_print.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_cx0_phy_regs.h"
 #include "intel_ddi.h"
@@ -18,6 +17,7 @@
 #include "intel_display_power_map.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dkl_phy_regs.h"
 #include "intel_dp.h"
 #include "intel_dp_mst.h"
diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
index 0e534be375ca..8aa427a93964 100644
--- a/drivers/gpu/drm/i915/display/intel_vblank.c
+++ b/drivers/gpu/drm/i915/display/intel_vblank.c
@@ -8,13 +8,13 @@
 #include <drm/drm_vblank.h>
 
 #include "i915_drv.h"
-#include "i915_utils.h"
 #include "intel_color.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_jiffies.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_vblank.h"
 #include "intel_vrr.h"
 
diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
index dbf2cf1b896d..0e727fc5e80c 100644
--- a/drivers/gpu/drm/i915/display/intel_vdsc.c
+++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
@@ -11,10 +11,10 @@
 #include <drm/drm_fixed.h>
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_crtc.h"
 #include "intel_de.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dp.h"
 #include "intel_dsi.h"
 #include "intel_qp_tables.h"
diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
index d29efcbf2319..2956b110c3b7 100644
--- a/drivers/gpu/drm/i915/display/skl_scaler.c
+++ b/drivers/gpu/drm/i915/display/skl_scaler.c
@@ -5,11 +5,11 @@
 
 #include <drm/drm_print.h>
 
-#include "i915_utils.h"
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_trace.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_display_wa.h"
 #include "intel_fb.h"
 #include "skl_scaler.h"
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 0319174adf95..b6fdba88752b 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -10,12 +10,12 @@
 
 #include "pxp/intel_pxp.h"
 #include "i915_drv.h"
-#include "i915_utils.h"
 #include "intel_bo.h"
 #include "intel_de.h"
 #include "intel_display_irq.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dpt.h"
 #include "intel_fb.h"
 #include "intel_fbc.h"
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 256162da9afc..6d050408618c 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -10,7 +10,6 @@
 
 #include "soc/intel_dram.h"
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "i9xx_wm.h"
 #include "intel_atomic.h"
 #include "intel_bw.h"
@@ -23,6 +22,7 @@
 #include "intel_display_regs.h"
 #include "intel_display_rpm.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_fb.h"
 #include "intel_fixed.h"
 #include "intel_flipq.h"
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
index c9a53fde79c4..444682995658 100644
--- a/drivers/gpu/drm/i915/display/vlv_dsi.c
+++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
@@ -34,7 +34,6 @@
 #include <drm/drm_probe_helper.h>
 
 #include "i915_reg.h"
-#include "i915_utils.h"
 #include "intel_atomic.h"
 #include "intel_backlight.h"
 #include "intel_connector.h"
@@ -42,6 +41,7 @@
 #include "intel_de.h"
 #include "intel_display_regs.h"
 #include "intel_display_types.h"
+#include "intel_display_utils.h"
 #include "intel_dsi.h"
 #include "intel_dsi_vbt.h"
 #include "intel_fifo_underrun.h"
diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
index c1f978a7c141..4f75115b87d6 100644
--- a/drivers/gpu/drm/i915/i915_utils.h
+++ b/drivers/gpu/drm/i915/i915_utils.h
@@ -38,8 +38,10 @@
 
 struct drm_i915_private;
 
+#ifndef MISSING_CASE
 #define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
 			     __stringify(x), (long)(x))
+#endif
 
 #if IS_ENABLED(CONFIG_DRM_I915_DEBUG)
 
@@ -65,11 +67,13 @@ bool i915_error_injected(void);
 		drm_err(&(i915)->drm, fmt, ##__VA_ARGS__); \
 })
 
+#ifndef fetch_and_zero
 #define fetch_and_zero(ptr) ({						\
 	typeof(*ptr) __T = *(ptr);					\
 	*(ptr) = (typeof(*ptr))0;					\
 	__T;								\
 })
+#endif
 
 /*
  * check_user_mbz: Check that a user value exists and is zero
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 6/6] drm/xe/compat: reduce i915_utils.[ch]
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (4 preceding siblings ...)
  2025-10-22 15:17 ` [PATCH 5/6] drm/i915/display: switch to intel_display_utils.h Jani Nikula
@ 2025-10-22 15:17 ` Jani Nikula
  2025-10-30  8:04   ` Luca Coelho
  2025-10-22 21:46 ` ✗ CI.checkpatch: warning for drm/i915: i915_utils.h refactoring Patchwork
                   ` (4 subsequent siblings)
  10 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-22 15:17 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jani.nikula

Reduce the compat i915_utils.h to only cover the requirements of
MISSING_CASE() in soc/ and the few i915_inject_probe_failure()
instances, instead of including the entire i915_utils.h from i915. This
prevents new users for the utilities from cropping up.

With this, we can remove the xe/display/ext/i915_utils.c altogether.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/xe/Makefile                     |  1 -
 .../gpu/drm/xe/compat-i915-headers/i915_utils.h |  9 ++++++++-
 drivers/gpu/drm/xe/display/ext/i915_utils.c     | 17 -----------------
 3 files changed, 8 insertions(+), 19 deletions(-)
 delete mode 100644 drivers/gpu/drm/xe/display/ext/i915_utils.c

diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index feb8225d4d79..a7bcc3948a31 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -205,7 +205,6 @@ $(obj)/i915-display/%.o: $(srctree)/drivers/gpu/drm/i915/display/%.c FORCE
 # Display code specific to xe
 xe-$(CONFIG_DRM_XE_DISPLAY) += \
 	display/ext/i915_irq.o \
-	display/ext/i915_utils.o \
 	display/intel_bo.o \
 	display/intel_fb_bo.o \
 	display/intel_fbdev_fb.o \
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h
index 1d7c4360e5c0..bcd441dc0fce 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h
@@ -3,4 +3,11 @@
  * Copyright © 2023 Intel Corporation
  */
 
-#include "../../i915/i915_utils.h"
+/* for soc/ */
+#ifndef MISSING_CASE
+#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
+			     __stringify(x), (long)(x))
+#endif
+
+/* for a couple of users under i915/display */
+#define i915_inject_probe_failure(unused) ((unused) && 0)
diff --git a/drivers/gpu/drm/xe/display/ext/i915_utils.c b/drivers/gpu/drm/xe/display/ext/i915_utils.c
deleted file mode 100644
index af9ec2abbaa1..000000000000
--- a/drivers/gpu/drm/xe/display/ext/i915_utils.c
+++ /dev/null
@@ -1,17 +0,0 @@
-// SPDX-License-Identifier: MIT
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#include "i915_utils.h"
-
-#if IS_ENABLED(CONFIG_DRM_I915_DEBUG)
-
-/* i915 specific, just put here for shutting it up */
-int __i915_inject_probe_error(struct drm_i915_private *i915, int err,
-			      const char *func, int line)
-{
-	return 0;
-}
-
-#endif
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* ✗ CI.checkpatch: warning for drm/i915: i915_utils.h refactoring
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (5 preceding siblings ...)
  2025-10-22 15:17 ` [PATCH 6/6] drm/xe/compat: reduce i915_utils.[ch] Jani Nikula
@ 2025-10-22 21:46 ` Patchwork
  2025-10-22 21:47 ` ✓ CI.KUnit: success " Patchwork
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2025-10-22 21:46 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-xe

== Series Details ==

Series: drm/i915: i915_utils.h refactoring
URL   : https://patchwork.freedesktop.org/series/156358/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
8677d3b99d5fd579c143b22605d99121e2482e8a
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit ba6a9f5679e868e62b5a1e62540e791b13b21f62
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Wed Oct 22 18:17:14 2025 +0300

    drm/xe/compat: reduce i915_utils.[ch]
    
    Reduce the compat i915_utils.h to only cover the requirements of
    MISSING_CASE() in soc/ and the few i915_inject_probe_failure()
    instances, instead of including the entire i915_utils.h from i915. This
    prevents new users for the utilities from cropping up.
    
    With this, we can remove the xe/display/ext/i915_utils.c altogether.
    
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
+ /mt/dim checkpatch 71929a54e8bb5da291d41a931d80c6c9160073dd drm-intel
48c58cb4887e drm/i915: split out separate files for jiffies timeout and wait helpers
-:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 192 lines checked
2e9190f44c5a drm/i915/display: create intel_display_utils.h
-:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 61 lines checked
9121aeb1537e drm/i915/display: add intel_display_run_as_guest()
-:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 62 lines checked
9f4a7df45ded drm/i915/display: add intel_display_vtd_active()
9be1f0805ade drm/i915/display: switch to intel_display_utils.h
-:340: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects?
#340: FILE: drivers/gpu/drm/i915/display/intel_display_utils.h:18:
+#define fetch_and_zero(ptr) ({						\
+	typeof(*ptr) __T = *(ptr);					\
+	*(ptr) = (typeof(*ptr))0;					\
+	__T;								\
+})

-:340: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ptr' may be better as '(ptr)' to avoid precedence issues
#340: FILE: drivers/gpu/drm/i915/display/intel_display_utils.h:18:
+#define fetch_and_zero(ptr) ({						\
+	typeof(*ptr) __T = *(ptr);					\
+	*(ptr) = (typeof(*ptr))0;					\
+	__T;								\
+})

total: 0 errors, 0 warnings, 2 checks, 651 lines checked
ba6a9f5679e8 drm/xe/compat: reduce i915_utils.[ch]
-:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 19 lines checked



^ permalink raw reply	[flat|nested] 23+ messages in thread

* ✓ CI.KUnit: success for drm/i915: i915_utils.h refactoring
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (6 preceding siblings ...)
  2025-10-22 21:46 ` ✗ CI.checkpatch: warning for drm/i915: i915_utils.h refactoring Patchwork
@ 2025-10-22 21:47 ` Patchwork
  2025-10-22 22:03 ` ✗ CI.checksparse: warning " Patchwork
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2025-10-22 21:47 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-xe

== Series Details ==

Series: drm/i915: i915_utils.h refactoring
URL   : https://patchwork.freedesktop.org/series/156358/
State : success

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[21:46:37] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[21:46:41] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[21:47:11] Starting KUnit Kernel (1/1)...
[21:47:11] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[21:47:12] ================== guc_buf (11 subtests) ===================
[21:47:12] [PASSED] test_smallest
[21:47:12] [PASSED] test_largest
[21:47:12] [PASSED] test_granular
[21:47:12] [PASSED] test_unique
[21:47:12] [PASSED] test_overlap
[21:47:12] [PASSED] test_reusable
[21:47:12] [PASSED] test_too_big
[21:47:12] [PASSED] test_flush
[21:47:12] [PASSED] test_lookup
[21:47:12] [PASSED] test_data
[21:47:12] [PASSED] test_class
[21:47:12] ===================== [PASSED] guc_buf =====================
[21:47:12] =================== guc_dbm (7 subtests) ===================
[21:47:12] [PASSED] test_empty
[21:47:12] [PASSED] test_default
[21:47:12] ======================== test_size  ========================
[21:47:12] [PASSED] 4
[21:47:12] [PASSED] 8
[21:47:12] [PASSED] 32
[21:47:12] [PASSED] 256
[21:47:12] ==================== [PASSED] test_size ====================
[21:47:12] ======================= test_reuse  ========================
[21:47:12] [PASSED] 4
[21:47:12] [PASSED] 8
[21:47:12] [PASSED] 32
[21:47:12] [PASSED] 256
[21:47:12] =================== [PASSED] test_reuse ====================
[21:47:12] =================== test_range_overlap  ====================
[21:47:12] [PASSED] 4
[21:47:12] [PASSED] 8
[21:47:12] [PASSED] 32
[21:47:12] [PASSED] 256
[21:47:12] =============== [PASSED] test_range_overlap ================
[21:47:12] =================== test_range_compact  ====================
[21:47:12] [PASSED] 4
[21:47:12] [PASSED] 8
[21:47:12] [PASSED] 32
[21:47:12] [PASSED] 256
[21:47:12] =============== [PASSED] test_range_compact ================
[21:47:12] ==================== test_range_spare  =====================
[21:47:12] [PASSED] 4
[21:47:12] [PASSED] 8
[21:47:12] [PASSED] 32
[21:47:12] [PASSED] 256
[21:47:12] ================ [PASSED] test_range_spare =================
[21:47:12] ===================== [PASSED] guc_dbm =====================
[21:47:12] =================== guc_idm (6 subtests) ===================
[21:47:12] [PASSED] bad_init
[21:47:12] [PASSED] no_init
[21:47:12] [PASSED] init_fini
[21:47:12] [PASSED] check_used
[21:47:12] [PASSED] check_quota
[21:47:12] [PASSED] check_all
[21:47:12] ===================== [PASSED] guc_idm =====================
[21:47:12] ================== no_relay (3 subtests) ===================
[21:47:12] [PASSED] xe_drops_guc2pf_if_not_ready
[21:47:12] [PASSED] xe_drops_guc2vf_if_not_ready
[21:47:12] [PASSED] xe_rejects_send_if_not_ready
[21:47:12] ==================== [PASSED] no_relay =====================
[21:47:12] ================== pf_relay (14 subtests) ==================
[21:47:12] [PASSED] pf_rejects_guc2pf_too_short
[21:47:12] [PASSED] pf_rejects_guc2pf_too_long
[21:47:12] [PASSED] pf_rejects_guc2pf_no_payload
[21:47:12] [PASSED] pf_fails_no_payload
[21:47:12] [PASSED] pf_fails_bad_origin
[21:47:12] [PASSED] pf_fails_bad_type
[21:47:12] [PASSED] pf_txn_reports_error
[21:47:12] [PASSED] pf_txn_sends_pf2guc
[21:47:12] [PASSED] pf_sends_pf2guc
[21:47:12] [SKIPPED] pf_loopback_nop
[21:47:12] [SKIPPED] pf_loopback_echo
[21:47:12] [SKIPPED] pf_loopback_fail
[21:47:12] [SKIPPED] pf_loopback_busy
[21:47:12] [SKIPPED] pf_loopback_retry
[21:47:12] ==================== [PASSED] pf_relay =====================
[21:47:12] ================== vf_relay (3 subtests) ===================
[21:47:12] [PASSED] vf_rejects_guc2vf_too_short
[21:47:12] [PASSED] vf_rejects_guc2vf_too_long
[21:47:12] [PASSED] vf_rejects_guc2vf_no_payload
[21:47:12] ==================== [PASSED] vf_relay =====================
[21:47:12] ===================== lmtt (1 subtest) =====================
[21:47:12] ======================== test_ops  =========================
[21:47:12] [PASSED] 2-level
[21:47:12] [PASSED] multi-level
[21:47:12] ==================== [PASSED] test_ops =====================
[21:47:12] ====================== [PASSED] lmtt =======================
[21:47:12] ================= pf_service (11 subtests) =================
[21:47:12] [PASSED] pf_negotiate_any
[21:47:12] [PASSED] pf_negotiate_base_match
[21:47:12] [PASSED] pf_negotiate_base_newer
[21:47:12] [PASSED] pf_negotiate_base_next
[21:47:12] [SKIPPED] pf_negotiate_base_older
[21:47:12] [PASSED] pf_negotiate_base_prev
[21:47:12] [PASSED] pf_negotiate_latest_match
[21:47:12] [PASSED] pf_negotiate_latest_newer
[21:47:12] [PASSED] pf_negotiate_latest_next
[21:47:12] [SKIPPED] pf_negotiate_latest_older
[21:47:12] [SKIPPED] pf_negotiate_latest_prev
[21:47:12] =================== [PASSED] pf_service ====================
[21:47:12] ================= xe_guc_g2g (2 subtests) ==================
[21:47:12] ============== xe_live_guc_g2g_kunit_default  ==============
[21:47:12] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[21:47:12] ============== xe_live_guc_g2g_kunit_allmem  ===============
[21:47:12] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[21:47:12] =================== [SKIPPED] xe_guc_g2g ===================
[21:47:12] =================== xe_mocs (2 subtests) ===================
[21:47:12] ================ xe_live_mocs_kernel_kunit  ================
[21:47:12] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[21:47:12] ================ xe_live_mocs_reset_kunit  =================
[21:47:12] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[21:47:12] ==================== [SKIPPED] xe_mocs =====================
[21:47:12] ================= xe_migrate (2 subtests) ==================
[21:47:12] ================= xe_migrate_sanity_kunit  =================
[21:47:12] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[21:47:12] ================== xe_validate_ccs_kunit  ==================
[21:47:12] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[21:47:12] =================== [SKIPPED] xe_migrate ===================
[21:47:12] ================== xe_dma_buf (1 subtest) ==================
[21:47:12] ==================== xe_dma_buf_kunit  =====================
[21:47:12] ================ [SKIPPED] xe_dma_buf_kunit ================
[21:47:12] =================== [SKIPPED] xe_dma_buf ===================
[21:47:12] ================= xe_bo_shrink (1 subtest) =================
[21:47:12] =================== xe_bo_shrink_kunit  ====================
[21:47:12] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[21:47:12] ================== [SKIPPED] xe_bo_shrink ==================
[21:47:12] ==================== xe_bo (2 subtests) ====================
[21:47:12] ================== xe_ccs_migrate_kunit  ===================
[21:47:12] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[21:47:12] ==================== xe_bo_evict_kunit  ====================
[21:47:12] =============== [SKIPPED] xe_bo_evict_kunit ================
[21:47:12] ===================== [SKIPPED] xe_bo ======================
[21:47:12] ==================== args (11 subtests) ====================
[21:47:12] [PASSED] count_args_test
[21:47:12] [PASSED] call_args_example
[21:47:12] [PASSED] call_args_test
[21:47:12] [PASSED] drop_first_arg_example
[21:47:12] [PASSED] drop_first_arg_test
[21:47:12] [PASSED] first_arg_example
[21:47:12] [PASSED] first_arg_test
[21:47:12] [PASSED] last_arg_example
[21:47:12] [PASSED] last_arg_test
[21:47:12] [PASSED] pick_arg_example
[21:47:12] [PASSED] sep_comma_example
[21:47:12] ====================== [PASSED] args =======================
[21:47:12] =================== xe_pci (3 subtests) ====================
[21:47:12] ==================== check_graphics_ip  ====================
[21:47:12] [PASSED] 12.00 Xe_LP
[21:47:12] [PASSED] 12.10 Xe_LP+
[21:47:12] [PASSED] 12.55 Xe_HPG
[21:47:12] [PASSED] 12.60 Xe_HPC
[21:47:12] [PASSED] 12.70 Xe_LPG
[21:47:12] [PASSED] 12.71 Xe_LPG
[21:47:12] [PASSED] 12.74 Xe_LPG+
[21:47:12] [PASSED] 20.01 Xe2_HPG
[21:47:12] [PASSED] 20.02 Xe2_HPG
[21:47:12] [PASSED] 20.04 Xe2_LPG
[21:47:12] [PASSED] 30.00 Xe3_LPG
[21:47:12] [PASSED] 30.01 Xe3_LPG
[21:47:12] [PASSED] 30.03 Xe3_LPG
[21:47:12] [PASSED] 30.04 Xe3_LPG
[21:47:12] [PASSED] 30.05 Xe3_LPG
[21:47:12] [PASSED] 35.11 Xe3p_XPC
[21:47:12] ================ [PASSED] check_graphics_ip ================
[21:47:12] ===================== check_media_ip  ======================
[21:47:12] [PASSED] 12.00 Xe_M
[21:47:12] [PASSED] 12.55 Xe_HPM
[21:47:12] [PASSED] 13.00 Xe_LPM+
[21:47:12] [PASSED] 13.01 Xe2_HPM
[21:47:12] [PASSED] 20.00 Xe2_LPM
[21:47:12] [PASSED] 30.00 Xe3_LPM
[21:47:12] [PASSED] 30.02 Xe3_LPM
[21:47:12] [PASSED] 35.00 Xe3p_LPM
[21:47:12] [PASSED] 35.03 Xe3p_HPM
[21:47:12] ================= [PASSED] check_media_ip ==================
[21:47:12] =================== check_platform_desc  ===================
[21:47:12] [PASSED] 0x9A60 (TIGERLAKE)
[21:47:12] [PASSED] 0x9A68 (TIGERLAKE)
[21:47:12] [PASSED] 0x9A70 (TIGERLAKE)
[21:47:12] [PASSED] 0x9A40 (TIGERLAKE)
[21:47:12] [PASSED] 0x9A49 (TIGERLAKE)
[21:47:12] [PASSED] 0x9A59 (TIGERLAKE)
[21:47:12] [PASSED] 0x9A78 (TIGERLAKE)
[21:47:12] [PASSED] 0x9AC0 (TIGERLAKE)
[21:47:12] [PASSED] 0x9AC9 (TIGERLAKE)
[21:47:12] [PASSED] 0x9AD9 (TIGERLAKE)
[21:47:12] [PASSED] 0x9AF8 (TIGERLAKE)
[21:47:12] [PASSED] 0x4C80 (ROCKETLAKE)
[21:47:12] [PASSED] 0x4C8A (ROCKETLAKE)
[21:47:12] [PASSED] 0x4C8B (ROCKETLAKE)
[21:47:12] [PASSED] 0x4C8C (ROCKETLAKE)
[21:47:12] [PASSED] 0x4C90 (ROCKETLAKE)
[21:47:12] [PASSED] 0x4C9A (ROCKETLAKE)
[21:47:12] [PASSED] 0x4680 (ALDERLAKE_S)
[21:47:12] [PASSED] 0x4682 (ALDERLAKE_S)
[21:47:12] [PASSED] 0x4688 (ALDERLAKE_S)
[21:47:12] [PASSED] 0x468A (ALDERLAKE_S)
[21:47:12] [PASSED] 0x468B (ALDERLAKE_S)
[21:47:12] [PASSED] 0x4690 (ALDERLAKE_S)
[21:47:12] [PASSED] 0x4692 (ALDERLAKE_S)
[21:47:12] [PASSED] 0x4693 (ALDERLAKE_S)
[21:47:12] [PASSED] 0x46A0 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46A1 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46A2 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46A3 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46A6 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46A8 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46AA (ALDERLAKE_P)
[21:47:12] [PASSED] 0x462A (ALDERLAKE_P)
[21:47:12] [PASSED] 0x4626 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x4628 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46B0 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46B1 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46B2 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46B3 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46C0 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46C1 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46C2 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46C3 (ALDERLAKE_P)
[21:47:12] [PASSED] 0x46D0 (ALDERLAKE_N)
[21:47:12] [PASSED] 0x46D1 (ALDERLAKE_N)
[21:47:12] [PASSED] 0x46D2 (ALDERLAKE_N)
[21:47:12] [PASSED] 0x46D3 (ALDERLAKE_N)
[21:47:12] [PASSED] 0x46D4 (ALDERLAKE_N)
[21:47:12] [PASSED] 0xA721 (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7A1 (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7A9 (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7AC (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7AD (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA720 (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7A0 (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7A8 (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7AA (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA7AB (ALDERLAKE_P)
[21:47:12] [PASSED] 0xA780 (ALDERLAKE_S)
[21:47:12] [PASSED] 0xA781 (ALDERLAKE_S)
[21:47:12] [PASSED] 0xA782 (ALDERLAKE_S)
[21:47:12] [PASSED] 0xA783 (ALDERLAKE_S)
[21:47:12] [PASSED] 0xA788 (ALDERLAKE_S)
[21:47:12] [PASSED] 0xA789 (ALDERLAKE_S)
[21:47:12] [PASSED] 0xA78A (ALDERLAKE_S)
[21:47:12] [PASSED] 0xA78B (ALDERLAKE_S)
[21:47:12] [PASSED] 0x4905 (DG1)
[21:47:12] [PASSED] 0x4906 (DG1)
[21:47:12] [PASSED] 0x4907 (DG1)
[21:47:12] [PASSED] 0x4908 (DG1)
[21:47:12] [PASSED] 0x4909 (DG1)
[21:47:12] [PASSED] 0x56C0 (DG2)
[21:47:12] [PASSED] 0x56C2 (DG2)
[21:47:12] [PASSED] 0x56C1 (DG2)
[21:47:12] [PASSED] 0x7D51 (METEORLAKE)
[21:47:12] [PASSED] 0x7DD1 (METEORLAKE)
[21:47:12] [PASSED] 0x7D41 (METEORLAKE)
[21:47:12] [PASSED] 0x7D67 (METEORLAKE)
[21:47:12] [PASSED] 0xB640 (METEORLAKE)
[21:47:12] [PASSED] 0x56A0 (DG2)
[21:47:12] [PASSED] 0x56A1 (DG2)
[21:47:12] [PASSED] 0x56A2 (DG2)
[21:47:12] [PASSED] 0x56BE (DG2)
[21:47:12] [PASSED] 0x56BF (DG2)
[21:47:12] [PASSED] 0x5690 (DG2)
[21:47:12] [PASSED] 0x5691 (DG2)
[21:47:12] [PASSED] 0x5692 (DG2)
[21:47:12] [PASSED] 0x56A5 (DG2)
[21:47:12] [PASSED] 0x56A6 (DG2)
[21:47:12] [PASSED] 0x56B0 (DG2)
[21:47:12] [PASSED] 0x56B1 (DG2)
[21:47:12] [PASSED] 0x56BA (DG2)
[21:47:12] [PASSED] 0x56BB (DG2)
[21:47:12] [PASSED] 0x56BC (DG2)
[21:47:12] [PASSED] 0x56BD (DG2)
[21:47:12] [PASSED] 0x5693 (DG2)
[21:47:12] [PASSED] 0x5694 (DG2)
[21:47:12] [PASSED] 0x5695 (DG2)
[21:47:12] [PASSED] 0x56A3 (DG2)
[21:47:12] [PASSED] 0x56A4 (DG2)
[21:47:12] [PASSED] 0x56B2 (DG2)
[21:47:12] [PASSED] 0x56B3 (DG2)
[21:47:12] [PASSED] 0x5696 (DG2)
[21:47:12] [PASSED] 0x5697 (DG2)
[21:47:12] [PASSED] 0xB69 (PVC)
[21:47:12] [PASSED] 0xB6E (PVC)
[21:47:12] [PASSED] 0xBD4 (PVC)
[21:47:12] [PASSED] 0xBD5 (PVC)
[21:47:12] [PASSED] 0xBD6 (PVC)
[21:47:12] [PASSED] 0xBD7 (PVC)
[21:47:12] [PASSED] 0xBD8 (PVC)
[21:47:12] [PASSED] 0xBD9 (PVC)
[21:47:12] [PASSED] 0xBDA (PVC)
[21:47:12] [PASSED] 0xBDB (PVC)
[21:47:12] [PASSED] 0xBE0 (PVC)
[21:47:12] [PASSED] 0xBE1 (PVC)
[21:47:12] [PASSED] 0xBE5 (PVC)
[21:47:12] [PASSED] 0x7D40 (METEORLAKE)
[21:47:12] [PASSED] 0x7D45 (METEORLAKE)
[21:47:12] [PASSED] 0x7D55 (METEORLAKE)
[21:47:12] [PASSED] 0x7D60 (METEORLAKE)
[21:47:12] [PASSED] 0x7DD5 (METEORLAKE)
[21:47:12] [PASSED] 0x6420 (LUNARLAKE)
[21:47:12] [PASSED] 0x64A0 (LUNARLAKE)
[21:47:12] [PASSED] 0x64B0 (LUNARLAKE)
[21:47:12] [PASSED] 0xE202 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE209 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE20B (BATTLEMAGE)
[21:47:12] [PASSED] 0xE20C (BATTLEMAGE)
[21:47:12] [PASSED] 0xE20D (BATTLEMAGE)
[21:47:12] [PASSED] 0xE210 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE211 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE212 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE216 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE220 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE221 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE222 (BATTLEMAGE)
[21:47:12] [PASSED] 0xE223 (BATTLEMAGE)
[21:47:12] [PASSED] 0xB080 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB081 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB082 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB083 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB084 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB085 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB086 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB087 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB08F (PANTHERLAKE)
[21:47:12] [PASSED] 0xB090 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB0A0 (PANTHERLAKE)
[21:47:12] [PASSED] 0xB0B0 (PANTHERLAKE)
[21:47:12] [PASSED] 0xFD80 (PANTHERLAKE)
[21:47:12] [PASSED] 0xFD81 (PANTHERLAKE)
[21:47:12] [PASSED] 0xD740 (NOVALAKE_S)
[21:47:12] [PASSED] 0xD741 (NOVALAKE_S)
[21:47:12] [PASSED] 0xD742 (NOVALAKE_S)
[21:47:12] [PASSED] 0xD743 (NOVALAKE_S)
[21:47:12] [PASSED] 0xD744 (NOVALAKE_S)
[21:47:12] [PASSED] 0xD745 (NOVALAKE_S)
[21:47:12] =============== [PASSED] check_platform_desc ===============
[21:47:12] ===================== [PASSED] xe_pci ======================
[21:47:12] =================== xe_rtp (2 subtests) ====================
[21:47:12] =============== xe_rtp_process_to_sr_tests  ================
[21:47:12] [PASSED] coalesce-same-reg
[21:47:12] [PASSED] no-match-no-add
[21:47:12] [PASSED] match-or
[21:47:12] [PASSED] match-or-xfail
[21:47:12] [PASSED] no-match-no-add-multiple-rules
[21:47:12] [PASSED] two-regs-two-entries
[21:47:12] [PASSED] clr-one-set-other
[21:47:12] [PASSED] set-field
[21:47:12] [PASSED] conflict-duplicate
[21:47:12] [PASSED] conflict-not-disjoint
[21:47:12] [PASSED] conflict-reg-type
[21:47:12] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[21:47:12] ================== xe_rtp_process_tests  ===================
[21:47:12] [PASSED] active1
[21:47:12] [PASSED] active2
[21:47:12] [PASSED] active-inactive
[21:47:12] [PASSED] inactive-active
[21:47:12] [PASSED] inactive-1st_or_active-inactive
[21:47:12] [PASSED] inactive-2nd_or_active-inactive
[21:47:12] [PASSED] inactive-last_or_active-inactive
[21:47:12] [PASSED] inactive-no_or_active-inactive
stty: 'standard input': Inappropriate ioctl for device
[21:47:12] ============== [PASSED] xe_rtp_process_tests ===============
[21:47:12] ===================== [PASSED] xe_rtp ======================
[21:47:12] ==================== xe_wa (1 subtest) =====================
[21:47:12] ======================== xe_wa_gt  =========================
[21:47:12] [PASSED] TIGERLAKE B0
[21:47:12] [PASSED] DG1 A0
[21:47:12] [PASSED] DG1 B0
[21:47:12] [PASSED] ALDERLAKE_S A0
[21:47:12] [PASSED] ALDERLAKE_S B0
[21:47:12] [PASSED] ALDERLAKE_S C0
[21:47:12] [PASSED] ALDERLAKE_S D0
[21:47:12] [PASSED] ALDERLAKE_P A0
[21:47:12] [PASSED] ALDERLAKE_P B0
[21:47:12] [PASSED] ALDERLAKE_P C0
[21:47:12] [PASSED] ALDERLAKE_S RPLS D0
[21:47:12] [PASSED] ALDERLAKE_P RPLU E0
[21:47:12] [PASSED] DG2 G10 C0
[21:47:12] [PASSED] DG2 G11 B1
[21:47:12] [PASSED] DG2 G12 A1
[21:47:12] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[21:47:12] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[21:47:12] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[21:47:12] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[21:47:12] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[21:47:12] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[21:47:12] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[21:47:12] ==================== [PASSED] xe_wa_gt =====================
[21:47:12] ====================== [PASSED] xe_wa ======================
[21:47:12] ============================================================
[21:47:12] Testing complete. Ran 317 tests: passed: 299, skipped: 18
[21:47:12] Elapsed time: 35.067s total, 4.194s configuring, 30.506s building, 0.328s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[21:47:12] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[21:47:14] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[21:47:39] Starting KUnit Kernel (1/1)...
[21:47:39] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[21:47:39] ============ drm_test_pick_cmdline (2 subtests) ============
[21:47:39] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[21:47:39] =============== drm_test_pick_cmdline_named  ===============
[21:47:39] [PASSED] NTSC
[21:47:39] [PASSED] NTSC-J
[21:47:39] [PASSED] PAL
[21:47:39] [PASSED] PAL-M
[21:47:39] =========== [PASSED] drm_test_pick_cmdline_named ===========
[21:47:39] ============== [PASSED] drm_test_pick_cmdline ==============
[21:47:39] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[21:47:39] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[21:47:39] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[21:47:39] =========== drm_validate_clone_mode (2 subtests) ===========
[21:47:39] ============== drm_test_check_in_clone_mode  ===============
[21:47:39] [PASSED] in_clone_mode
[21:47:39] [PASSED] not_in_clone_mode
[21:47:39] ========== [PASSED] drm_test_check_in_clone_mode ===========
[21:47:39] =============== drm_test_check_valid_clones  ===============
[21:47:39] [PASSED] not_in_clone_mode
[21:47:39] [PASSED] valid_clone
[21:47:39] [PASSED] invalid_clone
[21:47:39] =========== [PASSED] drm_test_check_valid_clones ===========
[21:47:39] ============= [PASSED] drm_validate_clone_mode =============
[21:47:39] ============= drm_validate_modeset (1 subtest) =============
[21:47:39] [PASSED] drm_test_check_connector_changed_modeset
[21:47:39] ============== [PASSED] drm_validate_modeset ===============
[21:47:39] ====== drm_test_bridge_get_current_state (2 subtests) ======
[21:47:39] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[21:47:39] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[21:47:39] ======== [PASSED] drm_test_bridge_get_current_state ========
[21:47:39] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[21:47:39] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[21:47:39] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[21:47:39] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[21:47:39] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[21:47:39] ============== drm_bridge_alloc (2 subtests) ===============
[21:47:39] [PASSED] drm_test_drm_bridge_alloc_basic
[21:47:39] [PASSED] drm_test_drm_bridge_alloc_get_put
[21:47:39] ================ [PASSED] drm_bridge_alloc =================
[21:47:39] ================== drm_buddy (8 subtests) ==================
[21:47:39] [PASSED] drm_test_buddy_alloc_limit
[21:47:39] [PASSED] drm_test_buddy_alloc_optimistic
[21:47:39] [PASSED] drm_test_buddy_alloc_pessimistic
[21:47:39] [PASSED] drm_test_buddy_alloc_pathological
[21:47:39] [PASSED] drm_test_buddy_alloc_contiguous
[21:47:39] [PASSED] drm_test_buddy_alloc_clear
[21:47:39] [PASSED] drm_test_buddy_alloc_range_bias
[21:47:39] [PASSED] drm_test_buddy_fragmentation_performance
[21:47:39] ==================== [PASSED] drm_buddy ====================
[21:47:39] ============= drm_cmdline_parser (40 subtests) =============
[21:47:39] [PASSED] drm_test_cmdline_force_d_only
[21:47:39] [PASSED] drm_test_cmdline_force_D_only_dvi
[21:47:39] [PASSED] drm_test_cmdline_force_D_only_hdmi
[21:47:39] [PASSED] drm_test_cmdline_force_D_only_not_digital
[21:47:39] [PASSED] drm_test_cmdline_force_e_only
[21:47:39] [PASSED] drm_test_cmdline_res
[21:47:39] [PASSED] drm_test_cmdline_res_vesa
[21:47:39] [PASSED] drm_test_cmdline_res_vesa_rblank
[21:47:39] [PASSED] drm_test_cmdline_res_rblank
[21:47:39] [PASSED] drm_test_cmdline_res_bpp
[21:47:39] [PASSED] drm_test_cmdline_res_refresh
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[21:47:39] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[21:47:39] [PASSED] drm_test_cmdline_res_margins_force_on
[21:47:39] [PASSED] drm_test_cmdline_res_vesa_margins
[21:47:39] [PASSED] drm_test_cmdline_name
[21:47:39] [PASSED] drm_test_cmdline_name_bpp
[21:47:39] [PASSED] drm_test_cmdline_name_option
[21:47:39] [PASSED] drm_test_cmdline_name_bpp_option
[21:47:39] [PASSED] drm_test_cmdline_rotate_0
[21:47:39] [PASSED] drm_test_cmdline_rotate_90
[21:47:39] [PASSED] drm_test_cmdline_rotate_180
[21:47:39] [PASSED] drm_test_cmdline_rotate_270
[21:47:39] [PASSED] drm_test_cmdline_hmirror
[21:47:39] [PASSED] drm_test_cmdline_vmirror
[21:47:39] [PASSED] drm_test_cmdline_margin_options
[21:47:39] [PASSED] drm_test_cmdline_multiple_options
[21:47:39] [PASSED] drm_test_cmdline_bpp_extra_and_option
[21:47:39] [PASSED] drm_test_cmdline_extra_and_option
[21:47:39] [PASSED] drm_test_cmdline_freestanding_options
[21:47:39] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[21:47:39] [PASSED] drm_test_cmdline_panel_orientation
[21:47:39] ================ drm_test_cmdline_invalid  =================
[21:47:39] [PASSED] margin_only
[21:47:39] [PASSED] interlace_only
[21:47:39] [PASSED] res_missing_x
[21:47:39] [PASSED] res_missing_y
[21:47:39] [PASSED] res_bad_y
[21:47:39] [PASSED] res_missing_y_bpp
[21:47:39] [PASSED] res_bad_bpp
[21:47:39] [PASSED] res_bad_refresh
[21:47:39] [PASSED] res_bpp_refresh_force_on_off
[21:47:39] [PASSED] res_invalid_mode
[21:47:39] [PASSED] res_bpp_wrong_place_mode
[21:47:39] [PASSED] name_bpp_refresh
[21:47:39] [PASSED] name_refresh
[21:47:39] [PASSED] name_refresh_wrong_mode
[21:47:39] [PASSED] name_refresh_invalid_mode
[21:47:39] [PASSED] rotate_multiple
[21:47:39] [PASSED] rotate_invalid_val
[21:47:39] [PASSED] rotate_truncated
[21:47:39] [PASSED] invalid_option
[21:47:39] [PASSED] invalid_tv_option
[21:47:39] [PASSED] truncated_tv_option
[21:47:39] ============ [PASSED] drm_test_cmdline_invalid =============
[21:47:39] =============== drm_test_cmdline_tv_options  ===============
[21:47:39] [PASSED] NTSC
[21:47:39] [PASSED] NTSC_443
[21:47:39] [PASSED] NTSC_J
[21:47:39] [PASSED] PAL
[21:47:39] [PASSED] PAL_M
[21:47:39] [PASSED] PAL_N
[21:47:39] [PASSED] SECAM
[21:47:39] [PASSED] MONO_525
[21:47:39] [PASSED] MONO_625
[21:47:39] =========== [PASSED] drm_test_cmdline_tv_options ===========
[21:47:39] =============== [PASSED] drm_cmdline_parser ================
[21:47:39] ========== drmm_connector_hdmi_init (20 subtests) ==========
[21:47:39] [PASSED] drm_test_connector_hdmi_init_valid
[21:47:39] [PASSED] drm_test_connector_hdmi_init_bpc_8
[21:47:39] [PASSED] drm_test_connector_hdmi_init_bpc_10
[21:47:39] [PASSED] drm_test_connector_hdmi_init_bpc_12
[21:47:39] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[21:47:39] [PASSED] drm_test_connector_hdmi_init_bpc_null
[21:47:39] [PASSED] drm_test_connector_hdmi_init_formats_empty
[21:47:39] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[21:47:39] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[21:47:39] [PASSED] supported_formats=0x9 yuv420_allowed=1
[21:47:39] [PASSED] supported_formats=0x9 yuv420_allowed=0
[21:47:39] [PASSED] supported_formats=0x3 yuv420_allowed=1
[21:47:39] [PASSED] supported_formats=0x3 yuv420_allowed=0
[21:47:39] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[21:47:39] [PASSED] drm_test_connector_hdmi_init_null_ddc
[21:47:39] [PASSED] drm_test_connector_hdmi_init_null_product
[21:47:39] [PASSED] drm_test_connector_hdmi_init_null_vendor
[21:47:39] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[21:47:39] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[21:47:39] [PASSED] drm_test_connector_hdmi_init_product_valid
[21:47:39] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[21:47:39] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[21:47:39] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[21:47:39] ========= drm_test_connector_hdmi_init_type_valid  =========
[21:47:39] [PASSED] HDMI-A
[21:47:39] [PASSED] HDMI-B
[21:47:39] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[21:47:39] ======== drm_test_connector_hdmi_init_type_invalid  ========
[21:47:39] [PASSED] Unknown
[21:47:39] [PASSED] VGA
[21:47:39] [PASSED] DVI-I
[21:47:39] [PASSED] DVI-D
[21:47:39] [PASSED] DVI-A
[21:47:39] [PASSED] Composite
[21:47:39] [PASSED] SVIDEO
[21:47:39] [PASSED] LVDS
[21:47:39] [PASSED] Component
[21:47:39] [PASSED] DIN
[21:47:39] [PASSED] DP
[21:47:39] [PASSED] TV
[21:47:39] [PASSED] eDP
[21:47:39] [PASSED] Virtual
[21:47:39] [PASSED] DSI
[21:47:39] [PASSED] DPI
[21:47:39] [PASSED] Writeback
[21:47:39] [PASSED] SPI
[21:47:39] [PASSED] USB
[21:47:39] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[21:47:39] ============ [PASSED] drmm_connector_hdmi_init =============
[21:47:39] ============= drmm_connector_init (3 subtests) =============
[21:47:39] [PASSED] drm_test_drmm_connector_init
[21:47:39] [PASSED] drm_test_drmm_connector_init_null_ddc
[21:47:39] ========= drm_test_drmm_connector_init_type_valid  =========
[21:47:39] [PASSED] Unknown
[21:47:39] [PASSED] VGA
[21:47:39] [PASSED] DVI-I
[21:47:39] [PASSED] DVI-D
[21:47:39] [PASSED] DVI-A
[21:47:39] [PASSED] Composite
[21:47:39] [PASSED] SVIDEO
[21:47:39] [PASSED] LVDS
[21:47:39] [PASSED] Component
[21:47:39] [PASSED] DIN
[21:47:39] [PASSED] DP
[21:47:39] [PASSED] HDMI-A
[21:47:39] [PASSED] HDMI-B
[21:47:39] [PASSED] TV
[21:47:39] [PASSED] eDP
[21:47:39] [PASSED] Virtual
[21:47:39] [PASSED] DSI
[21:47:39] [PASSED] DPI
[21:47:39] [PASSED] Writeback
[21:47:39] [PASSED] SPI
[21:47:39] [PASSED] USB
[21:47:39] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[21:47:39] =============== [PASSED] drmm_connector_init ===============
[21:47:39] ========= drm_connector_dynamic_init (6 subtests) ==========
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_init
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_init_properties
[21:47:39] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[21:47:39] [PASSED] Unknown
[21:47:39] [PASSED] VGA
[21:47:39] [PASSED] DVI-I
[21:47:39] [PASSED] DVI-D
[21:47:39] [PASSED] DVI-A
[21:47:39] [PASSED] Composite
[21:47:39] [PASSED] SVIDEO
[21:47:39] [PASSED] LVDS
[21:47:39] [PASSED] Component
[21:47:39] [PASSED] DIN
[21:47:39] [PASSED] DP
[21:47:39] [PASSED] HDMI-A
[21:47:39] [PASSED] HDMI-B
[21:47:39] [PASSED] TV
[21:47:39] [PASSED] eDP
[21:47:39] [PASSED] Virtual
[21:47:39] [PASSED] DSI
[21:47:39] [PASSED] DPI
[21:47:39] [PASSED] Writeback
[21:47:39] [PASSED] SPI
[21:47:39] [PASSED] USB
[21:47:39] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[21:47:39] ======== drm_test_drm_connector_dynamic_init_name  =========
[21:47:39] [PASSED] Unknown
[21:47:39] [PASSED] VGA
[21:47:39] [PASSED] DVI-I
[21:47:39] [PASSED] DVI-D
[21:47:39] [PASSED] DVI-A
[21:47:39] [PASSED] Composite
[21:47:39] [PASSED] SVIDEO
[21:47:39] [PASSED] LVDS
[21:47:39] [PASSED] Component
[21:47:39] [PASSED] DIN
[21:47:39] [PASSED] DP
[21:47:39] [PASSED] HDMI-A
[21:47:39] [PASSED] HDMI-B
[21:47:39] [PASSED] TV
[21:47:39] [PASSED] eDP
[21:47:39] [PASSED] Virtual
[21:47:39] [PASSED] DSI
[21:47:39] [PASSED] DPI
[21:47:39] [PASSED] Writeback
[21:47:39] [PASSED] SPI
[21:47:39] [PASSED] USB
[21:47:39] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[21:47:39] =========== [PASSED] drm_connector_dynamic_init ============
[21:47:39] ==== drm_connector_dynamic_register_early (4 subtests) =====
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[21:47:39] ====== [PASSED] drm_connector_dynamic_register_early =======
[21:47:39] ======= drm_connector_dynamic_register (7 subtests) ========
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[21:47:39] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[21:47:39] ========= [PASSED] drm_connector_dynamic_register ==========
[21:47:39] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[21:47:39] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[21:47:39] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[21:47:39] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[21:47:39] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[21:47:39] ========== drm_test_get_tv_mode_from_name_valid  ===========
[21:47:39] [PASSED] NTSC
[21:47:39] [PASSED] NTSC-443
[21:47:39] [PASSED] NTSC-J
[21:47:39] [PASSED] PAL
[21:47:39] [PASSED] PAL-M
[21:47:39] [PASSED] PAL-N
[21:47:39] [PASSED] SECAM
[21:47:39] [PASSED] Mono
[21:47:39] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[21:47:39] [PASSED] drm_test_get_tv_mode_from_name_truncated
[21:47:39] ============ [PASSED] drm_get_tv_mode_from_name ============
[21:47:39] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[21:47:39] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[21:47:39] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[21:47:39] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[21:47:39] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[21:47:39] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[21:47:39] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[21:47:39] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[21:47:39] [PASSED] VIC 96
[21:47:39] [PASSED] VIC 97
[21:47:39] [PASSED] VIC 101
[21:47:39] [PASSED] VIC 102
[21:47:39] [PASSED] VIC 106
[21:47:39] [PASSED] VIC 107
[21:47:39] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[21:47:39] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[21:47:39] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[21:47:39] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[21:47:39] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[21:47:39] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[21:47:39] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[21:47:39] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[21:47:39] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[21:47:39] [PASSED] Automatic
[21:47:39] [PASSED] Full
[21:47:39] [PASSED] Limited 16:235
[21:47:39] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[21:47:39] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[21:47:39] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[21:47:39] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[21:47:39] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[21:47:39] [PASSED] RGB
[21:47:39] [PASSED] YUV 4:2:0
[21:47:39] [PASSED] YUV 4:2:2
[21:47:39] [PASSED] YUV 4:4:4
[21:47:39] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[21:47:39] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[21:47:39] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[21:47:39] ============= drm_damage_helper (21 subtests) ==============
[21:47:39] [PASSED] drm_test_damage_iter_no_damage
[21:47:39] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[21:47:39] [PASSED] drm_test_damage_iter_no_damage_src_moved
[21:47:39] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[21:47:39] [PASSED] drm_test_damage_iter_no_damage_not_visible
[21:47:39] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[21:47:39] [PASSED] drm_test_damage_iter_no_damage_no_fb
[21:47:39] [PASSED] drm_test_damage_iter_simple_damage
[21:47:39] [PASSED] drm_test_damage_iter_single_damage
[21:47:39] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[21:47:39] [PASSED] drm_test_damage_iter_single_damage_outside_src
[21:47:39] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[21:47:39] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[21:47:39] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[21:47:39] [PASSED] drm_test_damage_iter_single_damage_src_moved
[21:47:39] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[21:47:39] [PASSED] drm_test_damage_iter_damage
[21:47:39] [PASSED] drm_test_damage_iter_damage_one_intersect
[21:47:39] [PASSED] drm_test_damage_iter_damage_one_outside
[21:47:39] [PASSED] drm_test_damage_iter_damage_src_moved
[21:47:39] [PASSED] drm_test_damage_iter_damage_not_visible
[21:47:39] ================ [PASSED] drm_damage_helper ================
[21:47:39] ============== drm_dp_mst_helper (3 subtests) ==============
[21:47:39] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[21:47:39] [PASSED] Clock 154000 BPP 30 DSC disabled
[21:47:39] [PASSED] Clock 234000 BPP 30 DSC disabled
[21:47:39] [PASSED] Clock 297000 BPP 24 DSC disabled
[21:47:39] [PASSED] Clock 332880 BPP 24 DSC enabled
[21:47:39] [PASSED] Clock 324540 BPP 24 DSC enabled
[21:47:39] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[21:47:39] ============== drm_test_dp_mst_calc_pbn_div  ===============
[21:47:39] [PASSED] Link rate 2000000 lane count 4
[21:47:39] [PASSED] Link rate 2000000 lane count 2
[21:47:39] [PASSED] Link rate 2000000 lane count 1
[21:47:39] [PASSED] Link rate 1350000 lane count 4
[21:47:39] [PASSED] Link rate 1350000 lane count 2
[21:47:39] [PASSED] Link rate 1350000 lane count 1
[21:47:39] [PASSED] Link rate 1000000 lane count 4
[21:47:39] [PASSED] Link rate 1000000 lane count 2
[21:47:39] [PASSED] Link rate 1000000 lane count 1
[21:47:39] [PASSED] Link rate 810000 lane count 4
[21:47:39] [PASSED] Link rate 810000 lane count 2
[21:47:39] [PASSED] Link rate 810000 lane count 1
[21:47:39] [PASSED] Link rate 540000 lane count 4
[21:47:39] [PASSED] Link rate 540000 lane count 2
[21:47:39] [PASSED] Link rate 540000 lane count 1
[21:47:39] [PASSED] Link rate 270000 lane count 4
[21:47:39] [PASSED] Link rate 270000 lane count 2
[21:47:39] [PASSED] Link rate 270000 lane count 1
[21:47:39] [PASSED] Link rate 162000 lane count 4
[21:47:39] [PASSED] Link rate 162000 lane count 2
[21:47:39] [PASSED] Link rate 162000 lane count 1
[21:47:39] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[21:47:39] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[21:47:39] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[21:47:39] [PASSED] DP_POWER_UP_PHY with port number
[21:47:39] [PASSED] DP_POWER_DOWN_PHY with port number
[21:47:39] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[21:47:39] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[21:47:39] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[21:47:39] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[21:47:39] [PASSED] DP_QUERY_PAYLOAD with port number
[21:47:39] [PASSED] DP_QUERY_PAYLOAD with VCPI
[21:47:39] [PASSED] DP_REMOTE_DPCD_READ with port number
[21:47:39] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[21:47:39] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[21:47:39] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[21:47:39] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[21:47:39] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[21:47:39] [PASSED] DP_REMOTE_I2C_READ with port number
[21:47:39] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[21:47:39] [PASSED] DP_REMOTE_I2C_READ with transactions array
[21:47:39] [PASSED] DP_REMOTE_I2C_WRITE with port number
[21:47:39] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[21:47:39] [PASSED] DP_REMOTE_I2C_WRITE with data array
[21:47:39] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[21:47:39] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[21:47:39] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[21:47:39] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[21:47:39] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[21:47:39] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[21:47:39] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[21:47:39] ================ [PASSED] drm_dp_mst_helper ================
[21:47:39] ================== drm_exec (7 subtests) ===================
[21:47:39] [PASSED] sanitycheck
[21:47:39] [PASSED] test_lock
[21:47:39] [PASSED] test_lock_unlock
[21:47:39] [PASSED] test_duplicates
[21:47:39] [PASSED] test_prepare
[21:47:39] [PASSED] test_prepare_array
[21:47:39] [PASSED] test_multiple_loops
[21:47:39] ==================== [PASSED] drm_exec =====================
[21:47:39] =========== drm_format_helper_test (17 subtests) ===========
[21:47:39] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[21:47:39] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[21:47:39] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[21:47:39] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[21:47:39] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[21:47:39] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[21:47:39] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[21:47:39] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[21:47:39] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[21:47:39] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[21:47:39] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[21:47:39] ============== drm_test_fb_xrgb8888_to_mono  ===============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[21:47:39] ==================== drm_test_fb_swab  =====================
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ================ [PASSED] drm_test_fb_swab =================
[21:47:39] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[21:47:39] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[21:47:39] [PASSED] single_pixel_source_buffer
[21:47:39] [PASSED] single_pixel_clip_rectangle
[21:47:39] [PASSED] well_known_colors
[21:47:39] [PASSED] destination_pitch
[21:47:39] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[21:47:39] ================= drm_test_fb_clip_offset  =================
[21:47:39] [PASSED] pass through
[21:47:39] [PASSED] horizontal offset
[21:47:39] [PASSED] vertical offset
[21:47:39] [PASSED] horizontal and vertical offset
[21:47:39] [PASSED] horizontal offset (custom pitch)
[21:47:39] [PASSED] vertical offset (custom pitch)
[21:47:39] [PASSED] horizontal and vertical offset (custom pitch)
[21:47:39] ============= [PASSED] drm_test_fb_clip_offset =============
[21:47:39] =================== drm_test_fb_memcpy  ====================
[21:47:39] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[21:47:39] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[21:47:39] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[21:47:39] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[21:47:39] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[21:47:39] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[21:47:39] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[21:47:39] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[21:47:39] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[21:47:39] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[21:47:39] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[21:47:39] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[21:47:39] =============== [PASSED] drm_test_fb_memcpy ================
[21:47:39] ============= [PASSED] drm_format_helper_test ==============
[21:47:39] ================= drm_format (18 subtests) =================
[21:47:39] [PASSED] drm_test_format_block_width_invalid
[21:47:39] [PASSED] drm_test_format_block_width_one_plane
[21:47:39] [PASSED] drm_test_format_block_width_two_plane
[21:47:39] [PASSED] drm_test_format_block_width_three_plane
[21:47:39] [PASSED] drm_test_format_block_width_tiled
[21:47:39] [PASSED] drm_test_format_block_height_invalid
[21:47:39] [PASSED] drm_test_format_block_height_one_plane
[21:47:39] [PASSED] drm_test_format_block_height_two_plane
[21:47:39] [PASSED] drm_test_format_block_height_three_plane
[21:47:39] [PASSED] drm_test_format_block_height_tiled
[21:47:39] [PASSED] drm_test_format_min_pitch_invalid
[21:47:39] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[21:47:39] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[21:47:39] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[21:47:39] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[21:47:39] [PASSED] drm_test_format_min_pitch_two_plane
[21:47:39] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[21:47:39] [PASSED] drm_test_format_min_pitch_tiled
[21:47:39] =================== [PASSED] drm_format ====================
[21:47:39] ============== drm_framebuffer (10 subtests) ===============
[21:47:39] ========== drm_test_framebuffer_check_src_coords  ==========
[21:47:39] [PASSED] Success: source fits into fb
[21:47:39] [PASSED] Fail: overflowing fb with x-axis coordinate
[21:47:39] [PASSED] Fail: overflowing fb with y-axis coordinate
[21:47:39] [PASSED] Fail: overflowing fb with source width
[21:47:39] [PASSED] Fail: overflowing fb with source height
[21:47:39] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[21:47:39] [PASSED] drm_test_framebuffer_cleanup
[21:47:39] =============== drm_test_framebuffer_create  ===============
[21:47:39] [PASSED] ABGR8888 normal sizes
[21:47:39] [PASSED] ABGR8888 max sizes
[21:47:39] [PASSED] ABGR8888 pitch greater than min required
[21:47:39] [PASSED] ABGR8888 pitch less than min required
[21:47:39] [PASSED] ABGR8888 Invalid width
[21:47:39] [PASSED] ABGR8888 Invalid buffer handle
[21:47:39] [PASSED] No pixel format
[21:47:39] [PASSED] ABGR8888 Width 0
[21:47:39] [PASSED] ABGR8888 Height 0
[21:47:39] [PASSED] ABGR8888 Out of bound height * pitch combination
[21:47:39] [PASSED] ABGR8888 Large buffer offset
[21:47:39] [PASSED] ABGR8888 Buffer offset for inexistent plane
[21:47:39] [PASSED] ABGR8888 Invalid flag
[21:47:39] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[21:47:39] [PASSED] ABGR8888 Valid buffer modifier
[21:47:39] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[21:47:39] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[21:47:39] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[21:47:39] [PASSED] NV12 Normal sizes
[21:47:39] [PASSED] NV12 Max sizes
[21:47:39] [PASSED] NV12 Invalid pitch
[21:47:39] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[21:47:39] [PASSED] NV12 different  modifier per-plane
[21:47:39] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[21:47:39] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[21:47:39] [PASSED] NV12 Modifier for inexistent plane
[21:47:39] [PASSED] NV12 Handle for inexistent plane
[21:47:39] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[21:47:39] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[21:47:39] [PASSED] YVU420 Normal sizes
[21:47:39] [PASSED] YVU420 Max sizes
[21:47:39] [PASSED] YVU420 Invalid pitch
[21:47:39] [PASSED] YVU420 Different pitches
[21:47:39] [PASSED] YVU420 Different buffer offsets/pitches
[21:47:39] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[21:47:39] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[21:47:39] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[21:47:39] [PASSED] YVU420 Valid modifier
[21:47:39] [PASSED] YVU420 Different modifiers per plane
[21:47:39] [PASSED] YVU420 Modifier for inexistent plane
[21:47:39] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[21:47:39] [PASSED] X0L2 Normal sizes
[21:47:39] [PASSED] X0L2 Max sizes
[21:47:39] [PASSED] X0L2 Invalid pitch
[21:47:39] [PASSED] X0L2 Pitch greater than minimum required
[21:47:39] [PASSED] X0L2 Handle for inexistent plane
[21:47:39] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[21:47:39] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[21:47:39] [PASSED] X0L2 Valid modifier
[21:47:39] [PASSED] X0L2 Modifier for inexistent plane
[21:47:39] =========== [PASSED] drm_test_framebuffer_create ===========
[21:47:39] [PASSED] drm_test_framebuffer_free
[21:47:39] [PASSED] drm_test_framebuffer_init
[21:47:39] [PASSED] drm_test_framebuffer_init_bad_format
[21:47:39] [PASSED] drm_test_framebuffer_init_dev_mismatch
[21:47:39] [PASSED] drm_test_framebuffer_lookup
[21:47:39] [PASSED] drm_test_framebuffer_lookup_inexistent
[21:47:39] [PASSED] drm_test_framebuffer_modifiers_not_supported
[21:47:39] ================= [PASSED] drm_framebuffer =================
[21:47:39] ================ drm_gem_shmem (8 subtests) ================
[21:47:39] [PASSED] drm_gem_shmem_test_obj_create
[21:47:39] [PASSED] drm_gem_shmem_test_obj_create_private
[21:47:39] [PASSED] drm_gem_shmem_test_pin_pages
[21:47:39] [PASSED] drm_gem_shmem_test_vmap
[21:47:39] [PASSED] drm_gem_shmem_test_get_pages_sgt
[21:47:39] [PASSED] drm_gem_shmem_test_get_sg_table
[21:47:39] [PASSED] drm_gem_shmem_test_madvise
[21:47:39] [PASSED] drm_gem_shmem_test_purge
[21:47:39] ================== [PASSED] drm_gem_shmem ==================
[21:47:39] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[21:47:39] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[21:47:39] [PASSED] Automatic
[21:47:39] [PASSED] Full
[21:47:39] [PASSED] Limited 16:235
[21:47:39] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[21:47:39] [PASSED] drm_test_check_disable_connector
[21:47:39] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[21:47:39] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[21:47:39] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[21:47:39] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[21:47:39] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[21:47:39] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[21:47:39] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[21:47:39] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[21:47:39] [PASSED] drm_test_check_output_bpc_dvi
[21:47:39] [PASSED] drm_test_check_output_bpc_format_vic_1
[21:47:39] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[21:47:39] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[21:47:39] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[21:47:39] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[21:47:39] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[21:47:39] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[21:47:39] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[21:47:39] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[21:47:39] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[21:47:39] [PASSED] drm_test_check_broadcast_rgb_value
[21:47:39] [PASSED] drm_test_check_bpc_8_value
[21:47:39] [PASSED] drm_test_check_bpc_10_value
[21:47:39] [PASSED] drm_test_check_bpc_12_value
[21:47:39] [PASSED] drm_test_check_format_value
[21:47:39] [PASSED] drm_test_check_tmds_char_value
[21:47:39] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[21:47:39] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[21:47:39] [PASSED] drm_test_check_mode_valid
[21:47:39] [PASSED] drm_test_check_mode_valid_reject
[21:47:39] [PASSED] drm_test_check_mode_valid_reject_rate
[21:47:39] [PASSED] drm_test_check_mode_valid_reject_max_clock
[21:47:39] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[21:47:39] ================= drm_managed (2 subtests) =================
[21:47:39] [PASSED] drm_test_managed_release_action
[21:47:39] [PASSED] drm_test_managed_run_action
[21:47:39] =================== [PASSED] drm_managed ===================
[21:47:39] =================== drm_mm (6 subtests) ====================
[21:47:39] [PASSED] drm_test_mm_init
[21:47:39] [PASSED] drm_test_mm_debug
[21:47:39] [PASSED] drm_test_mm_align32
[21:47:39] [PASSED] drm_test_mm_align64
[21:47:39] [PASSED] drm_test_mm_lowest
[21:47:39] [PASSED] drm_test_mm_highest
[21:47:39] ===================== [PASSED] drm_mm ======================
[21:47:39] ============= drm_modes_analog_tv (5 subtests) =============
[21:47:39] [PASSED] drm_test_modes_analog_tv_mono_576i
[21:47:39] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[21:47:39] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[21:47:39] [PASSED] drm_test_modes_analog_tv_pal_576i
[21:47:39] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[21:47:39] =============== [PASSED] drm_modes_analog_tv ===============
[21:47:39] ============== drm_plane_helper (2 subtests) ===============
[21:47:39] =============== drm_test_check_plane_state  ================
[21:47:39] [PASSED] clipping_simple
[21:47:39] [PASSED] clipping_rotate_reflect
[21:47:39] [PASSED] positioning_simple
[21:47:39] [PASSED] upscaling
[21:47:39] [PASSED] downscaling
[21:47:39] [PASSED] rounding1
[21:47:39] [PASSED] rounding2
[21:47:39] [PASSED] rounding3
[21:47:39] [PASSED] rounding4
[21:47:39] =========== [PASSED] drm_test_check_plane_state ============
[21:47:39] =========== drm_test_check_invalid_plane_state  ============
[21:47:39] [PASSED] positioning_invalid
[21:47:39] [PASSED] upscaling_invalid
[21:47:39] [PASSED] downscaling_invalid
[21:47:39] ======= [PASSED] drm_test_check_invalid_plane_state ========
[21:47:39] ================ [PASSED] drm_plane_helper =================
[21:47:39] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[21:47:39] ====== drm_test_connector_helper_tv_get_modes_check  =======
[21:47:39] [PASSED] None
[21:47:39] [PASSED] PAL
[21:47:39] [PASSED] NTSC
[21:47:39] [PASSED] Both, NTSC Default
[21:47:39] [PASSED] Both, PAL Default
[21:47:39] [PASSED] Both, NTSC Default, with PAL on command-line
[21:47:39] [PASSED] Both, PAL Default, with NTSC on command-line
[21:47:39] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[21:47:39] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[21:47:39] ================== drm_rect (9 subtests) ===================
[21:47:39] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[21:47:39] [PASSED] drm_test_rect_clip_scaled_not_clipped
[21:47:39] [PASSED] drm_test_rect_clip_scaled_clipped
[21:47:39] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[21:47:39] ================= drm_test_rect_intersect  =================
[21:47:39] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[21:47:39] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[21:47:39] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[21:47:39] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[21:47:39] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[21:47:39] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[21:47:39] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[21:47:39] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[21:47:39] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[21:47:39] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[21:47:39] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[21:47:39] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[21:47:39] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[21:47:39] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[21:47:39] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[21:47:39] ============= [PASSED] drm_test_rect_intersect =============
[21:47:39] ================ drm_test_rect_calc_hscale  ================
[21:47:39] [PASSED] normal use
[21:47:39] [PASSED] out of max range
[21:47:39] [PASSED] out of min range
[21:47:39] [PASSED] zero dst
[21:47:39] [PASSED] negative src
[21:47:39] [PASSED] negative dst
[21:47:39] ============ [PASSED] drm_test_rect_calc_hscale ============
[21:47:39] ================ drm_test_rect_calc_vscale  ================
[21:47:39] [PASSED] normal use
stty: 'standard input': Inappropriate ioctl for device
[21:47:39] [PASSED] out of max range
[21:47:39] [PASSED] out of min range
[21:47:39] [PASSED] zero dst
[21:47:39] [PASSED] negative src
[21:47:39] [PASSED] negative dst
[21:47:39] ============ [PASSED] drm_test_rect_calc_vscale ============
[21:47:39] ================== drm_test_rect_rotate  ===================
[21:47:39] [PASSED] reflect-x
[21:47:39] [PASSED] reflect-y
[21:47:39] [PASSED] rotate-0
[21:47:39] [PASSED] rotate-90
[21:47:39] [PASSED] rotate-180
[21:47:39] [PASSED] rotate-270
[21:47:39] ============== [PASSED] drm_test_rect_rotate ===============
[21:47:39] ================ drm_test_rect_rotate_inv  =================
[21:47:39] [PASSED] reflect-x
[21:47:39] [PASSED] reflect-y
[21:47:39] [PASSED] rotate-0
[21:47:39] [PASSED] rotate-90
[21:47:39] [PASSED] rotate-180
[21:47:39] [PASSED] rotate-270
[21:47:39] ============ [PASSED] drm_test_rect_rotate_inv =============
[21:47:39] ==================== [PASSED] drm_rect =====================
[21:47:39] ============ drm_sysfb_modeset_test (1 subtest) ============
[21:47:39] ============ drm_test_sysfb_build_fourcc_list  =============
[21:47:39] [PASSED] no native formats
[21:47:39] [PASSED] XRGB8888 as native format
[21:47:39] [PASSED] remove duplicates
[21:47:39] [PASSED] convert alpha formats
[21:47:39] [PASSED] random formats
[21:47:39] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[21:47:39] ============= [PASSED] drm_sysfb_modeset_test ==============
[21:47:39] ============================================================
[21:47:39] Testing complete. Ran 622 tests: passed: 622
[21:47:39] Elapsed time: 27.121s total, 1.643s configuring, 25.011s building, 0.436s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[21:47:39] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[21:47:41] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[21:47:50] Starting KUnit Kernel (1/1)...
[21:47:50] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[21:47:50] ================= ttm_device (5 subtests) ==================
[21:47:50] [PASSED] ttm_device_init_basic
[21:47:50] [PASSED] ttm_device_init_multiple
[21:47:50] [PASSED] ttm_device_fini_basic
[21:47:50] [PASSED] ttm_device_init_no_vma_man
[21:47:50] ================== ttm_device_init_pools  ==================
[21:47:50] [PASSED] No DMA allocations, no DMA32 required
[21:47:50] [PASSED] DMA allocations, DMA32 required
[21:47:50] [PASSED] No DMA allocations, DMA32 required
[21:47:50] [PASSED] DMA allocations, no DMA32 required
[21:47:50] ============== [PASSED] ttm_device_init_pools ==============
[21:47:50] =================== [PASSED] ttm_device ====================
[21:47:50] ================== ttm_pool (8 subtests) ===================
[21:47:50] ================== ttm_pool_alloc_basic  ===================
[21:47:50] [PASSED] One page
[21:47:50] [PASSED] More than one page
[21:47:50] [PASSED] Above the allocation limit
[21:47:50] [PASSED] One page, with coherent DMA mappings enabled
[21:47:50] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[21:47:50] ============== [PASSED] ttm_pool_alloc_basic ===============
[21:47:50] ============== ttm_pool_alloc_basic_dma_addr  ==============
[21:47:50] [PASSED] One page
[21:47:50] [PASSED] More than one page
[21:47:50] [PASSED] Above the allocation limit
[21:47:50] [PASSED] One page, with coherent DMA mappings enabled
[21:47:50] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[21:47:50] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[21:47:50] [PASSED] ttm_pool_alloc_order_caching_match
[21:47:50] [PASSED] ttm_pool_alloc_caching_mismatch
[21:47:50] [PASSED] ttm_pool_alloc_order_mismatch
[21:47:50] [PASSED] ttm_pool_free_dma_alloc
[21:47:50] [PASSED] ttm_pool_free_no_dma_alloc
[21:47:50] [PASSED] ttm_pool_fini_basic
[21:47:50] ==================== [PASSED] ttm_pool =====================
[21:47:50] ================ ttm_resource (8 subtests) =================
[21:47:50] ================= ttm_resource_init_basic  =================
[21:47:50] [PASSED] Init resource in TTM_PL_SYSTEM
[21:47:50] [PASSED] Init resource in TTM_PL_VRAM
[21:47:50] [PASSED] Init resource in a private placement
[21:47:50] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[21:47:50] ============= [PASSED] ttm_resource_init_basic =============
[21:47:50] [PASSED] ttm_resource_init_pinned
[21:47:50] [PASSED] ttm_resource_fini_basic
[21:47:50] [PASSED] ttm_resource_manager_init_basic
[21:47:50] [PASSED] ttm_resource_manager_usage_basic
[21:47:50] [PASSED] ttm_resource_manager_set_used_basic
[21:47:50] [PASSED] ttm_sys_man_alloc_basic
[21:47:50] [PASSED] ttm_sys_man_free_basic
[21:47:50] ================== [PASSED] ttm_resource ===================
[21:47:50] =================== ttm_tt (15 subtests) ===================
[21:47:50] ==================== ttm_tt_init_basic  ====================
[21:47:50] [PASSED] Page-aligned size
[21:47:50] [PASSED] Extra pages requested
[21:47:50] ================ [PASSED] ttm_tt_init_basic ================
[21:47:50] [PASSED] ttm_tt_init_misaligned
[21:47:50] [PASSED] ttm_tt_fini_basic
[21:47:50] [PASSED] ttm_tt_fini_sg
[21:47:50] [PASSED] ttm_tt_fini_shmem
[21:47:50] [PASSED] ttm_tt_create_basic
[21:47:50] [PASSED] ttm_tt_create_invalid_bo_type
[21:47:50] [PASSED] ttm_tt_create_ttm_exists
[21:47:50] [PASSED] ttm_tt_create_failed
[21:47:50] [PASSED] ttm_tt_destroy_basic
[21:47:50] [PASSED] ttm_tt_populate_null_ttm
[21:47:50] [PASSED] ttm_tt_populate_populated_ttm
[21:47:50] [PASSED] ttm_tt_unpopulate_basic
[21:47:50] [PASSED] ttm_tt_unpopulate_empty_ttm
[21:47:50] [PASSED] ttm_tt_swapin_basic
[21:47:50] ===================== [PASSED] ttm_tt ======================
[21:47:50] =================== ttm_bo (14 subtests) ===================
[21:47:50] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[21:47:50] [PASSED] Cannot be interrupted and sleeps
[21:47:50] [PASSED] Cannot be interrupted, locks straight away
[21:47:50] [PASSED] Can be interrupted, sleeps
[21:47:50] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[21:47:50] [PASSED] ttm_bo_reserve_locked_no_sleep
[21:47:50] [PASSED] ttm_bo_reserve_no_wait_ticket
[21:47:50] [PASSED] ttm_bo_reserve_double_resv
[21:47:50] [PASSED] ttm_bo_reserve_interrupted
[21:47:50] [PASSED] ttm_bo_reserve_deadlock
[21:47:50] [PASSED] ttm_bo_unreserve_basic
[21:47:50] [PASSED] ttm_bo_unreserve_pinned
[21:47:50] [PASSED] ttm_bo_unreserve_bulk
[21:47:50] [PASSED] ttm_bo_fini_basic
[21:47:50] [PASSED] ttm_bo_fini_shared_resv
[21:47:50] [PASSED] ttm_bo_pin_basic
[21:47:50] [PASSED] ttm_bo_pin_unpin_resource
[21:47:50] [PASSED] ttm_bo_multiple_pin_one_unpin
[21:47:50] ===================== [PASSED] ttm_bo ======================
[21:47:50] ============== ttm_bo_validate (21 subtests) ===============
[21:47:50] ============== ttm_bo_init_reserved_sys_man  ===============
[21:47:50] [PASSED] Buffer object for userspace
[21:47:50] [PASSED] Kernel buffer object
[21:47:50] [PASSED] Shared buffer object
[21:47:50] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[21:47:50] ============== ttm_bo_init_reserved_mock_man  ==============
[21:47:50] [PASSED] Buffer object for userspace
[21:47:50] [PASSED] Kernel buffer object
[21:47:50] [PASSED] Shared buffer object
[21:47:50] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[21:47:50] [PASSED] ttm_bo_init_reserved_resv
[21:47:50] ================== ttm_bo_validate_basic  ==================
[21:47:50] [PASSED] Buffer object for userspace
[21:47:50] [PASSED] Kernel buffer object
[21:47:50] [PASSED] Shared buffer object
[21:47:50] ============== [PASSED] ttm_bo_validate_basic ==============
[21:47:50] [PASSED] ttm_bo_validate_invalid_placement
[21:47:50] ============= ttm_bo_validate_same_placement  ==============
[21:47:50] [PASSED] System manager
[21:47:50] [PASSED] VRAM manager
[21:47:50] ========= [PASSED] ttm_bo_validate_same_placement ==========
[21:47:50] [PASSED] ttm_bo_validate_failed_alloc
[21:47:50] [PASSED] ttm_bo_validate_pinned
[21:47:50] [PASSED] ttm_bo_validate_busy_placement
[21:47:50] ================ ttm_bo_validate_multihop  =================
[21:47:50] [PASSED] Buffer object for userspace
[21:47:50] [PASSED] Kernel buffer object
[21:47:50] [PASSED] Shared buffer object
[21:47:50] ============ [PASSED] ttm_bo_validate_multihop =============
[21:47:50] ========== ttm_bo_validate_no_placement_signaled  ==========
[21:47:50] [PASSED] Buffer object in system domain, no page vector
[21:47:50] [PASSED] Buffer object in system domain with an existing page vector
[21:47:50] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[21:47:50] ======== ttm_bo_validate_no_placement_not_signaled  ========
[21:47:50] [PASSED] Buffer object for userspace
[21:47:50] [PASSED] Kernel buffer object
[21:47:50] [PASSED] Shared buffer object
[21:47:50] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[21:47:50] [PASSED] ttm_bo_validate_move_fence_signaled
[21:47:50] ========= ttm_bo_validate_move_fence_not_signaled  =========
[21:47:50] [PASSED] Waits for GPU
[21:47:50] [PASSED] Tries to lock straight away
[21:47:50] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[21:47:50] [PASSED] ttm_bo_validate_happy_evict
[21:47:50] [PASSED] ttm_bo_validate_all_pinned_evict
[21:47:50] [PASSED] ttm_bo_validate_allowed_only_evict
[21:47:50] [PASSED] ttm_bo_validate_deleted_evict
[21:47:50] [PASSED] ttm_bo_validate_busy_domain_evict
[21:47:50] [PASSED] ttm_bo_validate_evict_gutting
[21:47:50] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[21:47:50] ================= [PASSED] ttm_bo_validate =================
[21:47:50] ============================================================
[21:47:50] Testing complete. Ran 101 tests: passed: 101
[21:47:50] Elapsed time: 11.222s total, 1.665s configuring, 9.291s building, 0.216s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel



^ permalink raw reply	[flat|nested] 23+ messages in thread

* ✗ CI.checksparse: warning for drm/i915: i915_utils.h refactoring
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (7 preceding siblings ...)
  2025-10-22 21:47 ` ✓ CI.KUnit: success " Patchwork
@ 2025-10-22 22:03 ` Patchwork
  2025-10-22 22:28 ` ✓ Xe.CI.BAT: success " Patchwork
  2025-10-23  3:07 ` ✗ Xe.CI.Full: failure " Patchwork
  10 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2025-10-22 22:03 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-xe

== Series Details ==

Series: drm/i915: i915_utils.h refactoring
URL   : https://patchwork.freedesktop.org/series/156358/
State : warning

== Summary ==

+ trap cleanup EXIT
+ KERNEL=/kernel
+ MT=/root/linux/maintainer-tools
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools /root/linux/maintainer-tools
Cloning into '/root/linux/maintainer-tools'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ make -C /root/linux/maintainer-tools
make: Entering directory '/root/linux/maintainer-tools'
cc -O2 -g -Wextra -o remap-log remap-log.c
make: Leaving directory '/root/linux/maintainer-tools'
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ /root/linux/maintainer-tools/dim sparse --fast 71929a54e8bb5da291d41a931d80c6c9160073dd
Sparse version: 0.6.4 (Ubuntu: 0.6.4-4ubuntu3)
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_cdclk.c: note: in included file:
+drivers/gpu/drm/i915/display/intel_ddi.c: note: in included file:
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2058:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2071:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2071:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_display_types.h:2071:24: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/display/intel_hdcp.c: note: in included file:
+drivers/gpu/drm/i915/display/intel_hotplug.c: note: in included file:
+drivers/gpu/drm/i915/display/intel_pps.c: note: in included file:
+drivers/gpu/drm/i915/display/intel_psr.c: note: in included file:
+drivers/gpu/drm/i915/gt/intel_reset.c:1569:12: warning: context imbalance in '_intel_gt_reset_lock' - different lock contexts for basic block
+drivers/gpu/drm/i915/gt/intel_sseu.c:598:17: error: too long token expansion
+drivers/gpu/drm/i915/i915_active.c:1062:16: warning: context imbalance in '__i915_active_fence_set' - different lock contexts for basic block
+drivers/gpu/drm/i915/i915_drm_client.c:92:9: error: incompatible types in comparison expression (different address spaces):
+drivers/gpu/drm/i915/i915_drm_client.c:92:9: error: incompatible types in comparison expression (different address spaces):
+drivers/gpu/drm/i915/i915_drm_client.c:92:9:    expected struct list_head const *list
+drivers/gpu/drm/i915/i915_drm_client.c:92:9:    got struct list_head [noderef] __rcu *pos
+drivers/gpu/drm/i915/i915_drm_client.c:92:9:    struct list_head *
+drivers/gpu/drm/i915/i915_drm_client.c:92:9:    struct list_head *
+drivers/gpu/drm/i915/i915_drm_client.c:92:9:    struct list_head [noderef] __rcu *
+drivers/gpu/drm/i915/i915_drm_client.c:92:9:    struct list_head [noderef] __rcu *
+drivers/gpu/drm/i915/i915_drm_client.c:92:9: warning: incorrect type in argument 1 (different address spaces)
+drivers/gpu/drm/i915/i915_gpu_error.c:692:3: warning: symbol 'guc_hw_reg_state' was not declared. Should it be static?
+drivers/gpu/drm/i915/i915_irq.c:465:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:465:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:473:16: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:473:16: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:478:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:478:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:478:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:516:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:516:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:524:16: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:524:16: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:529:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:529:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:529:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:573:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:573:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:576:15: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:576:15: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:580:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:580:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/i915_irq.c:587:9: warning: unreplaced symbol '<noident>'
+drivers/gpu/drm/i915/intel_uncore.c:1929:1: warning: context imbalance in 'fwtable_read8' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:1930:1: warning: context imbalance in 'fwtable_read16' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:1931:1: warning: context imbalance in 'fwtable_read32' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:1932:1: warning: context imbalance in 'fwtable_read64' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:1997:1: warning: context imbalance in 'gen6_write8' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:1998:1: warning: context imbalance in 'gen6_write16' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:1999:1: warning: context imbalance in 'gen6_write32' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:2019:1: warning: context imbalance in 'fwtable_write8' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:2020:1: warning: context imbalance in 'fwtable_write16' - unexpected unlock
+drivers/gpu/drm/i915/intel_uncore.c:2021:1: warning: context imbalance in 'fwtable_write32' - unexpected unlock
+drivers/gpu/drm/i915/intel_wakeref.c:146:19: warning: context imbalance in 'wakeref_auto_timeout' - unexpected unlock

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel



^ permalink raw reply	[flat|nested] 23+ messages in thread

* ✓ Xe.CI.BAT: success for drm/i915: i915_utils.h refactoring
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (8 preceding siblings ...)
  2025-10-22 22:03 ` ✗ CI.checksparse: warning " Patchwork
@ 2025-10-22 22:28 ` Patchwork
  2025-10-23  3:07 ` ✗ Xe.CI.Full: failure " Patchwork
  10 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2025-10-22 22:28 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-xe

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

== Series Details ==

Series: drm/i915: i915_utils.h refactoring
URL   : https://patchwork.freedesktop.org/series/156358/
State : success

== Summary ==

CI Bug Log - changes from xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd_BAT -> xe-pw-156358v1_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (13 -> 13)
------------------------------

  No changes in participating hosts


Changes
-------

  No changes found


Build changes
-------------

  * IGT: IGT_8594 -> IGT_8595
  * Linux: xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd -> xe-pw-156358v1

  IGT_8594: 8594
  IGT_8595: 8595
  xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd: 71929a54e8bb5da291d41a931d80c6c9160073dd
  xe-pw-156358v1: 156358v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/index.html

[-- Attachment #2: Type: text/html, Size: 1466 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* ✗ Xe.CI.Full: failure for drm/i915: i915_utils.h refactoring
  2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
                   ` (9 preceding siblings ...)
  2025-10-22 22:28 ` ✓ Xe.CI.BAT: success " Patchwork
@ 2025-10-23  3:07 ` Patchwork
  10 siblings, 0 replies; 23+ messages in thread
From: Patchwork @ 2025-10-23  3:07 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-xe

[-- Attachment #1: Type: text/plain, Size: 61551 bytes --]

== Series Details ==

Series: drm/i915: i915_utils.h refactoring
URL   : https://patchwork.freedesktop.org/series/156358/
State : failure

== Summary ==

CI Bug Log - changes from xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd_FULL -> xe-pw-156358v1_FULL
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with xe-pw-156358v1_FULL absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in xe-pw-156358v1_FULL, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in xe-pw-156358v1_FULL:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_plane_cursor@viewport:
    - shard-adlp:         [PASS][1] -> [FAIL][2] +3 other tests fail
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-3/igt@kms_plane_cursor@viewport.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-8/igt@kms_plane_cursor@viewport.html

  
Known issues
------------

  Here are the changes found in xe-pw-156358v1_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_async_flips@async-flip-with-page-flip-events-linear-atomic@pipe-c-edp-1:
    - shard-lnl:          [PASS][3] -> [FAIL][4] ([Intel XE#6054]) +3 other tests fail
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-5/igt@kms_async_flips@async-flip-with-page-flip-events-linear-atomic@pipe-c-edp-1.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-4/igt@kms_async_flips@async-flip-with-page-flip-events-linear-atomic@pipe-c-edp-1.html

  * igt@kms_big_fb@4-tiled-64bpp-rotate-270:
    - shard-dg2-set2:     NOTRUN -> [SKIP][5] ([Intel XE#316])
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-466/igt@kms_big_fb@4-tiled-64bpp-rotate-270.html

  * igt@kms_big_fb@linear-8bpp-rotate-270:
    - shard-bmg:          NOTRUN -> [SKIP][6] ([Intel XE#2327])
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_big_fb@linear-8bpp-rotate-270.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-90:
    - shard-bmg:          NOTRUN -> [SKIP][7] ([Intel XE#1124]) +1 other test skip
   [7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-8/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-addfb-size-offset-overflow:
    - shard-bmg:          NOTRUN -> [SKIP][8] ([Intel XE#607])
   [8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-2/igt@kms_big_fb@y-tiled-addfb-size-offset-overflow.html
    - shard-lnl:          NOTRUN -> [SKIP][9] ([Intel XE#1477])
   [9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-2/igt@kms_big_fb@y-tiled-addfb-size-offset-overflow.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
    - shard-adlp:         NOTRUN -> [DMESG-FAIL][10] ([Intel XE#4543]) +1 other test dmesg-fail
   [10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html

  * igt@kms_big_fb@yf-tiled-addfb:
    - shard-dg2-set2:     NOTRUN -> [SKIP][11] ([Intel XE#619])
   [11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-432/igt@kms_big_fb@yf-tiled-addfb.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
    - shard-lnl:          NOTRUN -> [SKIP][12] ([Intel XE#1124]) +1 other test skip
   [12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-4/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
    - shard-adlp:         NOTRUN -> [SKIP][13] ([Intel XE#1124])
   [13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-8/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
    - shard-dg2-set2:     NOTRUN -> [SKIP][14] ([Intel XE#1124]) +4 other tests skip
   [14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-466/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html

  * igt@kms_ccs@bad-aux-stride-4-tiled-mtl-rc-ccs-cc:
    - shard-bmg:          NOTRUN -> [SKIP][15] ([Intel XE#2887]) +5 other tests skip
   [15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_ccs@bad-aux-stride-4-tiled-mtl-rc-ccs-cc.html

  * igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs-cc:
    - shard-lnl:          NOTRUN -> [SKIP][16] ([Intel XE#2887]) +2 other tests skip
   [16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs-cc.html

  * igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs-cc@pipe-a-hdmi-a-1:
    - shard-adlp:         NOTRUN -> [SKIP][17] ([Intel XE#787]) +20 other tests skip
   [17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@kms_ccs@bad-pixel-format-4-tiled-dg2-rc-ccs-cc@pipe-a-hdmi-a-1.html

  * igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs-cc@pipe-d-hdmi-a-6:
    - shard-dg2-set2:     NOTRUN -> [SKIP][18] ([Intel XE#787]) +34 other tests skip
   [18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-434/igt@kms_ccs@crc-primary-basic-4-tiled-mtl-rc-ccs-cc@pipe-d-hdmi-a-6.html

  * igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs-cc@pipe-d-dp-4:
    - shard-dg2-set2:     [PASS][19] -> [INCOMPLETE][20] ([Intel XE#3862]) +3 other tests incomplete
   [19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-464/igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs-cc@pipe-d-dp-4.html
   [20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-435/igt@kms_ccs@crc-primary-suspend-4-tiled-dg2-rc-ccs-cc@pipe-d-dp-4.html

  * igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-mc-ccs@pipe-d-dp-4:
    - shard-dg2-set2:     NOTRUN -> [SKIP][21] ([Intel XE#455] / [Intel XE#787]) +9 other tests skip
   [21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-434/igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-mc-ccs@pipe-d-dp-4.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-b-dp-4:
    - shard-dg2-set2:     NOTRUN -> [INCOMPLETE][22] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522])
   [22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-b-dp-4.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc:
    - shard-adlp:         NOTRUN -> [SKIP][23] ([Intel XE#455] / [Intel XE#787]) +13 other tests skip
   [23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-4/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc.html

  * igt@kms_cdclk@plane-scaling:
    - shard-bmg:          NOTRUN -> [SKIP][24] ([Intel XE#2724])
   [24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_cdclk@plane-scaling.html

  * igt@kms_chamelium_color@ctm-green-to-red:
    - shard-adlp:         NOTRUN -> [SKIP][25] ([Intel XE#306])
   [25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@kms_chamelium_color@ctm-green-to-red.html

  * igt@kms_chamelium_frames@vga-frame-dump:
    - shard-lnl:          NOTRUN -> [SKIP][26] ([Intel XE#373])
   [26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@kms_chamelium_frames@vga-frame-dump.html

  * igt@kms_chamelium_hpd@common-hpd-after-hibernate:
    - shard-bmg:          NOTRUN -> [SKIP][27] ([Intel XE#2252])
   [27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-1/igt@kms_chamelium_hpd@common-hpd-after-hibernate.html

  * igt@kms_chamelium_hpd@dp-hpd-after-suspend:
    - shard-adlp:         NOTRUN -> [SKIP][28] ([Intel XE#373])
   [28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-3/igt@kms_chamelium_hpd@dp-hpd-after-suspend.html

  * igt@kms_chamelium_hpd@hdmi-hpd:
    - shard-dg2-set2:     NOTRUN -> [SKIP][29] ([Intel XE#373]) +3 other tests skip
   [29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-433/igt@kms_chamelium_hpd@hdmi-hpd.html

  * igt@kms_content_protection@content-type-change:
    - shard-lnl:          NOTRUN -> [SKIP][30] ([Intel XE#3278]) +1 other test skip
   [30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-5/igt@kms_content_protection@content-type-change.html

  * igt@kms_content_protection@srm@pipe-a-dp-2:
    - shard-bmg:          NOTRUN -> [FAIL][31] ([Intel XE#1178])
   [31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@kms_content_protection@srm@pipe-a-dp-2.html

  * igt@kms_content_protection@type1:
    - shard-bmg:          NOTRUN -> [SKIP][32] ([Intel XE#2341]) +1 other test skip
   [32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-1/igt@kms_content_protection@type1.html

  * igt@kms_cursor_crc@cursor-onscreen-32x32:
    - shard-bmg:          NOTRUN -> [SKIP][33] ([Intel XE#2320])
   [33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-8/igt@kms_cursor_crc@cursor-onscreen-32x32.html

  * igt@kms_cursor_crc@cursor-rapid-movement-128x42:
    - shard-lnl:          NOTRUN -> [SKIP][34] ([Intel XE#1424])
   [34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-2/igt@kms_cursor_crc@cursor-rapid-movement-128x42.html

  * igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
    - shard-bmg:          [PASS][35] -> [SKIP][36] ([Intel XE#2291]) +3 other tests skip
   [35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-5/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
   [36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html

  * igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
    - shard-lnl:          NOTRUN -> [SKIP][37] ([Intel XE#1421]) +2 other tests skip
   [37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-3/igt@kms_flip@2x-dpms-vs-vblank-race-interruptible.html

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-adlp:         NOTRUN -> [SKIP][38] ([Intel XE#310])
   [38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
    - shard-bmg:          [PASS][39] -> [SKIP][40] ([Intel XE#2316]) +4 other tests skip
   [39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
   [40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@d-hdmi-a1:
    - shard-adlp:         [PASS][41] -> [DMESG-WARN][42] ([Intel XE#4543]) +11 other tests dmesg-warn
   [41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-9/igt@kms_flip@flip-vs-expired-vblank-interruptible@d-hdmi-a1.html
   [42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-2/igt@kms_flip@flip-vs-expired-vblank-interruptible@d-hdmi-a1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling:
    - shard-lnl:          NOTRUN -> [SKIP][43] ([Intel XE#1397] / [Intel XE#1745])
   [43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling.html

  * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode:
    - shard-lnl:          NOTRUN -> [SKIP][44] ([Intel XE#1397])
   [44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling:
    - shard-bmg:          NOTRUN -> [SKIP][45] ([Intel XE#2293] / [Intel XE#2380])
   [45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
    - shard-bmg:          NOTRUN -> [SKIP][46] ([Intel XE#2293])
   [46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
    - shard-lnl:          NOTRUN -> [SKIP][47] ([Intel XE#1401] / [Intel XE#1745])
   [47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
    - shard-lnl:          NOTRUN -> [SKIP][48] ([Intel XE#1401])
   [48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode:
    - shard-adlp:         NOTRUN -> [SKIP][49] ([Intel XE#455]) +9 other tests skip
   [49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode.html

  * igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-x:
    - shard-adlp:         [PASS][50] -> [DMESG-FAIL][51] ([Intel XE#4543])
   [50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-8/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-x.html
   [51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-6/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-x.html

  * igt@kms_frontbuffer_tracking@drrs-1p-offscreen-pri-indfb-draw-blt:
    - shard-dg2-set2:     NOTRUN -> [SKIP][52] ([Intel XE#6312]) +2 other tests skip
   [52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-463/igt@kms_frontbuffer_tracking@drrs-1p-offscreen-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@drrs-1p-offscreen-pri-indfb-draw-render:
    - shard-lnl:          NOTRUN -> [SKIP][53] ([Intel XE#6312])
   [53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-5/igt@kms_frontbuffer_tracking@drrs-1p-offscreen-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@drrs-modesetfrombusy:
    - shard-adlp:         NOTRUN -> [SKIP][54] ([Intel XE#651]) +3 other tests skip
   [54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-2/igt@kms_frontbuffer_tracking@drrs-modesetfrombusy.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
    - shard-adlp:         [PASS][55] -> [DMESG-WARN][56] ([Intel XE#2953] / [Intel XE#4173]) +1 other test dmesg-warn
   [55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
   [56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
    - shard-bmg:          NOTRUN -> [SKIP][57] ([Intel XE#5390]) +4 other tests skip
   [57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen:
    - shard-adlp:         NOTRUN -> [SKIP][58] ([Intel XE#656]) +14 other tests skip
   [58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-fullscreen.html

  * igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-spr-indfb-onoff:
    - shard-dg2-set2:     NOTRUN -> [SKIP][59] ([Intel XE#651]) +10 other tests skip
   [59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-435/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-spr-indfb-onoff.html
    - shard-lnl:          NOTRUN -> [SKIP][60] ([Intel XE#651]) +1 other test skip
   [60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@kms_frontbuffer_tracking@fbcdrrs-1p-primscrn-spr-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-indfb-pgflip-blt:
    - shard-bmg:          NOTRUN -> [SKIP][61] ([Intel XE#2311]) +7 other tests skip
   [61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-2/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-indfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-indfb-draw-render:
    - shard-adlp:         NOTRUN -> [SKIP][62] ([Intel XE#6312]) +1 other test skip
   [62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-3/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-indfb-draw-render.html
    - shard-bmg:          NOTRUN -> [SKIP][63] ([Intel XE#2313]) +6 other tests skip
   [63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscreen-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render:
    - shard-adlp:         NOTRUN -> [SKIP][64] ([Intel XE#653]) +3 other tests skip
   [64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-blt:
    - shard-bmg:          NOTRUN -> [SKIP][65] ([Intel XE#2312]) +1 other test skip
   [65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-wc:
    - shard-lnl:          NOTRUN -> [SKIP][66] ([Intel XE#656]) +8 other tests skip
   [66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-shrfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@psr-slowdraw:
    - shard-dg2-set2:     NOTRUN -> [SKIP][67] ([Intel XE#653]) +14 other tests skip
   [67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-433/igt@kms_frontbuffer_tracking@psr-slowdraw.html

  * igt@kms_joiner@switch-modeset-ultra-joiner-big-joiner:
    - shard-dg2-set2:     NOTRUN -> [SKIP][68] ([Intel XE#2925])
   [68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-433/igt@kms_joiner@switch-modeset-ultra-joiner-big-joiner.html

  * igt@kms_plane_multiple@2x-tiling-x:
    - shard-bmg:          [PASS][69] -> [SKIP][70] ([Intel XE#4596])
   [69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-7/igt@kms_plane_multiple@2x-tiling-x.html
   [70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_plane_multiple@2x-tiling-x.html

  * igt@kms_pm_backlight@basic-brightness:
    - shard-adlp:         NOTRUN -> [SKIP][71] ([Intel XE#870])
   [71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-4/igt@kms_pm_backlight@basic-brightness.html

  * igt@kms_pm_dc@dc6-psr:
    - shard-lnl:          [PASS][72] -> [FAIL][73] ([Intel XE#718])
   [72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-5/igt@kms_pm_dc@dc6-psr.html
   [73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@kms_pm_dc@dc6-psr.html

  * igt@kms_pm_lpsp@kms-lpsp:
    - shard-bmg:          NOTRUN -> [SKIP][74] ([Intel XE#2499])
   [74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-4/igt@kms_pm_lpsp@kms-lpsp.html

  * igt@kms_psr2_sf@fbc-pr-cursor-plane-move-continuous-sf:
    - shard-bmg:          NOTRUN -> [SKIP][75] ([Intel XE#1406] / [Intel XE#1489]) +3 other tests skip
   [75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@kms_psr2_sf@fbc-pr-cursor-plane-move-continuous-sf.html

  * igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf:
    - shard-adlp:         NOTRUN -> [SKIP][76] ([Intel XE#1406] / [Intel XE#1489]) +3 other tests skip
   [76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf.html
    - shard-dg2-set2:     NOTRUN -> [SKIP][77] ([Intel XE#1406] / [Intel XE#1489]) +3 other tests skip
   [77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-434/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf.html
    - shard-lnl:          NOTRUN -> [SKIP][78] ([Intel XE#1406] / [Intel XE#2893] / [Intel XE#4608])
   [78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf.html

  * igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf@pipe-a-edp-1:
    - shard-lnl:          NOTRUN -> [SKIP][79] ([Intel XE#1406] / [Intel XE#4608]) +2 other tests skip
   [79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-sf@pipe-a-edp-1.html

  * igt@kms_psr2_sf@pr-cursor-plane-move-continuous-exceed-sf:
    - shard-lnl:          NOTRUN -> [SKIP][80] ([Intel XE#1406] / [Intel XE#2893])
   [80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@kms_psr2_sf@pr-cursor-plane-move-continuous-exceed-sf.html

  * igt@kms_psr@fbc-pr-cursor-plane-onoff:
    - shard-bmg:          NOTRUN -> [SKIP][81] ([Intel XE#1406] / [Intel XE#2234] / [Intel XE#2850]) +3 other tests skip
   [81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-3/igt@kms_psr@fbc-pr-cursor-plane-onoff.html

  * igt@kms_psr@fbc-pr-sprite-render:
    - shard-lnl:          NOTRUN -> [SKIP][82] ([Intel XE#1406])
   [82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@kms_psr@fbc-pr-sprite-render.html

  * igt@kms_psr@pr-dpms:
    - shard-dg2-set2:     NOTRUN -> [SKIP][83] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929]) +5 other tests skip
   [83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-435/igt@kms_psr@pr-dpms.html

  * igt@kms_psr@pr-primary-page-flip:
    - shard-adlp:         NOTRUN -> [SKIP][84] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929]) +2 other tests skip
   [84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-8/igt@kms_psr@pr-primary-page-flip.html

  * igt@kms_psr@psr2-primary-render:
    - shard-bmg:          NOTRUN -> [SKIP][85] ([Intel XE#1406] / [Intel XE#2234])
   [85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-5/igt@kms_psr@psr2-primary-render.html

  * igt@kms_rotation_crc@primary-rotation-270:
    - shard-dg2-set2:     NOTRUN -> [SKIP][86] ([Intel XE#3414]) +1 other test skip
   [86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-436/igt@kms_rotation_crc@primary-rotation-270.html

  * igt@kms_rotation_crc@primary-y-tiled-reflect-x-0:
    - shard-dg2-set2:     NOTRUN -> [SKIP][87] ([Intel XE#1127])
   [87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-432/igt@kms_rotation_crc@primary-y-tiled-reflect-x-0.html

  * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90:
    - shard-adlp:         NOTRUN -> [SKIP][88] ([Intel XE#3414])
   [88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90.html
    - shard-bmg:          NOTRUN -> [SKIP][89] ([Intel XE#3414] / [Intel XE#3904])
   [89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90.html
    - shard-lnl:          NOTRUN -> [SKIP][90] ([Intel XE#3414] / [Intel XE#3904])
   [90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-90.html

  * igt@kms_setmode@basic:
    - shard-lnl:          [PASS][91] -> [FAIL][92] ([i915#15106]) +1 other test fail
   [91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-3/igt@kms_setmode@basic.html
   [92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@kms_setmode@basic.html

  * igt@kms_vrr@flip-dpms:
    - shard-dg2-set2:     NOTRUN -> [SKIP][93] ([Intel XE#455]) +8 other tests skip
   [93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-435/igt@kms_vrr@flip-dpms.html

  * igt@kms_vrr@negative-basic:
    - shard-bmg:          NOTRUN -> [SKIP][94] ([Intel XE#1499]) +1 other test skip
   [94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_vrr@negative-basic.html

  * igt@xe_compute_preempt@compute-preempt-many:
    - shard-dg2-set2:     NOTRUN -> [SKIP][95] ([Intel XE#6360]) +1 other test skip
   [95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-434/igt@xe_compute_preempt@compute-preempt-many.html

  * igt@xe_compute_preempt@compute-preempt-many-all-ram:
    - shard-adlp:         NOTRUN -> [SKIP][96] ([Intel XE#6360])
   [96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-6/igt@xe_compute_preempt@compute-preempt-many-all-ram.html

  * igt@xe_copy_basic@mem-page-copy-17:
    - shard-dg2-set2:     NOTRUN -> [SKIP][97] ([Intel XE#5300])
   [97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-464/igt@xe_copy_basic@mem-page-copy-17.html

  * igt@xe_eudebug@basic-vm-access-userptr-faultable:
    - shard-dg2-set2:     NOTRUN -> [SKIP][98] ([Intel XE#4837]) +6 other tests skip
   [98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-463/igt@xe_eudebug@basic-vm-access-userptr-faultable.html

  * igt@xe_eudebug@basic-vm-bind:
    - shard-lnl:          NOTRUN -> [SKIP][99] ([Intel XE#4837]) +2 other tests skip
   [99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@xe_eudebug@basic-vm-bind.html

  * igt@xe_eudebug@basic-vm-bind-metadata-discovery:
    - shard-bmg:          NOTRUN -> [SKIP][100] ([Intel XE#4837]) +3 other tests skip
   [100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@xe_eudebug@basic-vm-bind-metadata-discovery.html

  * igt@xe_eudebug_online@writes-caching-sram-bb-vram-target-vram:
    - shard-adlp:         NOTRUN -> [SKIP][101] ([Intel XE#4837] / [Intel XE#5565]) +4 other tests skip
   [101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-3/igt@xe_eudebug_online@writes-caching-sram-bb-vram-target-vram.html

  * igt@xe_eudebug_sriov@deny-sriov:
    - shard-dg2-set2:     NOTRUN -> [SKIP][102] ([Intel XE#4518])
   [102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-432/igt@xe_eudebug_sriov@deny-sriov.html

  * igt@xe_evict@evict-large-multi-vm-cm:
    - shard-adlp:         NOTRUN -> [SKIP][103] ([Intel XE#261]) +1 other test skip
   [103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-4/igt@xe_evict@evict-large-multi-vm-cm.html

  * igt@xe_evict@evict-mixed-many-threads-small:
    - shard-bmg:          [PASS][104] -> [INCOMPLETE][105] ([Intel XE#6321])
   [104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-7/igt@xe_evict@evict-mixed-many-threads-small.html
   [105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-4/igt@xe_evict@evict-mixed-many-threads-small.html

  * igt@xe_evict@evict-threads-small-multi-vm:
    - shard-lnl:          NOTRUN -> [SKIP][106] ([Intel XE#688]) +2 other tests skip
   [106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-5/igt@xe_evict@evict-threads-small-multi-vm.html

  * igt@xe_evict_ccs@evict-overcommit-standalone-nofree-reopen:
    - shard-adlp:         NOTRUN -> [SKIP][107] ([Intel XE#688])
   [107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-9/igt@xe_evict_ccs@evict-overcommit-standalone-nofree-reopen.html

  * igt@xe_exec_basic@multigpu-no-exec-basic:
    - shard-adlp:         NOTRUN -> [SKIP][108] ([Intel XE#1392] / [Intel XE#5575]) +1 other test skip
   [108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-3/igt@xe_exec_basic@multigpu-no-exec-basic.html

  * igt@xe_exec_basic@multigpu-no-exec-userptr-invalidate:
    - shard-lnl:          NOTRUN -> [SKIP][109] ([Intel XE#1392]) +1 other test skip
   [109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-3/igt@xe_exec_basic@multigpu-no-exec-userptr-invalidate.html
    - shard-bmg:          NOTRUN -> [SKIP][110] ([Intel XE#2322]) +1 other test skip
   [110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-1/igt@xe_exec_basic@multigpu-no-exec-userptr-invalidate.html

  * igt@xe_exec_fault_mode@once-userptr-invalidate-prefetch:
    - shard-adlp:         NOTRUN -> [SKIP][111] ([Intel XE#288] / [Intel XE#5561]) +7 other tests skip
   [111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@xe_exec_fault_mode@once-userptr-invalidate-prefetch.html

  * igt@xe_exec_fault_mode@twice-userptr-prefetch:
    - shard-dg2-set2:     NOTRUN -> [SKIP][112] ([Intel XE#288]) +12 other tests skip
   [112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-436/igt@xe_exec_fault_mode@twice-userptr-prefetch.html

  * igt@xe_exec_mix_modes@exec-simple-batch-store-lr:
    - shard-dg2-set2:     NOTRUN -> [SKIP][113] ([Intel XE#2360])
   [113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-464/igt@xe_exec_mix_modes@exec-simple-batch-store-lr.html

  * igt@xe_exec_system_allocator@fault-threads-same-page-benchmark:
    - shard-dg2-set2:     NOTRUN -> [SKIP][114] ([Intel XE#4915]) +109 other tests skip
   [114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-436/igt@xe_exec_system_allocator@fault-threads-same-page-benchmark.html

  * igt@xe_exec_system_allocator@once-mmap-remap-ro-dontunmap:
    - shard-adlp:         NOTRUN -> [SKIP][115] ([Intel XE#4915]) +78 other tests skip
   [115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-4/igt@xe_exec_system_allocator@once-mmap-remap-ro-dontunmap.html

  * igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-comp-single-vma:
    - shard-lnl:          NOTRUN -> [SKIP][116] ([Intel XE#6196])
   [116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-comp-single-vma.html

  * igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma:
    - shard-lnl:          [PASS][117] -> [FAIL][118] ([Intel XE#5625])
   [117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-7/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html
   [118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-8/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html

  * igt@xe_exec_system_allocator@threads-many-large-execqueues-mmap-huge:
    - shard-lnl:          NOTRUN -> [SKIP][119] ([Intel XE#4943]) +1 other test skip
   [119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-2/igt@xe_exec_system_allocator@threads-many-large-execqueues-mmap-huge.html

  * igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-mmap-huge:
    - shard-bmg:          NOTRUN -> [SKIP][120] ([Intel XE#4943]) +6 other tests skip
   [120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-2/igt@xe_exec_system_allocator@threads-shared-vm-many-large-execqueues-mmap-huge.html

  * igt@xe_media_fill@media-fill:
    - shard-bmg:          NOTRUN -> [SKIP][121] ([Intel XE#2459] / [Intel XE#2596])
   [121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-1/igt@xe_media_fill@media-fill.html

  * igt@xe_oa@oa-regs-whitelisted:
    - shard-dg2-set2:     NOTRUN -> [SKIP][122] ([Intel XE#3573]) +1 other test skip
   [122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-433/igt@xe_oa@oa-regs-whitelisted.html

  * igt@xe_peer2peer@read@read-gpua-system-gpub-system-p2p:
    - shard-adlp:         NOTRUN -> [DMESG-FAIL][123] ([Intel XE#5213])
   [123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-9/igt@xe_peer2peer@read@read-gpua-system-gpub-system-p2p.html

  * igt@xe_peer2peer@write:
    - shard-adlp:         NOTRUN -> [SKIP][124] ([Intel XE#1061] / [Intel XE#5568])
   [124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@xe_peer2peer@write.html

  * igt@xe_pm@s2idle-exec-after:
    - shard-adlp:         [PASS][125] -> [DMESG-WARN][126] ([Intel XE#2953] / [Intel XE#4173] / [Intel XE#4504])
   [125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-9/igt@xe_pm@s2idle-exec-after.html
   [126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@xe_pm@s2idle-exec-after.html

  * igt@xe_pm@s4-multiple-execs:
    - shard-lnl:          [PASS][127] -> [FAIL][128] ([Intel XE#6406])
   [127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-1/igt@xe_pm@s4-multiple-execs.html
   [128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-5/igt@xe_pm@s4-multiple-execs.html

  * igt@xe_pm@vram-d3cold-threshold:
    - shard-adlp:         NOTRUN -> [SKIP][129] ([Intel XE#5611] / [Intel XE#579])
   [129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-1/igt@xe_pm@vram-d3cold-threshold.html

  * igt@xe_pxp@pxp-stale-bo-exec-post-termination-irq:
    - shard-dg2-set2:     NOTRUN -> [SKIP][130] ([Intel XE#4733])
   [130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-436/igt@xe_pxp@pxp-stale-bo-exec-post-termination-irq.html

  * igt@xe_query@multigpu-query-invalid-cs-cycles:
    - shard-dg2-set2:     NOTRUN -> [SKIP][131] ([Intel XE#944])
   [131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-435/igt@xe_query@multigpu-query-invalid-cs-cycles.html
    - shard-lnl:          NOTRUN -> [SKIP][132] ([Intel XE#944])
   [132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-1/igt@xe_query@multigpu-query-invalid-cs-cycles.html

  * igt@xe_sriov_scheduling@equal-throughput:
    - shard-dg2-set2:     NOTRUN -> [SKIP][133] ([Intel XE#4351])
   [133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-434/igt@xe_sriov_scheduling@equal-throughput.html

  * igt@xe_sriov_scheduling@nonpreempt-engine-resets:
    - shard-bmg:          [PASS][134] -> [FAIL][135] ([Intel XE#5937]) +1 other test fail
   [134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-7/igt@xe_sriov_scheduling@nonpreempt-engine-resets.html
   [135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@xe_sriov_scheduling@nonpreempt-engine-resets.html

  
#### Possible fixes ####

  * igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-6:
    - shard-dg2-set2:     [FAIL][136] ([Intel XE#3908]) -> [PASS][137] +1 other test pass
   [136]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-466/igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-6.html
   [137]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-432/igt@kms_atomic_transition@plane-all-modeset-transition-fencing@pipe-a-hdmi-a-6.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6:
    - shard-dg2-set2:     [INCOMPLETE][138] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#6168]) -> [PASS][139]
   [138]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-434/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6.html
   [139]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs@pipe-a-hdmi-a-6.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs:
    - shard-dg2-set2:     [INCOMPLETE][140] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522]) -> [PASS][141]
   [140]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-436/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html
   [141]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-432/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-a-dp-4:
    - shard-dg2-set2:     [INCOMPLETE][142] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4522]) -> [PASS][143]
   [142]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-436/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-a-dp-4.html
   [143]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-432/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-a-dp-4.html

  * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
    - shard-bmg:          [SKIP][144] ([Intel XE#2291]) -> [PASS][145]
   [144]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy.html
   [145]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-5/igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy.html

  * igt@kms_dp_linktrain_fallback@dp-fallback:
    - shard-bmg:          [FAIL][146] ([Intel XE#4367]) -> [PASS][147]
   [146]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-1/igt@kms_dp_linktrain_fallback@dp-fallback.html
   [147]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@kms_dp_linktrain_fallback@dp-fallback.html

  * igt@kms_flip@2x-plain-flip-fb-recreate:
    - shard-bmg:          [SKIP][148] ([Intel XE#2316]) -> [PASS][149] +4 other tests pass
   [148]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_flip@2x-plain-flip-fb-recreate.html
   [149]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-5/igt@kms_flip@2x-plain-flip-fb-recreate.html

  * igt@kms_flip@absolute-wf_vblank-interruptible@c-hdmi-a6:
    - shard-dg2-set2:     [INCOMPLETE][150] ([Intel XE#2049]) -> [PASS][151] +1 other test pass
   [150]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-463/igt@kms_flip@absolute-wf_vblank-interruptible@c-hdmi-a6.html
   [151]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-463/igt@kms_flip@absolute-wf_vblank-interruptible@c-hdmi-a6.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
    - shard-lnl:          [FAIL][152] ([Intel XE#301] / [Intel XE#3149]) -> [PASS][153]
   [152]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
   [153]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html

  * igt@kms_flip@flip-vs-rmfb-interruptible:
    - shard-adlp:         [DMESG-WARN][154] ([Intel XE#4543] / [Intel XE#5208]) -> [PASS][155]
   [154]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-2/igt@kms_flip@flip-vs-rmfb-interruptible.html
   [155]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-3/igt@kms_flip@flip-vs-rmfb-interruptible.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-adlp:         [DMESG-WARN][156] ([Intel XE#4543]) -> [PASS][157] +6 other tests pass
   [156]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-9/igt@kms_flip@flip-vs-suspend-interruptible.html
   [157]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-4/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-y-to-x:
    - shard-adlp:         [DMESG-FAIL][158] ([Intel XE#4543]) -> [PASS][159]
   [158]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-8/igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-y-to-x.html
   [159]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-6/igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-y-to-x.html

  * igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-y:
    - shard-adlp:         [FAIL][160] ([Intel XE#1874]) -> [PASS][161]
   [160]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-8/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-y.html
   [161]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-6/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-x-to-y.html

  * igt@kms_hdr@static-toggle-suspend:
    - shard-bmg:          [SKIP][162] ([Intel XE#1503]) -> [PASS][163] +1 other test pass
   [162]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_hdr@static-toggle-suspend.html
   [163]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-1/igt@kms_hdr@static-toggle-suspend.html

  * igt@kms_plane_multiple@2x-tiling-4:
    - shard-bmg:          [SKIP][164] ([Intel XE#4596]) -> [PASS][165]
   [164]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_plane_multiple@2x-tiling-4.html
   [165]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-5/igt@kms_plane_multiple@2x-tiling-4.html

  * igt@kms_plane_scaling@intel-max-src-size:
    - shard-bmg:          [SKIP][166] ([Intel XE#2685] / [Intel XE#3307]) -> [PASS][167]
   [166]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-4/igt@kms_plane_scaling@intel-max-src-size.html
   [167]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@kms_plane_scaling@intel-max-src-size.html
    - shard-dg2-set2:     [SKIP][168] ([Intel XE#455]) -> [PASS][169]
   [168]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-463/igt@kms_plane_scaling@intel-max-src-size.html
   [169]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-432/igt@kms_plane_scaling@intel-max-src-size.html

  * igt@kms_pm_dc@dc5-psr:
    - shard-lnl:          [FAIL][170] ([Intel XE#718]) -> [PASS][171]
   [170]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-4/igt@kms_pm_dc@dc5-psr.html
   [171]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-3/igt@kms_pm_dc@dc5-psr.html

  * igt@xe_pm@s3-basic:
    - shard-adlp:         [INCOMPLETE][172] ([Intel XE#6255]) -> [PASS][173]
   [172]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-6/igt@xe_pm@s3-basic.html
   [173]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-2/igt@xe_pm@s3-basic.html

  * igt@xe_sriov_auto_provisioning@selfconfig-basic:
    - shard-bmg:          [FAIL][174] ([Intel XE#5937]) -> [PASS][175] +1 other test pass
   [174]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-1/igt@xe_sriov_auto_provisioning@selfconfig-basic.html
   [175]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@xe_sriov_auto_provisioning@selfconfig-basic.html

  
#### Warnings ####

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs:
    - shard-dg2-set2:     [INCOMPLETE][176] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4345] / [Intel XE#6168]) -> [INCOMPLETE][177] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522])
   [176]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-434/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs.html
   [177]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-466/igt@kms_ccs@random-ccs-data-4-tiled-dg2-mc-ccs.html

  * igt@kms_content_protection@srm:
    - shard-bmg:          [SKIP][178] ([Intel XE#2341]) -> [FAIL][179] ([Intel XE#1178])
   [178]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_content_protection@srm.html
   [179]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@kms_content_protection@srm.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-lnl:          [FAIL][180] ([Intel XE#301] / [Intel XE#3149]) -> [FAIL][181] ([Intel XE#301])
   [180]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-lnl-2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [181]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@plain-flip-interruptible:
    - shard-adlp:         [DMESG-WARN][182] ([Intel XE#4543]) -> [DMESG-WARN][183] ([Intel XE#2953] / [Intel XE#4173] / [Intel XE#4543])
   [182]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-9/igt@kms_flip@plain-flip-interruptible.html
   [183]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-2/igt@kms_flip@plain-flip-interruptible.html

  * igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-blt:
    - shard-bmg:          [SKIP][184] ([Intel XE#2312]) -> [SKIP][185] ([Intel XE#2311]) +6 other tests skip
   [184]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-blt.html
   [185]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-4/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-shrfb-draw-blt:
    - shard-adlp:         [DMESG-FAIL][186] ([Intel XE#4543]) -> [FAIL][187] ([Intel XE#5671])
   [186]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-1/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-shrfb-draw-blt.html
   [187]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-9/igt@kms_frontbuffer_tracking@fbc-1p-offscreen-pri-shrfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
    - shard-adlp:         [FAIL][188] ([Intel XE#5671]) -> [DMESG-FAIL][189] ([Intel XE#4543])
   [188]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
   [189]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
    - shard-bmg:          [SKIP][190] ([Intel XE#5390]) -> [SKIP][191] ([Intel XE#2312]) +8 other tests skip
   [190]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html
   [191]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
    - shard-bmg:          [SKIP][192] ([Intel XE#2312]) -> [SKIP][193] ([Intel XE#5390]) +6 other tests skip
   [192]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html
   [193]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-spr-indfb-draw-render:
    - shard-bmg:          [SKIP][194] ([Intel XE#2311]) -> [SKIP][195] ([Intel XE#2312]) +12 other tests skip
   [194]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-5/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-spr-indfb-draw-render.html
   [195]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcdrrs-2p-primscrn-spr-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-fullscreen:
    - shard-bmg:          [SKIP][196] ([Intel XE#2312]) -> [SKIP][197] ([Intel XE#2313]) +9 other tests skip
   [196]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-fullscreen.html
   [197]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-spr-indfb-fullscreen.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
    - shard-bmg:          [SKIP][198] ([Intel XE#2313]) -> [SKIP][199] ([Intel XE#2312]) +8 other tests skip
   [198]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html
   [199]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html

  * igt@kms_tiled_display@basic-test-pattern-with-chamelium:
    - shard-bmg:          [SKIP][200] ([Intel XE#2426]) -> [SKIP][201] ([Intel XE#2509])
   [200]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-6/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
   [201]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-1/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
    - shard-dg2-set2:     [SKIP][202] ([Intel XE#1500]) -> [SKIP][203] ([Intel XE#362])
   [202]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-dg2-432/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html
   [203]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern-with-chamelium.html

  * igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv:
    - shard-bmg:          [ABORT][204] ([Intel XE#5466] / [Intel XE#5530]) -> [ABORT][205] ([Intel XE#4917] / [Intel XE#5466] / [Intel XE#5530])
   [204]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-bmg-3/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
   [205]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-bmg-7/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html

  * igt@xe_peer2peer@read:
    - shard-adlp:         [SKIP][206] ([Intel XE#1061] / [Intel XE#5568]) -> [DMESG-FAIL][207] ([Intel XE#5213])
   [206]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd/shard-adlp-2/igt@xe_peer2peer@read.html
   [207]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/shard-adlp-9/igt@xe_peer2peer@read.html

  
  [Intel XE#1061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1061
  [Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
  [Intel XE#1127]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1127
  [Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
  [Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
  [Intel XE#1397]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1397
  [Intel XE#1401]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1401
  [Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
  [Intel XE#1421]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1421
  [Intel XE#1424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1424
  [Intel XE#1477]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1477
  [Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
  [Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
  [Intel XE#1500]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1500
  [Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
  [Intel XE#1727]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1727
  [Intel XE#1745]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1745
  [Intel XE#1874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1874
  [Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049
  [Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
  [Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
  [Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
  [Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293
  [Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
  [Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
  [Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
  [Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
  [Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
  [Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
  [Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
  [Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
  [Intel XE#2360]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2360
  [Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380
  [Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
  [Intel XE#2459]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2459
  [Intel XE#2499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2499
  [Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
  [Intel XE#2596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2596
  [Intel XE#261]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/261
  [Intel XE#2685]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2685
  [Intel XE#2705]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2705
  [Intel XE#2724]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2724
  [Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
  [Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
  [Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
  [Intel XE#2893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2893
  [Intel XE#2925]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2925
  [Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
  [Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
  [Intel XE#306]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/306
  [Intel XE#310]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/310
  [Intel XE#3113]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3113
  [Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
  [Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
  [Intel XE#3278]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3278
  [Intel XE#3307]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3307
  [Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
  [Intel XE#3573]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3573
  [Intel XE#362]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/362
  [Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
  [Intel XE#3862]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3862
  [Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
  [Intel XE#3908]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3908
  [Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
  [Intel XE#4212]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4212
  [Intel XE#4345]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4345
  [Intel XE#4351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4351
  [Intel XE#4367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4367
  [Intel XE#4504]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4504
  [Intel XE#4518]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4518
  [Intel XE#4522]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4522
  [Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
  [Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
  [Intel XE#4596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4596
  [Intel XE#4608]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4608
  [Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
  [Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
  [Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
  [Intel XE#4917]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4917
  [Intel XE#4943]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4943
  [Intel XE#5208]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5208
  [Intel XE#5213]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5213
  [Intel XE#5300]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5300
  [Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
  [Intel XE#5466]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5466
  [Intel XE#5530]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5530
  [Intel XE#5561]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5561
  [Intel XE#5565]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5565
  [Intel XE#5568]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5568
  [Intel XE#5575]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5575
  [Intel XE#5611]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5611
  [Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
  [Intel XE#5671]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5671
  [Intel XE#579]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/579
  [Intel XE#5937]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5937
  [Intel XE#6054]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6054
  [Intel XE#607]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/607
  [Intel XE#6168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6168
  [Intel XE#619]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/619
  [Intel XE#6196]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6196
  [Intel XE#6255]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6255
  [Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
  [Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
  [Intel XE#6360]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6360
  [Intel XE#6406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6406
  [Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
  [Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
  [Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
  [Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
  [Intel XE#718]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/718
  [Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
  [Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
  [Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
  [Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
  [i915#15106]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15106


Build changes
-------------

  * IGT: IGT_8594 -> IGT_8595
  * Linux: xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd -> xe-pw-156358v1

  IGT_8594: 8594
  IGT_8595: 8595
  xe-3969-71929a54e8bb5da291d41a931d80c6c9160073dd: 71929a54e8bb5da291d41a931d80c6c9160073dd
  xe-pw-156358v1: 156358v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156358v1/index.html

[-- Attachment #2: Type: text/html, Size: 74325 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/6] drm/i915/display: create intel_display_utils.h
  2025-10-22 15:17 ` [PATCH 2/6] drm/i915/display: create intel_display_utils.h Jani Nikula
@ 2025-10-30  7:51   ` Luca Coelho
  0 siblings, 0 replies; 23+ messages in thread
From: Luca Coelho @ 2025-10-30  7:51 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> Start a file for display specific generic utilities.
> 
> Move KHz() and MHz() helpers there first.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.


>  drivers/gpu/drm/i915/display/intel_backlight.c     |  2 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c           |  1 +
>  drivers/gpu/drm/i915/display/intel_display_utils.h | 10 ++++++++++
>  drivers/gpu/drm/i915/display/intel_dp_mst.c        |  2 +-
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |  1 +
>  drivers/gpu/drm/i915/i915_utils.h                  |  3 ---
>  6 files changed, 14 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.h
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
> index 3b14f929825a..a68fdbd2acb9 100644
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -13,7 +13,6 @@
>  #include <drm/drm_print.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_backlight.h"
>  #include "intel_backlight_regs.h"
>  #include "intel_connector.h"
> @@ -21,6 +20,7 @@
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp_aux_backlight.h"
>  #include "intel_dsi_dcs_backlight.h"
>  #include "intel_panel.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 870140340342..cd9fc3d1f36a 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -53,6 +53,7 @@
>  #include "intel_display_power.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dkl_phy.h"
>  #include "intel_dkl_phy_regs.h"
>  #include "intel_dp.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
> new file mode 100644
> index 000000000000..0a2b603ea856
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: MIT */
> +/* Copyright © 2025 Intel Corporation */
> +
> +#ifndef __INTEL_DISPLAY_UTILS__
> +#define __INTEL_DISPLAY_UTILS__
> +
> +#define KHz(x) (1000 * (x))
> +#define MHz(x) KHz(1000 * (x))
> +
> +#endif /* __INTEL_DISPLAY_UTILS__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index a845b2612a3f..8d11a989cf79 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -33,7 +33,6 @@
>  #include <drm/drm_print.h>
>  #include <drm/drm_probe_helper.h>
>  
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_audio.h"
>  #include "intel_connector.h"
> @@ -43,6 +42,7 @@
>  #include "intel_display_driver.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_dp_hdcp.h"
>  #include "intel_dp_link_training.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 8ea96cc524a1..900a945ff8ab 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -32,6 +32,7 @@
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dkl_phy.h"
>  #include "intel_dkl_phy_regs.h"
>  #include "intel_dpio_phy.h"
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 44de4a4aa84a..c1f978a7c141 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -100,9 +100,6 @@ static inline bool is_power_of_2_u64(u64 n)
>  	return (n != 0 && ((n & (n - 1)) == 0));
>  }
>  
> -#define KHz(x) (1000 * (x))
> -#define MHz(x) KHz(1000 * (x))
> -
>  void add_taint_for_CI(struct drm_i915_private *i915, unsigned int taint);
>  static inline void __add_taint_for_CI(unsigned int taint)
>  {

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 1/6] drm/i915: split out separate files for jiffies timeout and wait helpers
  2025-10-22 15:17 ` [PATCH 1/6] drm/i915: split out separate files for jiffies timeout and wait helpers Jani Nikula
@ 2025-10-30  7:53   ` Luca Coelho
  0 siblings, 0 replies; 23+ messages in thread
From: Luca Coelho @ 2025-10-30  7:53 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> Add i915_jiffies.h and intel_display_jiffies.h for jiffies timeout and
> wait helpers, and use them separately from i915 and display. This helps
> reduce the display dependency on i915_utils.h.
> 
> Long term, both msecs_to_jiffies_timeout() and
> wait_remaining_ms_from_jiffies() really belong in core kernel headers,
> but for now unblock display refactoring.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.


>  .../drm/i915/display/intel_display_jiffies.h  | 43 +++++++++++++++++++
>  drivers/gpu/drm/i915/display/intel_dp.c       |  1 +
>  .../drm/i915/display/intel_dp_link_training.c |  1 +
>  drivers/gpu/drm/i915/display/intel_hdcp.c     |  1 +
>  drivers/gpu/drm/i915/display/intel_pmdemand.c |  1 +
>  drivers/gpu/drm/i915/display/intel_pps.c      |  1 +
>  drivers/gpu/drm/i915/display/intel_vblank.c   |  1 +
>  drivers/gpu/drm/i915/gem/i915_gem_mman.c      |  5 ++-
>  drivers/gpu/drm/i915/gem/i915_gem_ttm.c       |  1 +
>  .../gpu/drm/i915/gt/intel_engine_heartbeat.c  |  1 +
>  drivers/gpu/drm/i915/gt/selftest_execlists.c  |  1 +
>  drivers/gpu/drm/i915/i915_config.c            |  2 +-
>  drivers/gpu/drm/i915/i915_jiffies.h           | 16 +++++++
>  drivers/gpu/drm/i915/i915_utils.h             | 34 ---------------
>  .../gpu/drm/i915/selftests/i915_selftest.c    |  1 +
>  15 files changed, 73 insertions(+), 37 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_jiffies.h
>  create mode 100644 drivers/gpu/drm/i915/i915_jiffies.h
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_jiffies.h b/drivers/gpu/drm/i915/display/intel_display_jiffies.h
> new file mode 100644
> index 000000000000..c060c567e262
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_display_jiffies.h
> @@ -0,0 +1,43 @@
> +/* SPDX-License-Identifier: MIT */
> +/* Copyright © 2025 Intel Corporation */
> +
> +#ifndef __INTEL_DISPLAY_JIFFIES_H__
> +#define __INTEL_DISPLAY_JIFFIES_H__
> +
> +#include <linux/jiffies.h>
> +
> +static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
> +{
> +	unsigned long j = msecs_to_jiffies(m);
> +
> +	return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
> +}
> +
> +/*
> + * If you need to wait X milliseconds between events A and B, but event B
> + * doesn't happen exactly after event A, you record the timestamp (jiffies) of
> + * when event A happened, then just before event B you call this function and
> + * pass the timestamp as the first argument, and X as the second argument.
> + */
> +static inline void
> +wait_remaining_ms_from_jiffies(unsigned long timestamp_jiffies, int to_wait_ms)
> +{
> +	unsigned long target_jiffies, tmp_jiffies, remaining_jiffies;
> +
> +	/*
> +	 * Don't re-read the value of "jiffies" every time since it may change
> +	 * behind our back and break the math.
> +	 */
> +	tmp_jiffies = jiffies;
> +	target_jiffies = timestamp_jiffies +
> +			 msecs_to_jiffies_timeout(to_wait_ms);
> +
> +	if (time_after(target_jiffies, tmp_jiffies)) {
> +		remaining_jiffies = target_jiffies - tmp_jiffies;
> +		while (remaining_jiffies)
> +			remaining_jiffies =
> +			    schedule_timeout_uninterruptible(remaining_jiffies);
> +	}
> +}
> +
> +#endif /* __INTEL_DISPLAY_JIFFIES_H__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index b0aeb6c2de86..78e21bfd29bd 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -64,6 +64,7 @@
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
> +#include "intel_display_jiffies.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index 27f3716bdc1f..316b42b5a946 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -29,6 +29,7 @@
>  
>  #include "i915_utils.h"
>  #include "intel_display_core.h"
> +#include "intel_display_jiffies.h"
>  #include "intel_display_types.h"
>  #include "intel_dp.h"
>  #include "intel_dp_link_training.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 531ee122bf82..0f624004104f 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -22,6 +22,7 @@
>  #include "i915_utils.h"
>  #include "intel_connector.h"
>  #include "intel_de.h"
> +#include "intel_display_jiffies.h"
>  #include "intel_display_power.h"
>  #include "intel_display_power_well.h"
>  #include "intel_display_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c b/drivers/gpu/drm/i915/display/intel_pmdemand.c
> index d806c15db7ce..7ade35e05eb5 100644
> --- a/drivers/gpu/drm/i915/display/intel_pmdemand.c
> +++ b/drivers/gpu/drm/i915/display/intel_pmdemand.c
> @@ -12,6 +12,7 @@
>  #include "intel_bw.h"
>  #include "intel_cdclk.h"
>  #include "intel_de.h"
> +#include "intel_display_jiffies.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_pmdemand.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 327e0de86f1e..0c2f48626d0c 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -12,6 +12,7 @@
>  #include "i915_reg.h"
>  #include "i915_utils.h"
>  #include "intel_de.h"
> +#include "intel_display_jiffies.h"
>  #include "intel_display_power_well.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
> index 2fc0c1c0bb87..0e534be375ca 100644
> --- a/drivers/gpu/drm/i915/display/intel_vblank.c
> +++ b/drivers/gpu/drm/i915/display/intel_vblank.c
> @@ -12,6 +12,7 @@
>  #include "intel_color.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
> +#include "intel_display_jiffies.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
>  #include "intel_vblank.h"
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> index 75f5b0e871ef..4542135b20d5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c
> @@ -16,12 +16,13 @@
>  #include "i915_gem_evict.h"
>  #include "i915_gem_gtt.h"
>  #include "i915_gem_ioctls.h"
> -#include "i915_gem_object.h"
>  #include "i915_gem_mman.h"
> +#include "i915_gem_object.h"
> +#include "i915_gem_ttm.h"
> +#include "i915_jiffies.h"
>  #include "i915_mm.h"
>  #include "i915_trace.h"
>  #include "i915_user_extensions.h"
> -#include "i915_gem_ttm.h"
>  #include "i915_vma.h"
>  
>  static inline bool
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 57bb111d65da..d119e54e5be1 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -10,6 +10,7 @@
>  #include <drm/drm_buddy.h>
>  
>  #include "i915_drv.h"
> +#include "i915_jiffies.h"
>  #include "i915_ttm_buddy_manager.h"
>  #include "intel_memory_region.h"
>  #include "intel_region_ttm.h"
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
> index 8d4bb95f8424..dcd3a3047aa4 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c
> @@ -4,6 +4,7 @@
>   */
>  
>  #include "i915_drv.h"
> +#include "i915_jiffies.h"
>  #include "i915_request.h"
>  
>  #include "intel_context.h"
> diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> index 0454eb1814bb..376f201a7650 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
> @@ -11,6 +11,7 @@
>  #include "gt/intel_reset.h"
>  #include "gt/selftest_engine_heartbeat.h"
>  
> +#include "i915_jiffies.h"
>  #include "i915_selftest.h"
>  #include "selftests/i915_random.h"
>  #include "selftests/igt_flush_test.h"
> diff --git a/drivers/gpu/drm/i915/i915_config.c b/drivers/gpu/drm/i915/i915_config.c
> index 24e5bb8a670e..3cb615ffa96d 100644
> --- a/drivers/gpu/drm/i915/i915_config.c
> +++ b/drivers/gpu/drm/i915/i915_config.c
> @@ -6,7 +6,7 @@
>  #include <linux/kernel.h>
>  
>  #include "i915_config.h"
> -#include "i915_utils.h"
> +#include "i915_jiffies.h"
>  
>  unsigned long
>  i915_fence_context_timeout(const struct drm_i915_private *i915, u64 context)
> diff --git a/drivers/gpu/drm/i915/i915_jiffies.h b/drivers/gpu/drm/i915/i915_jiffies.h
> new file mode 100644
> index 000000000000..18a4eaea897a
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/i915_jiffies.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: MIT */
> +/* Copyright © 2025 Intel Corporation */
> +
> +#ifndef __I915_JIFFIES_H__
> +#define __I915_JIFFIES_H__
> +
> +#include <linux/jiffies.h>
> +
> +static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
> +{
> +	unsigned long j = msecs_to_jiffies(m);
> +
> +	return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
> +}
> +
> +#endif /* __I915_JIFFIES_H__ */
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index a0c892e4c40d..44de4a4aa84a 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -100,40 +100,6 @@ static inline bool is_power_of_2_u64(u64 n)
>  	return (n != 0 && ((n & (n - 1)) == 0));
>  }
>  
> -static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
> -{
> -	unsigned long j = msecs_to_jiffies(m);
> -
> -	return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
> -}
> -
> -/*
> - * If you need to wait X milliseconds between events A and B, but event B
> - * doesn't happen exactly after event A, you record the timestamp (jiffies) of
> - * when event A happened, then just before event B you call this function and
> - * pass the timestamp as the first argument, and X as the second argument.
> - */
> -static inline void
> -wait_remaining_ms_from_jiffies(unsigned long timestamp_jiffies, int to_wait_ms)
> -{
> -	unsigned long target_jiffies, tmp_jiffies, remaining_jiffies;
> -
> -	/*
> -	 * Don't re-read the value of "jiffies" every time since it may change
> -	 * behind our back and break the math.
> -	 */
> -	tmp_jiffies = jiffies;
> -	target_jiffies = timestamp_jiffies +
> -			 msecs_to_jiffies_timeout(to_wait_ms);
> -
> -	if (time_after(target_jiffies, tmp_jiffies)) {
> -		remaining_jiffies = target_jiffies - tmp_jiffies;
> -		while (remaining_jiffies)
> -			remaining_jiffies =
> -			    schedule_timeout_uninterruptible(remaining_jiffies);
> -	}
> -}
> -
>  #define KHz(x) (1000 * (x))
>  #define MHz(x) KHz(1000 * (x))
>  
> diff --git a/drivers/gpu/drm/i915/selftests/i915_selftest.c b/drivers/gpu/drm/i915/selftests/i915_selftest.c
> index 9c276c9d0a75..8460f0a70d04 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_selftest.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_selftest.c
> @@ -30,6 +30,7 @@
>  
>  #include "i915_driver.h"
>  #include "i915_drv.h"
> +#include "i915_jiffies.h"
>  #include "i915_selftest.h"
>  #include "i915_wait_util.h"
>  #include "igt_flush_test.h"

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest()
  2025-10-22 15:17 ` [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest() Jani Nikula
@ 2025-10-30  7:57   ` Luca Coelho
  2025-10-30  8:48     ` Jani Nikula
  0 siblings, 1 reply; 23+ messages in thread
From: Luca Coelho @ 2025-10-30  7:57 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> Add intel_display_utils.c for display utilities that need more than a
> header.
> 
> Start off with intel_display_run_as_guest(). The implementation is
> intentional duplication of the i915_utils.h i915_run_as_guest(), with
> the idea that it's small enough to not matter.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---



>  drivers/gpu/drm/i915/Makefile                  |  1 +
>  .../gpu/drm/i915/display/intel_display_utils.c | 18 ++++++++++++++++++
>  .../gpu/drm/i915/display/intel_display_utils.h |  6 ++++++
>  drivers/gpu/drm/i915/display/intel_pch.c       |  4 ++--
>  drivers/gpu/drm/xe/Makefile                    |  1 +
>  5 files changed, 28 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.c
> 
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 47bac9b2c611..046f9282fb65 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -255,6 +255,7 @@ i915-y += \
>  	display/intel_display_rpm.o \
>  	display/intel_display_rps.o \
>  	display/intel_display_snapshot.o \
> +	display/intel_display_utils.o \
>  	display/intel_display_wa.o \
>  	display/intel_dmc.o \
>  	display/intel_dmc_wl.o \
> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
> new file mode 100644
> index 000000000000..13d3999dd580
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: MIT
> +/* Copyright © 2025 Intel Corporation */
> +
> +#ifdef CONFIG_X86
> +#include <asm/hypervisor.h>
> +#endif
> +
> +#include "intel_display_utils.h"
> +
> +bool intel_display_run_as_guest(struct intel_display *display)
> +{
> +#if IS_ENABLED(CONFIG_X86)
> +	return !hypervisor_is_type(X86_HYPER_NATIVE);
> +#else
> +	/* Not supported yet */
> +	return false;
> +#endif
> +}

Why can't this be an inline in the header file?

--
Cheers,
Luca.


> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
> index 0a2b603ea856..e54e69afd959 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_utils.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
> @@ -4,7 +4,13 @@
>  #ifndef __INTEL_DISPLAY_UTILS__
>  #define __INTEL_DISPLAY_UTILS__
>  
> +#include <linux/types.h>
> +
> +struct intel_display;
> +
>  #define KHz(x) (1000 * (x))
>  #define MHz(x) KHz(1000 * (x))
>  
> +bool intel_display_run_as_guest(struct intel_display *display);
> +
>  #endif /* __INTEL_DISPLAY_UTILS__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_pch.c b/drivers/gpu/drm/i915/display/intel_pch.c
> index 469e8a3cfb49..65359a36df48 100644
> --- a/drivers/gpu/drm/i915/display/intel_pch.c
> +++ b/drivers/gpu/drm/i915/display/intel_pch.c
> @@ -5,8 +5,8 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_display_core.h"
> +#include "intel_display_utils.h"
>  #include "intel_pch.h"
>  
>  #define INTEL_PCH_DEVICE_ID_MASK		0xff80
> @@ -328,7 +328,7 @@ void intel_pch_detect(struct intel_display *display)
>  			    "Display disabled, reverting to NOP PCH\n");
>  		display->pch_type = PCH_NOP;
>  	} else if (!pch) {
> -		if (i915_run_as_guest() && HAS_DISPLAY(display)) {
> +		if (intel_display_run_as_guest(display) && HAS_DISPLAY(display)) {
>  			intel_virt_detect_pch(display, &id, &pch_type);
>  			display->pch_type = pch_type;
>  		} else {
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index 82c6b3d29676..feb8225d4d79 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -257,6 +257,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
>  	i915-display/intel_display_power_map.o \
>  	i915-display/intel_display_power_well.o \
>  	i915-display/intel_display_trace.o \
> +	i915-display/intel_display_utils.o \
>  	i915-display/intel_display_wa.o \
>  	i915-display/intel_dkl_phy.o \
>  	i915-display/intel_dmc.o \

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 4/6] drm/i915/display: add intel_display_vtd_active()
  2025-10-22 15:17 ` [PATCH 4/6] drm/i915/display: add intel_display_vtd_active() Jani Nikula
@ 2025-10-30  8:00   ` Luca Coelho
  2025-10-30  8:50     ` Jani Nikula
  0 siblings, 1 reply; 23+ messages in thread
From: Luca Coelho @ 2025-10-30  8:00 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> Add intel_display_vtd_active() to utils. It's intentional duplication
> with i915_utils.h i915_vtd_active(), but reduces duplication with
> xe. Win some, lose some.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bw.c            |  4 ++--
>  drivers/gpu/drm/i915/display/intel_display.c       |  8 +++-----
>  drivers/gpu/drm/i915/display/intel_display_utils.c | 14 ++++++++++++++
>  drivers/gpu/drm/i915/display/intel_display_utils.h |  1 +
>  drivers/gpu/drm/i915/display/intel_fbc.c           |  4 +++-
>  drivers/gpu/drm/xe/display/ext/i915_utils.c        | 10 ----------
>  6 files changed, 23 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 92a060e02cf3..640a40805f18 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -13,6 +13,7 @@
>  #include "intel_display_core.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_mchbar_regs.h"
>  #include "intel_pcode.h"
>  #include "intel_uncore.h"
> @@ -842,14 +843,13 @@ static unsigned int intel_bw_num_active_planes(struct intel_display *display,
>  static unsigned int intel_bw_data_rate(struct intel_display *display,
>  				       const struct intel_bw_state *bw_state)
>  {
> -	struct drm_i915_private *i915 = to_i915(display->drm);
>  	unsigned int data_rate = 0;
>  	enum pipe pipe;
>  
>  	for_each_pipe(display, pipe)
>  		data_rate += bw_state->data_rate[pipe];
>  
> -	if (DISPLAY_VER(display) >= 13 && i915_vtd_active(i915))
> +	if (DISPLAY_VER(display) >= 13 && intel_display_vtd_active(display))
>  		data_rate = DIV_ROUND_UP(data_rate * 105, 100);
>  
>  	return data_rate;
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index a8b4619de347..33174fb46ecb 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -76,6 +76,7 @@
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_display_wa.h"
>  #include "intel_dmc.h"
>  #include "intel_dp.h"
> @@ -830,9 +831,8 @@ static void intel_async_flip_vtd_wa(struct intel_display *display,
>  static bool needs_async_flip_vtd_wa(const struct intel_crtc_state *crtc_state)
>  {
>  	struct intel_display *display = to_intel_display(crtc_state);
> -	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
>  
> -	return crtc_state->uapi.async_flip && i915_vtd_active(i915) &&
> +	return crtc_state->uapi.async_flip && intel_display_vtd_active(display) &&
>  		(DISPLAY_VER(display) == 9 || display->platform.broadwell ||
>  		 display->platform.haswell);
>  }
> @@ -8313,7 +8313,5 @@ void i830_disable_pipe(struct intel_display *display, enum pipe pipe)
>  
>  bool intel_scanout_needs_vtd_wa(struct intel_display *display)
>  {
> -	struct drm_i915_private *i915 = to_i915(display->drm);
> -
> -	return IS_DISPLAY_VER(display, 6, 11) && i915_vtd_active(i915);
> +	return IS_DISPLAY_VER(display, 6, 11) && intel_display_vtd_active(display);
>  }
> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
> index 13d3999dd580..04d010f7c23e 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_utils.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
> @@ -1,10 +1,15 @@
>  // SPDX-License-Identifier: MIT
>  /* Copyright © 2025 Intel Corporation */
>  
> +#include <linux/device.h>
> +
> +#include <drm/drm_device.h>
> +
>  #ifdef CONFIG_X86
>  #include <asm/hypervisor.h>
>  #endif
>  
> +#include "intel_display_core.h"
>  #include "intel_display_utils.h"
>  
>  bool intel_display_run_as_guest(struct intel_display *display)
> @@ -16,3 +21,12 @@ bool intel_display_run_as_guest(struct intel_display *display)
>  	return false;
>  #endif
>  }
> +
> +bool intel_display_vtd_active(struct intel_display *display)
> +{
> +	if (device_iommu_mapped(display->drm->dev))
> +		return true;
> +
> +	/* Running as a guest, we assume the host is enforcing VT'd */
> +	return intel_display_run_as_guest(display);
> +}

This also looks quite much like an "inlineable" function, no?

--
Cheers,
Luca.


> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
> index e54e69afd959..af1e34bac720 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_utils.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
> @@ -12,5 +12,6 @@ struct intel_display;
>  #define MHz(x) KHz(1000 * (x))
>  
>  bool intel_display_run_as_guest(struct intel_display *display);
> +bool intel_display_vtd_active(struct intel_display *display);
>  
>  #endif /* __INTEL_DISPLAY_UTILS__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 10ef3136dadc..6f2cc01ea4a0 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -59,6 +59,7 @@
>  #include "intel_display_rpm.h"
>  #include "intel_display_trace.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_display_wa.h"
>  #include "intel_fbc.h"
>  #include "intel_fbc_regs.h"
> @@ -1472,7 +1473,8 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
>  	}
>  
>  	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
> -	if (i915_vtd_active(i915) && (display->platform.skylake || display->platform.broxton)) {
> +	if (intel_display_vtd_active(display) &&
> +	    (display->platform.skylake || display->platform.broxton)) {
>  		plane_state->no_fbc_reason = "VT-d enabled";
>  		return 0;
>  	}
> diff --git a/drivers/gpu/drm/xe/display/ext/i915_utils.c b/drivers/gpu/drm/xe/display/ext/i915_utils.c
> index 1421c2a7b64d..af9ec2abbaa1 100644
> --- a/drivers/gpu/drm/xe/display/ext/i915_utils.c
> +++ b/drivers/gpu/drm/xe/display/ext/i915_utils.c
> @@ -3,18 +3,8 @@
>   * Copyright © 2023 Intel Corporation
>   */
>  
> -#include "i915_drv.h"
>  #include "i915_utils.h"
>  
> -bool i915_vtd_active(struct drm_i915_private *i915)
> -{
> -	if (device_iommu_mapped(i915->drm.dev))
> -		return true;
> -
> -	/* Running as a guest, we assume the host is enforcing VT'd */
> -	return i915_run_as_guest();
> -}
> -
>  #if IS_ENABLED(CONFIG_DRM_I915_DEBUG)
>  
>  /* i915 specific, just put here for shutting it up */

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/6] drm/i915/display: switch to intel_display_utils.h
  2025-10-22 15:17 ` [PATCH 5/6] drm/i915/display: switch to intel_display_utils.h Jani Nikula
@ 2025-10-30  8:03   ` Luca Coelho
  0 siblings, 0 replies; 23+ messages in thread
From: Luca Coelho @ 2025-10-30  8:03 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> The remaining utils display needs from i915_utils.h are primarily
> MISSING_CASE() and fetch_and_zero(), with a couple of
> i915_inject_probe_failure() uses.
> 
> To avoid excessive churn, add duplicates of MISSING_CASE() and
> fetch_and_zero() to intel_display_utils.h, and switch display to use the
> display utils.
> 
> As long as there are display files that include i915_drv.h, which
> includes i915_utils.h, we'll need #ifndef guards for MISSING_CASE() and
> fetch_and_zero() in both utils headers. We can remove them once display
> no longer depends on i915_drv.h.
> 
> A couple of files in display still need i915_utils.h for
> i915_inject_probe_failure(). Annotate this. They will be handled
> separately.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.


> ---
>  drivers/gpu/drm/i915/display/g4x_dp.c              |  2 +-
>  drivers/gpu/drm/i915/display/i9xx_plane.c          |  2 +-
>  drivers/gpu/drm/i915/display/icl_dsi.c             |  2 +-
>  drivers/gpu/drm/i915/display/intel_acpi.c          |  2 +-
>  drivers/gpu/drm/i915/display/intel_bios.c          |  2 +-
>  drivers/gpu/drm/i915/display/intel_bw.c            |  1 -
>  drivers/gpu/drm/i915/display/intel_cdclk.c         |  2 +-
>  drivers/gpu/drm/i915/display/intel_color.c         |  2 +-
>  drivers/gpu/drm/i915/display/intel_combo_phy.c     |  2 +-
>  drivers/gpu/drm/i915/display/intel_connector.c     |  2 +-
>  drivers/gpu/drm/i915/display/intel_cursor.c        |  2 +-
>  drivers/gpu/drm/i915/display/intel_cx0_phy.c       |  2 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c           |  1 -
>  drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c |  2 +-
>  drivers/gpu/drm/i915/display/intel_display.c       |  1 -
>  .../gpu/drm/i915/display/intel_display_driver.c    |  3 ++-
>  drivers/gpu/drm/i915/display/intel_display_power.c |  2 +-
>  drivers/gpu/drm/i915/display/intel_display_utils.h | 14 ++++++++++++++
>  drivers/gpu/drm/i915/display/intel_dmc.c           |  2 +-
>  drivers/gpu/drm/i915/display/intel_dp.c            |  2 +-
>  drivers/gpu/drm/i915/display/intel_dp_aux.c        |  2 +-
>  .../gpu/drm/i915/display/intel_dp_link_training.c  |  2 +-
>  drivers/gpu/drm/i915/display/intel_dpio_phy.c      |  2 +-
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c      |  1 -
>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c       |  2 +-
>  drivers/gpu/drm/i915/display/intel_dvo.c           |  2 +-
>  drivers/gpu/drm/i915/display/intel_fb.c            |  2 +-
>  drivers/gpu/drm/i915/display/intel_fbc.c           |  1 -
>  drivers/gpu/drm/i915/display/intel_fdi.c           |  2 +-
>  drivers/gpu/drm/i915/display/intel_flipq.c         |  6 +++---
>  drivers/gpu/drm/i915/display/intel_hdcp.c          |  1 -
>  drivers/gpu/drm/i915/display/intel_hdcp_gsc.c      |  1 -
>  drivers/gpu/drm/i915/display/intel_hdmi.c          |  2 +-
>  drivers/gpu/drm/i915/display/intel_hotplug.c       |  4 ++--
>  drivers/gpu/drm/i915/display/intel_hotplug_irq.c   |  2 +-
>  drivers/gpu/drm/i915/display/intel_lspcon.c        |  2 +-
>  drivers/gpu/drm/i915/display/intel_pch_refclk.c    |  2 +-
>  drivers/gpu/drm/i915/display/intel_pfit.c          |  2 +-
>  drivers/gpu/drm/i915/display/intel_pmdemand.c      |  2 +-
>  drivers/gpu/drm/i915/display/intel_pps.c           |  2 +-
>  drivers/gpu/drm/i915/display/intel_psr.c           |  2 +-
>  drivers/gpu/drm/i915/display/intel_qp_tables.c     |  2 +-
>  drivers/gpu/drm/i915/display/intel_snps_phy.c      |  2 +-
>  drivers/gpu/drm/i915/display/intel_sprite.c        |  2 +-
>  drivers/gpu/drm/i915/display/intel_tc.c            |  2 +-
>  drivers/gpu/drm/i915/display/intel_vblank.c        |  2 +-
>  drivers/gpu/drm/i915/display/intel_vdsc.c          |  2 +-
>  drivers/gpu/drm/i915/display/skl_scaler.c          |  2 +-
>  drivers/gpu/drm/i915/display/skl_universal_plane.c |  2 +-
>  drivers/gpu/drm/i915/display/skl_watermark.c       |  2 +-
>  drivers/gpu/drm/i915/display/vlv_dsi.c             |  2 +-
>  drivers/gpu/drm/i915/i915_utils.h                  |  4 ++++
>  52 files changed, 65 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/g4x_dp.c b/drivers/gpu/drm/i915/display/g4x_dp.c
> index aa159f9ce12f..a3ff21b2f69f 100644
> --- a/drivers/gpu/drm/i915/display/g4x_dp.c
> +++ b/drivers/gpu/drm/i915/display/g4x_dp.c
> @@ -11,7 +11,6 @@
>  
>  #include "g4x_dp.h"
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_audio.h"
>  #include "intel_backlight.h"
>  #include "intel_connector.h"
> @@ -20,6 +19,7 @@
>  #include "intel_display_power.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_dp_aux.h"
>  #include "intel_dp_link_training.h"
> diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
> index 407deb5dfb57..6e39d7f2e0c2 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_plane.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
> @@ -11,7 +11,6 @@
>  #include <drm/drm_print.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "i9xx_plane.h"
>  #include "i9xx_plane_regs.h"
>  #include "intel_atomic.h"
> @@ -19,6 +18,7 @@
>  #include "intel_display_irq.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_fb.h"
>  #include "intel_fbc.h"
>  #include "intel_frontbuffer.h"
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index 297368ff42a5..70d4c1bc70fc 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -35,7 +35,6 @@
>  #include <drm/drm_probe_helper.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "icl_dsi.h"
>  #include "icl_dsi_regs.h"
>  #include "intel_atomic.h"
> @@ -48,6 +47,7 @@
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
> +#include "intel_display_utils.h"
>  #include "intel_dsi.h"
>  #include "intel_dsi_vbt.h"
>  #include "intel_panel.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 1addd6288241..68c01932f7b4 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -11,10 +11,10 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_acpi.h"
>  #include "intel_display_core.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  
>  #define INTEL_DSM_REVISION_ID 1 /* For Calpella anyway... */
>  #define INTEL_DSM_FN_PLATFORM_MUX_INFO 1 /* No args */
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 3596dce84c28..e2b51fa21d93 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -36,11 +36,11 @@
>  #include "soc/intel_rom.h"
>  
>  #include "i915_drv.h"
> -#include "i915_utils.h"
>  #include "intel_display.h"
>  #include "intel_display_core.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_gmbus.h"
>  
>  #define _INTEL_BIOS_PRIVATE
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 640a40805f18..3033c53e61d1 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -7,7 +7,6 @@
>  
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_bw.h"
>  #include "intel_crtc.h"
>  #include "intel_display_core.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> index e92e7fd9fd13..d4435fe53d8d 100644
> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> @@ -32,7 +32,6 @@
>  #include "hsw_ips.h"
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_audio.h"
>  #include "intel_cdclk.h"
> @@ -41,6 +40,7 @@
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_mchbar_regs.h"
>  #include "intel_pci_config.h"
>  #include "intel_pcode.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> index 51db70d07fae..1e97020e7304 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -24,12 +24,12 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "i9xx_plane_regs.h"
>  #include "intel_color.h"
>  #include "intel_color_regs.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dsb.h"
>  #include "intel_vrr.h"
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> index 112749f97c26..f401558ac14e 100644
> --- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
> @@ -5,12 +5,12 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_combo_phy.h"
>  #include "intel_combo_phy_regs.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  
>  #define for_each_combo_phy(__display, __phy) \
>  	for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++)	\
> diff --git a/drivers/gpu/drm/i915/display/intel_connector.c b/drivers/gpu/drm/i915/display/intel_connector.c
> index 6a55854db5b6..647e6e1f8c68 100644
> --- a/drivers/gpu/drm/i915/display/intel_connector.c
> +++ b/drivers/gpu/drm/i915/display/intel_connector.c
> @@ -31,7 +31,7 @@
>  #include <drm/drm_probe_helper.h>
>  
>  #include "i915_drv.h"
> -#include "i915_utils.h"
> +#include "i915_utils.h" /* for i915_inject_probe_failure() */
>  #include "intel_connector.h"
>  #include "intel_display_core.h"
>  #include "intel_display_debugfs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c
> index c47c84935871..7aa14348aa6d 100644
> --- a/drivers/gpu/drm/i915/display/intel_cursor.c
> +++ b/drivers/gpu/drm/i915/display/intel_cursor.c
> @@ -12,13 +12,13 @@
>  #include <drm/drm_print.h>
>  #include <drm/drm_vblank.h>
>  
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_cursor.h"
>  #include "intel_cursor_regs.h"
>  #include "intel_de.h"
>  #include "intel_display.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_fb.h"
>  #include "intel_fb_pin.h"
>  #include "intel_frontbuffer.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> index a74c1be225ac..f57f6d90a9da 100644
> --- a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
> @@ -8,7 +8,6 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_alpm.h"
>  #include "intel_cx0_phy.h"
>  #include "intel_cx0_phy_regs.h"
> @@ -16,6 +15,7 @@
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_hdmi.h"
>  #include "intel_panel.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index cd9fc3d1f36a..1fac0ac6273b 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -35,7 +35,6 @@
>  #include <drm/drm_privacy_screen_consumer.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "icl_dsi.h"
>  #include "intel_alpm.h"
>  #include "intel_audio.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> index a238be5bc455..629502947222 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> @@ -3,12 +3,12 @@
>   * Copyright © 2020 Intel Corporation
>   */
>  
> -#include "i915_utils.h"
>  #include "intel_cx0_phy.h"
>  #include "intel_ddi.h"
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  
>  /* HDMI/DVI modes ignore everything but the last 2 items. So we share
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 33174fb46ecb..cdeb46d5fd7c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -51,7 +51,6 @@
>  #include "i915_config.h"
>  #include "i915_drv.h"
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "i9xx_plane.h"
>  #include "i9xx_plane_regs.h"
>  #include "i9xx_wm.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
> index 38672d2896e3..eb0727b9a0f6 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_driver.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
> @@ -18,7 +18,7 @@
>  #include <drm/drm_vblank.h>
>  
>  #include "i915_drv.h"
> -#include "i915_utils.h"
> +#include "i915_utils.h" /* for i915_inject_probe_failure() */
>  #include "i9xx_wm.h"
>  #include "intel_acpi.h"
>  #include "intel_atomic.h"
> @@ -35,6 +35,7 @@
>  #include "intel_display_irq.h"
>  #include "intel_display_power.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_display_wa.h"
>  #include "intel_dkl_phy.h"
>  #include "intel_dmc.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index da4babfd6bcb..ebe6225470d0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -11,7 +11,6 @@
>  #include "i915_drv.h"
>  #include "i915_irq.h"
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_backlight_regs.h"
>  #include "intel_cdclk.h"
>  #include "intel_clock_gating.h"
> @@ -23,6 +22,7 @@
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dmc.h"
>  #include "intel_mchbar_regs.h"
>  #include "intel_pch_refclk.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.h b/drivers/gpu/drm/i915/display/intel_display_utils.h
> index af1e34bac720..2a18f160320c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_utils.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.h
> @@ -4,10 +4,24 @@
>  #ifndef __INTEL_DISPLAY_UTILS__
>  #define __INTEL_DISPLAY_UTILS__
>  
> +#include <linux/bug.h>
>  #include <linux/types.h>
>  
>  struct intel_display;
>  
> +#ifndef MISSING_CASE
> +#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
> +			     __stringify(x), (long)(x))
> +#endif
> +
> +#ifndef fetch_and_zero
> +#define fetch_and_zero(ptr) ({						\
> +	typeof(*ptr) __T = *(ptr);					\
> +	*(ptr) = (typeof(*ptr))0;					\
> +	__T;								\
> +})
> +#endif
> +
>  #define KHz(x) (1000 * (x))
>  #define MHz(x) KHz(1000 * (x))
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index be6d37ea1139..22f74974a79e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -30,13 +30,13 @@
>  #include <drm/drm_print.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_power_well.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dmc.h"
>  #include "intel_dmc_regs.h"
>  #include "intel_flipq.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 78e21bfd29bd..b0d9631bfb0a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -51,7 +51,6 @@
>  #include <drm/drm_probe_helper.h>
>  
>  #include "g4x_dp.h"
> -#include "i915_utils.h"
>  #include "intel_alpm.h"
>  #include "intel_atomic.h"
>  #include "intel_audio.h"
> @@ -65,6 +64,7 @@
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
>  #include "intel_display_jiffies.h"
> +#include "intel_display_utils.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index 829a7c0fbe4f..2e7dbaf511b9 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -5,9 +5,9 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_dp_aux.h"
>  #include "intel_dp_aux_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index 316b42b5a946..aad5fe14962f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -27,10 +27,10 @@
>  #include <drm/display/drm_dp_helper.h>
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_display_core.h"
>  #include "intel_display_jiffies.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_dp_link_training.h"
>  #include "intel_encoder.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dpio_phy.c b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> index 3f77ad92c156..5df6347a420d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpio_phy.c
> @@ -24,13 +24,13 @@
>  #include <drm/drm_print.h>
>  
>  #include "bxt_dpio_phy_regs.h"
> -#include "i915_utils.h"
>  #include "intel_ddi.h"
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
>  #include "intel_display_power_well.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_dpio_phy.h"
>  #include "vlv_dpio_phy_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 900a945ff8ab..92c433f7b7e2 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -27,7 +27,6 @@
>  #include <drm/drm_print.h>
>  
>  #include "bxt_dpio_phy_regs.h"
> -#include "i915_utils.h"
>  #include "intel_cx0_phy.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> index 23402408e172..35ccf6a528fb 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
> @@ -38,10 +38,10 @@
>  #include <drm/drm_print.h>
>  #include <video/mipi_display.h>
>  
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dsi.h"
>  #include "intel_dsi_vbt.h"
>  #include "intel_gmbus_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dvo.c b/drivers/gpu/drm/i915/display/intel_dvo.c
> index 08b48e36aca6..c2663d6e2c92 100644
> --- a/drivers/gpu/drm/i915/display/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_dvo.c
> @@ -34,12 +34,12 @@
>  #include <drm/drm_print.h>
>  #include <drm/drm_probe_helper.h>
>  
> -#include "i915_utils.h"
>  #include "intel_connector.h"
>  #include "intel_de.h"
>  #include "intel_display_driver.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dvo.h"
>  #include "intel_dvo_dev.h"
>  #include "intel_dvo_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 3958628c73e9..ada4fdda70bb 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -11,11 +11,11 @@
>  #include <drm/drm_modeset_helper.h>
>  
>  #include "i915_drv.h"
> -#include "i915_utils.h"
>  #include "intel_bo.h"
>  #include "intel_display.h"
>  #include "intel_display_core.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dpt.h"
>  #include "intel_fb.h"
>  #include "intel_fb_bo.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 6f2cc01ea4a0..6e5cf522ef5b 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -49,7 +49,6 @@
>  #include "gt/intel_gt_types.h"
>  
>  #include "i915_drv.h"
> -#include "i915_utils.h"
>  #include "i915_vgpu.h"
>  #include "i915_vma.h"
>  #include "i9xx_plane_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c
> index 59a36b3a22c1..5bb0090dd5ed 100644
> --- a/drivers/gpu/drm/i915/display/intel_fdi.c
> +++ b/drivers/gpu/drm/i915/display/intel_fdi.c
> @@ -9,13 +9,13 @@
>  #include <drm/drm_print.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_crtc.h"
>  #include "intel_ddi.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_fdi.h"
>  #include "intel_fdi_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_flipq.c b/drivers/gpu/drm/i915/display/intel_flipq.c
> index 6ab2272ab2df..f162614a925d 100644
> --- a/drivers/gpu/drm/i915/display/intel_flipq.c
> +++ b/drivers/gpu/drm/i915/display/intel_flipq.c
> @@ -7,16 +7,16 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
> -#include "intel_step.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_core.h"
>  #include "intel_display_types.h"
> -#include "intel_flipq.h"
> +#include "intel_display_utils.h"
>  #include "intel_dmc.h"
>  #include "intel_dmc_regs.h"
>  #include "intel_dsb.h"
> +#include "intel_flipq.h"
> +#include "intel_step.h"
>  #include "intel_vblank.h"
>  #include "intel_vrr.h"
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 0f624004104f..7195e8cf671c 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -19,7 +19,6 @@
>  #include <drm/intel/i915_component.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_connector.h"
>  #include "intel_de.h"
>  #include "intel_display_jiffies.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> index 6a22862d6be1..17aa5e0cd51a 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc.c
> @@ -9,7 +9,6 @@
>  #include "gt/intel_gt.h"
>  #include "gt/uc/intel_gsc_uc_heci_cmd_submit.h"
>  #include "i915_drv.h"
> -#include "i915_utils.h"
>  #include "intel_hdcp_gsc.h"
>  
>  struct intel_hdcp_gsc_context {
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 4ab7e2e3bfd4..0acf2f63ada4 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -45,7 +45,6 @@
>  #include <media/cec-notifier.h>
>  
>  #include "g4x_hdmi.h"
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_audio.h"
>  #include "intel_connector.h"
> @@ -55,6 +54,7 @@
>  #include "intel_display_driver.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_gmbus.h"
>  #include "intel_hdcp.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
> index 4451a792600a..3e508bb9ecdd 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> @@ -28,12 +28,12 @@
>  
>  #include "i915_drv.h"
>  #include "i915_irq.h"
> -#include "i915_utils.h"
>  #include "intel_connector.h"
> -#include "intel_display_power.h"
>  #include "intel_display_core.h"
> +#include "intel_display_power.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_hdcp.h"
>  #include "intel_hotplug.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
> index 9a4da818ad61..46c47b3d6f42 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug_irq.c
> @@ -6,11 +6,11 @@
>  #include <drm/drm_print.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp_aux.h"
>  #include "intel_gmbus.h"
>  #include "intel_hotplug.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index d56026c4efdd..9ceabbc981a1 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -31,10 +31,10 @@
>  #include <drm/drm_edid.h>
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_hdmi.h"
>  #include "intel_lspcon.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pch_refclk.c b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> index 9ae53679a041..cca880c7eed4 100644
> --- a/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> +++ b/drivers/gpu/drm/i915/display/intel_pch_refclk.c
> @@ -6,10 +6,10 @@
>  #include <drm/drm_print.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_panel.h"
>  #include "intel_pch_refclk.h"
>  #include "intel_sbi.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pfit.c b/drivers/gpu/drm/i915/display/intel_pfit.c
> index 68539e7c2a24..6dda496190e0 100644
> --- a/drivers/gpu/drm/i915/display/intel_pfit.c
> +++ b/drivers/gpu/drm/i915/display/intel_pfit.c
> @@ -5,12 +5,12 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_core.h"
>  #include "intel_display_driver.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_lvds_regs.h"
>  #include "intel_pfit.h"
>  #include "intel_pfit_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pmdemand.c b/drivers/gpu/drm/i915/display/intel_pmdemand.c
> index 7ade35e05eb5..f52abd4e2eb0 100644
> --- a/drivers/gpu/drm/i915/display/intel_pmdemand.c
> +++ b/drivers/gpu/drm/i915/display/intel_pmdemand.c
> @@ -7,7 +7,6 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_bw.h"
>  #include "intel_cdclk.h"
> @@ -15,6 +14,7 @@
>  #include "intel_display_jiffies.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_trace.h"
> +#include "intel_display_utils.h"
>  #include "intel_pmdemand.h"
>  #include "intel_step.h"
>  #include "skl_watermark.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 0c2f48626d0c..25692a547764 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -10,12 +10,12 @@
>  
>  #include "g4x_dp.h"
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_jiffies.h"
>  #include "intel_display_power_well.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_dpio_phy.h"
>  #include "intel_dpll.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index cfc8b04f98fa..0ca2b06d18b5 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -29,7 +29,6 @@
>  #include <drm/drm_vblank.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_alpm.h"
>  #include "intel_atomic.h"
>  #include "intel_crtc.h"
> @@ -40,6 +39,7 @@
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dmc.h"
>  #include "intel_dp.h"
>  #include "intel_dp_aux.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_qp_tables.c b/drivers/gpu/drm/i915/display/intel_qp_tables.c
> index 600c815e37e4..c05d4beb91d8 100644
> --- a/drivers/gpu/drm/i915/display/intel_qp_tables.c
> +++ b/drivers/gpu/drm/i915/display/intel_qp_tables.c
> @@ -5,7 +5,7 @@
>  
>  #include <drm/display/drm_dsc.h>
>  
> -#include "i915_utils.h"
> +#include "intel_display_utils.h"
>  #include "intel_qp_tables.h"
>  
>  /* from BPP 6 to 24 in steps of 0.5 */
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> index b2dd69a11124..4f028e6a91cd 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
> @@ -7,12 +7,12 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_ddi.h"
>  #include "intel_ddi_buf_trans.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_snps_hdmi_pll.h"
>  #include "intel_snps_phy.h"
>  #include "intel_snps_phy_regs.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index 75bbaa923204..60f1d9ed181e 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -39,10 +39,10 @@
>  #include <drm/drm_print.h>
>  #include <drm/drm_rect.h>
>  
> -#include "i915_utils.h"
>  #include "i9xx_plane.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_fb.h"
>  #include "intel_frontbuffer.h"
>  #include "intel_plane.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index c4a5601c5107..f1ed50be3247 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -8,7 +8,6 @@
>  #include <drm/drm_print.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_cx0_phy_regs.h"
>  #include "intel_ddi.h"
> @@ -18,6 +17,7 @@
>  #include "intel_display_power_map.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dkl_phy_regs.h"
>  #include "intel_dp.h"
>  #include "intel_dp_mst.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_vblank.c b/drivers/gpu/drm/i915/display/intel_vblank.c
> index 0e534be375ca..8aa427a93964 100644
> --- a/drivers/gpu/drm/i915/display/intel_vblank.c
> +++ b/drivers/gpu/drm/i915/display/intel_vblank.c
> @@ -8,13 +8,13 @@
>  #include <drm/drm_vblank.h>
>  
>  #include "i915_drv.h"
> -#include "i915_utils.h"
>  #include "intel_color.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_jiffies.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_vblank.h"
>  #include "intel_vrr.h"
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index dbf2cf1b896d..0e727fc5e80c 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -11,10 +11,10 @@
>  #include <drm/drm_fixed.h>
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_crtc.h"
>  #include "intel_de.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dp.h"
>  #include "intel_dsi.h"
>  #include "intel_qp_tables.h"
> diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
> index d29efcbf2319..2956b110c3b7 100644
> --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> @@ -5,11 +5,11 @@
>  
>  #include <drm/drm_print.h>
>  
> -#include "i915_utils.h"
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_trace.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_display_wa.h"
>  #include "intel_fb.h"
>  #include "skl_scaler.h"
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 0319174adf95..b6fdba88752b 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -10,12 +10,12 @@
>  
>  #include "pxp/intel_pxp.h"
>  #include "i915_drv.h"
> -#include "i915_utils.h"
>  #include "intel_bo.h"
>  #include "intel_de.h"
>  #include "intel_display_irq.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dpt.h"
>  #include "intel_fb.h"
>  #include "intel_fbc.h"
> diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
> index 256162da9afc..6d050408618c 100644
> --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> @@ -10,7 +10,6 @@
>  
>  #include "soc/intel_dram.h"
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "i9xx_wm.h"
>  #include "intel_atomic.h"
>  #include "intel_bw.h"
> @@ -23,6 +22,7 @@
>  #include "intel_display_regs.h"
>  #include "intel_display_rpm.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_fb.h"
>  #include "intel_fixed.h"
>  #include "intel_flipq.h"
> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
> index c9a53fde79c4..444682995658 100644
> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c
> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
> @@ -34,7 +34,6 @@
>  #include <drm/drm_probe_helper.h>
>  
>  #include "i915_reg.h"
> -#include "i915_utils.h"
>  #include "intel_atomic.h"
>  #include "intel_backlight.h"
>  #include "intel_connector.h"
> @@ -42,6 +41,7 @@
>  #include "intel_de.h"
>  #include "intel_display_regs.h"
>  #include "intel_display_types.h"
> +#include "intel_display_utils.h"
>  #include "intel_dsi.h"
>  #include "intel_dsi_vbt.h"
>  #include "intel_fifo_underrun.h"
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index c1f978a7c141..4f75115b87d6 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -38,8 +38,10 @@
>  
>  struct drm_i915_private;
>  
> +#ifndef MISSING_CASE
>  #define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
>  			     __stringify(x), (long)(x))
> +#endif
>  
>  #if IS_ENABLED(CONFIG_DRM_I915_DEBUG)
>  
> @@ -65,11 +67,13 @@ bool i915_error_injected(void);
>  		drm_err(&(i915)->drm, fmt, ##__VA_ARGS__); \
>  })
>  
> +#ifndef fetch_and_zero
>  #define fetch_and_zero(ptr) ({						\
>  	typeof(*ptr) __T = *(ptr);					\
>  	*(ptr) = (typeof(*ptr))0;					\
>  	__T;								\
>  })
> +#endif
>  
>  /*
>   * check_user_mbz: Check that a user value exists and is zero

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] drm/xe/compat: reduce i915_utils.[ch]
  2025-10-22 15:17 ` [PATCH 6/6] drm/xe/compat: reduce i915_utils.[ch] Jani Nikula
@ 2025-10-30  8:04   ` Luca Coelho
  0 siblings, 0 replies; 23+ messages in thread
From: Luca Coelho @ 2025-10-30  8:04 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> Reduce the compat i915_utils.h to only cover the requirements of
> MISSING_CASE() in soc/ and the few i915_inject_probe_failure()
> instances, instead of including the entire i915_utils.h from i915. This
> prevents new users for the utilities from cropping up.
> 
> With this, we can remove the xe/display/ext/i915_utils.c altogether.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.


>  drivers/gpu/drm/xe/Makefile                     |  1 -
>  .../gpu/drm/xe/compat-i915-headers/i915_utils.h |  9 ++++++++-
>  drivers/gpu/drm/xe/display/ext/i915_utils.c     | 17 -----------------
>  3 files changed, 8 insertions(+), 19 deletions(-)
>  delete mode 100644 drivers/gpu/drm/xe/display/ext/i915_utils.c
> 
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index feb8225d4d79..a7bcc3948a31 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -205,7 +205,6 @@ $(obj)/i915-display/%.o: $(srctree)/drivers/gpu/drm/i915/display/%.c FORCE
>  # Display code specific to xe
>  xe-$(CONFIG_DRM_XE_DISPLAY) += \
>  	display/ext/i915_irq.o \
> -	display/ext/i915_utils.o \
>  	display/intel_bo.o \
>  	display/intel_fb_bo.o \
>  	display/intel_fbdev_fb.o \
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h
> index 1d7c4360e5c0..bcd441dc0fce 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_utils.h
> @@ -3,4 +3,11 @@
>   * Copyright © 2023 Intel Corporation
>   */
>  
> -#include "../../i915/i915_utils.h"
> +/* for soc/ */
> +#ifndef MISSING_CASE
> +#define MISSING_CASE(x) WARN(1, "Missing case (%s == %ld)\n", \
> +			     __stringify(x), (long)(x))
> +#endif
> +
> +/* for a couple of users under i915/display */
> +#define i915_inject_probe_failure(unused) ((unused) && 0)
> diff --git a/drivers/gpu/drm/xe/display/ext/i915_utils.c b/drivers/gpu/drm/xe/display/ext/i915_utils.c
> deleted file mode 100644
> index af9ec2abbaa1..000000000000
> --- a/drivers/gpu/drm/xe/display/ext/i915_utils.c
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -// SPDX-License-Identifier: MIT
> -/*
> - * Copyright © 2023 Intel Corporation
> - */
> -
> -#include "i915_utils.h"
> -
> -#if IS_ENABLED(CONFIG_DRM_I915_DEBUG)
> -
> -/* i915 specific, just put here for shutting it up */
> -int __i915_inject_probe_error(struct drm_i915_private *i915, int err,
> -			      const char *func, int line)
> -{
> -	return 0;
> -}
> -
> -#endif

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest()
  2025-10-30  7:57   ` Luca Coelho
@ 2025-10-30  8:48     ` Jani Nikula
  2025-10-30 12:14       ` Luca Coelho
  0 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-30  8:48 UTC (permalink / raw)
  To: Luca Coelho, intel-gfx, intel-xe

On Thu, 30 Oct 2025, Luca Coelho <luca@coelho.fi> wrote:
> On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
>> Add intel_display_utils.c for display utilities that need more than a
>> header.
>> 
>> Start off with intel_display_run_as_guest(). The implementation is
>> intentional duplication of the i915_utils.h i915_run_as_guest(), with
>> the idea that it's small enough to not matter.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>
>
>
>>  drivers/gpu/drm/i915/Makefile                  |  1 +
>>  .../gpu/drm/i915/display/intel_display_utils.c | 18 ++++++++++++++++++
>>  .../gpu/drm/i915/display/intel_display_utils.h |  6 ++++++
>>  drivers/gpu/drm/i915/display/intel_pch.c       |  4 ++--
>>  drivers/gpu/drm/xe/Makefile                    |  1 +
>>  5 files changed, 28 insertions(+), 2 deletions(-)
>>  create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.c
>> 
>> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
>> index 47bac9b2c611..046f9282fb65 100644
>> --- a/drivers/gpu/drm/i915/Makefile
>> +++ b/drivers/gpu/drm/i915/Makefile
>> @@ -255,6 +255,7 @@ i915-y += \
>>  	display/intel_display_rpm.o \
>>  	display/intel_display_rps.o \
>>  	display/intel_display_snapshot.o \
>> +	display/intel_display_utils.o \
>>  	display/intel_display_wa.o \
>>  	display/intel_dmc.o \
>>  	display/intel_dmc_wl.o \
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
>> new file mode 100644
>> index 000000000000..13d3999dd580
>> --- /dev/null
>> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
>> @@ -0,0 +1,18 @@
>> +// SPDX-License-Identifier: MIT
>> +/* Copyright © 2025 Intel Corporation */
>> +
>> +#ifdef CONFIG_X86
>> +#include <asm/hypervisor.h>
>> +#endif
>> +
>> +#include "intel_display_utils.h"
>> +
>> +bool intel_display_run_as_guest(struct intel_display *display)
>> +{
>> +#if IS_ENABLED(CONFIG_X86)
>> +	return !hypervisor_is_type(X86_HYPER_NATIVE);
>> +#else
>> +	/* Not supported yet */
>> +	return false;
>> +#endif
>> +}
>
> Why can't this be an inline in the header file?

I'll turn it around. I think there needs to be a rationale for inlining,
not the other way around. A regular function should be the default.

I think the primary reason for inlining would be performance, but I'll
accept small "superfluous" static inlines that don't require pulling in
other headers.

I don't think either is true here.

Additionally the static inline exposes all of that ifdef mess and the
implementation details in the header too. A change in asm/hypervisor.h
leads to a rebuild of everything that includes intel_display_utils.h,
making the header dependencies worse. (Maybe a change in
asm/hypervisor.h leads to a rebuild of everything anyway, but you get
the general point.)


BR,
Jani.


-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 4/6] drm/i915/display: add intel_display_vtd_active()
  2025-10-30  8:00   ` Luca Coelho
@ 2025-10-30  8:50     ` Jani Nikula
  2025-10-30 12:16       ` Luca Coelho
  0 siblings, 1 reply; 23+ messages in thread
From: Jani Nikula @ 2025-10-30  8:50 UTC (permalink / raw)
  To: Luca Coelho, intel-gfx, intel-xe

On Thu, 30 Oct 2025, Luca Coelho <luca@coelho.fi> wrote:
> On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
>> index 13d3999dd580..04d010f7c23e 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_utils.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
>> @@ -1,10 +1,15 @@
>>  // SPDX-License-Identifier: MIT
>>  /* Copyright © 2025 Intel Corporation */
>>  
>> +#include <linux/device.h>
>> +
>> +#include <drm/drm_device.h>
>> +
>>  #ifdef CONFIG_X86
>>  #include <asm/hypervisor.h>
>>  #endif
>>  
>> +#include "intel_display_core.h"
>>  #include "intel_display_utils.h"
>>  
>>  bool intel_display_run_as_guest(struct intel_display *display)
>> @@ -16,3 +21,12 @@ bool intel_display_run_as_guest(struct intel_display *display)
>>  	return false;
>>  #endif
>>  }
>> +
>> +bool intel_display_vtd_active(struct intel_display *display)
>> +{
>> +	if (device_iommu_mapped(display->drm->dev))
>> +		return true;
>> +
>> +	/* Running as a guest, we assume the host is enforcing VT'd */
>> +	return intel_display_run_as_guest(display);
>> +}
>
> This also looks quite much like an "inlineable" function, no?

Same reason as before, and that display->drm->dev dereference would
require pulling in both intel_display_core.h and drm/drm_device.h in the
header.

BR,
Jani.


-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest()
  2025-10-30  8:48     ` Jani Nikula
@ 2025-10-30 12:14       ` Luca Coelho
  2025-10-31 11:26         ` Jani Nikula
  0 siblings, 1 reply; 23+ messages in thread
From: Luca Coelho @ 2025-10-30 12:14 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Thu, 2025-10-30 at 10:48 +0200, Jani Nikula wrote:
> On Thu, 30 Oct 2025, Luca Coelho <luca@coelho.fi> wrote:
> > On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> > > Add intel_display_utils.c for display utilities that need more than a
> > > header.
> > > 
> > > Start off with intel_display_run_as_guest(). The implementation is
> > > intentional duplication of the i915_utils.h i915_run_as_guest(), with
> > > the idea that it's small enough to not matter.
> > > 
> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > > ---
> > 
> > 
> > 
> > >  drivers/gpu/drm/i915/Makefile                  |  1 +
> > >  .../gpu/drm/i915/display/intel_display_utils.c | 18 ++++++++++++++++++
> > >  .../gpu/drm/i915/display/intel_display_utils.h |  6 ++++++
> > >  drivers/gpu/drm/i915/display/intel_pch.c       |  4 ++--
> > >  drivers/gpu/drm/xe/Makefile                    |  1 +
> > >  5 files changed, 28 insertions(+), 2 deletions(-)
> > >  create mode 100644 drivers/gpu/drm/i915/display/intel_display_utils.c
> > > 
> > > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> > > index 47bac9b2c611..046f9282fb65 100644
> > > --- a/drivers/gpu/drm/i915/Makefile
> > > +++ b/drivers/gpu/drm/i915/Makefile
> > > @@ -255,6 +255,7 @@ i915-y += \
> > >  	display/intel_display_rpm.o \
> > >  	display/intel_display_rps.o \
> > >  	display/intel_display_snapshot.o \
> > > +	display/intel_display_utils.o \
> > >  	display/intel_display_wa.o \
> > >  	display/intel_dmc.o \
> > >  	display/intel_dmc_wl.o \
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
> > > new file mode 100644
> > > index 000000000000..13d3999dd580
> > > --- /dev/null
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
> > > @@ -0,0 +1,18 @@
> > > +// SPDX-License-Identifier: MIT
> > > +/* Copyright © 2025 Intel Corporation */
> > > +
> > > +#ifdef CONFIG_X86
> > > +#include <asm/hypervisor.h>
> > > +#endif
> > > +
> > > +#include "intel_display_utils.h"
> > > +
> > > +bool intel_display_run_as_guest(struct intel_display *display)
> > > +{
> > > +#if IS_ENABLED(CONFIG_X86)
> > > +	return !hypervisor_is_type(X86_HYPER_NATIVE);
> > > +#else
> > > +	/* Not supported yet */
> > > +	return false;
> > > +#endif
> > > +}
> > 
> > Why can't this be an inline in the header file?
> 
> I'll turn it around. I think there needs to be a rationale for inlining,
> not the other way around. A regular function should be the default.
> 
> I think the primary reason for inlining would be performance, but I'll
> accept small "superfluous" static inlines that don't require pulling in
> other headers.
> 
> I don't think either is true here.
> 
> Additionally the static inline exposes all of that ifdef mess and the
> implementation details in the header too. A change in asm/hypervisor.h
> leads to a rebuild of everything that includes intel_display_utils.h,
> making the header dependencies worse. (Maybe a change in
> asm/hypervisor.h leads to a rebuild of everything anyway, but you get
> the general point.)

Arguable but fair points, thanks.

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 4/6] drm/i915/display: add intel_display_vtd_active()
  2025-10-30  8:50     ` Jani Nikula
@ 2025-10-30 12:16       ` Luca Coelho
  0 siblings, 0 replies; 23+ messages in thread
From: Luca Coelho @ 2025-10-30 12:16 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe

On Thu, 2025-10-30 at 10:50 +0200, Jani Nikula wrote:
> On Thu, 30 Oct 2025, Luca Coelho <luca@coelho.fi> wrote:
> > On Wed, 2025-10-22 at 18:17 +0300, Jani Nikula wrote:
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_utils.c b/drivers/gpu/drm/i915/display/intel_display_utils.c
> > > index 13d3999dd580..04d010f7c23e 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display_utils.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_utils.c
> > > @@ -1,10 +1,15 @@
> > >  // SPDX-License-Identifier: MIT
> > >  /* Copyright © 2025 Intel Corporation */
> > >  
> > > +#include <linux/device.h>
> > > +
> > > +#include <drm/drm_device.h>
> > > +
> > >  #ifdef CONFIG_X86
> > >  #include <asm/hypervisor.h>
> > >  #endif
> > >  
> > > +#include "intel_display_core.h"
> > >  #include "intel_display_utils.h"
> > >  
> > >  bool intel_display_run_as_guest(struct intel_display *display)
> > > @@ -16,3 +21,12 @@ bool intel_display_run_as_guest(struct intel_display *display)
> > >  	return false;
> > >  #endif
> > >  }
> > > +
> > > +bool intel_display_vtd_active(struct intel_display *display)
> > > +{
> > > +	if (device_iommu_mapped(display->drm->dev))
> > > +		return true;
> > > +
> > > +	/* Running as a guest, we assume the host is enforcing VT'd */
> > > +	return intel_display_run_as_guest(display);
> > > +}
> > 
> > This also looks quite much like an "inlineable" function, no?
> 
> Same reason as before, and that display->drm->dev dereference would
> require pulling in both intel_display_core.h and drm/drm_device.h in the
> header.

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

--
Cheers,
Luca.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest()
  2025-10-30 12:14       ` Luca Coelho
@ 2025-10-31 11:26         ` Jani Nikula
  0 siblings, 0 replies; 23+ messages in thread
From: Jani Nikula @ 2025-10-31 11:26 UTC (permalink / raw)
  To: Luca Coelho, intel-gfx, intel-xe

On Thu, 30 Oct 2025, Luca Coelho <luca@coelho.fi> wrote:
> Arguable but fair points, thanks.
>
> Reviewed-by: Luca Coelho <luciano.coelho@intel.com>

Thanks a lot, pushed the series to din.

BR,
Jani.


-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2025-10-31 11:26 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-22 15:17 [PATCH 0/6] drm/i915: i915_utils.h refactoring Jani Nikula
2025-10-22 15:17 ` [PATCH 1/6] drm/i915: split out separate files for jiffies timeout and wait helpers Jani Nikula
2025-10-30  7:53   ` Luca Coelho
2025-10-22 15:17 ` [PATCH 2/6] drm/i915/display: create intel_display_utils.h Jani Nikula
2025-10-30  7:51   ` Luca Coelho
2025-10-22 15:17 ` [PATCH 3/6] drm/i915/display: add intel_display_run_as_guest() Jani Nikula
2025-10-30  7:57   ` Luca Coelho
2025-10-30  8:48     ` Jani Nikula
2025-10-30 12:14       ` Luca Coelho
2025-10-31 11:26         ` Jani Nikula
2025-10-22 15:17 ` [PATCH 4/6] drm/i915/display: add intel_display_vtd_active() Jani Nikula
2025-10-30  8:00   ` Luca Coelho
2025-10-30  8:50     ` Jani Nikula
2025-10-30 12:16       ` Luca Coelho
2025-10-22 15:17 ` [PATCH 5/6] drm/i915/display: switch to intel_display_utils.h Jani Nikula
2025-10-30  8:03   ` Luca Coelho
2025-10-22 15:17 ` [PATCH 6/6] drm/xe/compat: reduce i915_utils.[ch] Jani Nikula
2025-10-30  8:04   ` Luca Coelho
2025-10-22 21:46 ` ✗ CI.checkpatch: warning for drm/i915: i915_utils.h refactoring Patchwork
2025-10-22 21:47 ` ✓ CI.KUnit: success " Patchwork
2025-10-22 22:03 ` ✗ CI.checksparse: warning " Patchwork
2025-10-22 22:28 ` ✓ Xe.CI.BAT: success " Patchwork
2025-10-23  3:07 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).