Re: [PATCH 01/12] drm/i915/fb: Nuke intel_tile_row_size()

Jani Nikula
2026-04-08T08:43:01Z

On Tue, 07 Apr 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_tile_row_size() is unused. Nuke it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 9 ---------
> drivers/gpu/drm/i915/display/intel_fb.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 5768619f840f..83392c1a1ebe 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -876,15 +876,6 @@ static void intel_tile_block_dims(const struct drm_framebuffer *fb, int color_pl
> *tile_height = 1;
> }
>
> -unsigned int intel_tile_row_size(const struct drm_framebuffer *fb, int color_plane)
> -{
> - unsigned int tile_width, tile_height;
> -
> - intel_tile_dims(fb, color_plane, &tile_width, &tile_height);
> -
> - return fb->pitches[color_plane] * tile_height;
> -}
> -
> unsigned int
> intel_fb_align_height(const struct drm_framebuffer *fb,
> int color_plane, unsigned int height)
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.h b/drivers/gpu/drm/i915/display/intel_fb.h
> index 22514d5f2bb6..fb1ec2a1e905 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.h
> +++ b/drivers/gpu/drm/i915/display/intel_fb.h
> @@ -62,7 +62,6 @@ int skl_main_to_aux_plane(const struct drm_framebuffer *fb, int main_plane);
> unsigned int intel_tile_size(struct intel_display *display);
> unsigned int intel_tile_width_bytes(const struct drm_framebuffer *fb, int color_plane);
> unsigned int intel_tile_height(const struct drm_framebuffer *fb, int color_plane);
> -unsigned int intel_tile_row_size(const struct drm_framebuffer *fb, int color_plane);
> unsigned int intel_fb_align_height(const struct drm_framebuffer *fb,
> int color_plane, unsigned int height);

--
Jani Nikula, Intel