Re: [PATCH 09/12] drm/i915/fb: Use i915_gtt_view_is_*()

Jani Nikula
2026-04-08T08:53:20Z

On Tue, 07 Apr 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Replace the naked GTT view type checks with the new
> i915_gtt_view_is_*() helpers. This isolates some of
> the code from GTT view implementation details.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 52a619088e8e..ceed695d3ad4 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -1284,7 +1284,7 @@ bool intel_plane_uses_fence(const struct intel_plane_state *plane_state)
>
> return DISPLAY_VER(display) < 4 ||
> (plane->fbc && !plane_state->no_fbc_reason &&
> - plane_state->view.gtt.type == I915_GTT_VIEW_NORMAL);
> + i915_gtt_view_is_normal(&plane_state->view.gtt));
> }
>
> static int intel_fb_pitch(const struct intel_framebuffer *fb, int color_plane, unsigned int rotation)
> @@ -1506,7 +1506,7 @@ static u32 calc_plane_remap_info(const struct intel_framebuffer *fb, int color_p
> plane_view_height_tiles(fb, color_plane, dims, y));
> }
>
> - if (view->gtt.type == I915_GTT_VIEW_ROTATED) {
> + if (i915_gtt_view_is_rotated(&view->gtt)) {
> drm_WARN_ON(display->drm, remap_info->linear);
> check_array_bounds(display, view->gtt.rotated.plane, color_plane);
>
> @@ -1531,7 +1531,7 @@ static u32 calc_plane_remap_info(const struct intel_framebuffer *fb, int color_p
> /* rotate the tile dimensions to match the GTT view */
> swap(tile_width, tile_height);
> } else {
> - drm_WARN_ON(display->drm, view->gtt.type != I915_GTT_VIEW_REMAPPED);
> + drm_WARN_ON(display->drm, !i915_gtt_view_is_remapped(&view->gtt));
>
> check_array_bounds(display, view->gtt.remapped.plane, color_plane);
>
> @@ -1632,7 +1632,7 @@ static void intel_fb_view_init(struct intel_display *display,
> memset(view, 0, sizeof(*view));
> view->gtt.type = view_type;
>
> - if (view_type == I915_GTT_VIEW_REMAPPED &&
> + if (i915_gtt_view_is_remapped(&view->gtt) &&
> (display->platform.alderlake_p || DISPLAY_VER(display) >= 14))
> view->gtt.remapped.plane_alignment = SZ_2M / PAGE_SIZE;
> }

--
Jani Nikula, Intel