Re: [PATCH 02/12] drm/i915/fb: Make intel_fb_needs_pot_stride_remap() static

Jani Nikula
2026-04-08T08:43:19Z

On Tue, 07 Apr 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> intel_fb_needs_pot_stride_remap() isn't needed outside intel_fb.c.
> Make it static.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
> drivers/gpu/drm/i915/display/intel_fb.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 83392c1a1ebe..4b0afea1c456 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -1265,7 +1265,7 @@ static bool intel_plane_can_remap(const struct intel_plane_state *plane_state)
> return true;
> }
>
> -bool intel_fb_needs_pot_stride_remap(const struct intel_framebuffer *fb)
> +static bool intel_fb_needs_pot_stride_remap(const struct intel_framebuffer *fb)
> {
> struct intel_display *display = to_intel_display(fb->base.dev);
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.h b/drivers/gpu/drm/i915/display/intel_fb.h
> index fb1ec2a1e905..fc2c4d59bf06 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.h
> +++ b/drivers/gpu/drm/i915/display/intel_fb.h
> @@ -77,7 +77,6 @@ u32 intel_plane_compute_aligned_offset(int *x, int *y,
> const struct intel_plane_state *plane_state,
> int color_plane);
>
> -bool intel_fb_needs_pot_stride_remap(const struct intel_framebuffer *fb);
> bool intel_plane_uses_fence(const struct intel_plane_state *plane_state);
> bool intel_fb_supports_90_270_rotation(const struct intel_framebuffer *fb);

--
Jani Nikula, Intel