Re: [PATCH 04/12] drm/xe/fb: Use the correct gtt view for remapped FBs

Jani Nikula
2026-04-08T08:44:51Z

On Tue, 07 Apr 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use the proper gtt view from the plane state rather than always
> assuming that it came directly from the FB. This is in the DPT
> codepath so the view should currently always come from the FB,
> but in the future we may also want per-plane remapping with DPT.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Cc: Maarten, does it look sane to you too?

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/xe/display/xe_fb_pin.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index e45a1e7a4670..35e5c322f8b0 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -154,7 +154,7 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,
> if (view->type == I915_GTT_VIEW_NORMAL)
> dpt_size = ALIGN(size / XE_PAGE_SIZE * 8, XE_PAGE_SIZE);
> else if (view->type == I915_GTT_VIEW_REMAPPED)
> - dpt_size = ALIGN(intel_remapped_info_size(&fb->remapped_view.gtt.remapped) * 8,
> + dpt_size = ALIGN(intel_remapped_info_size(&view->remapped) * 8,
> XE_PAGE_SIZE);
> else
> /* display uses 4K tiles instead of bytes here, convert to entries.. */

--
Jani Nikula, Intel