Re: [PATCH 00/12] drm/i915/fb: Prep work for more generic remapping support

Ville Syrjälä
2026-04-10T11:25:07Z

On Tue, Apr 07, 2026 at 06:50:41PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I had a quick look at implementing tile64/Ys support.
> https://github.com/vsyrjala/linux.git remap_tile_ys_64
> is the result.
>
> I think I want the whole generic remap thing from there
> even if we don't end up adding the actual tile64/Ys support.
> So here is an extract of some prep work from that branch,
> though I didn't include the generic remap thing itself yet.
>
> Ville Syrjälä (12):
> drm/i915/fb: Nuke intel_tile_row_size()
> drm/i915/fb: Make intel_fb_needs_pot_stride_remap() static
> drm/i915/fb: Reject per-plane remapping with DPT
> drm/i915/vma: Add helpers to check GTT view type
> drm/i915/fb: Use i915_gtt_view_is_*()
> drm/i915/fb: Use intel_fb_needs_pot_stride_remap() in
> intel_fb_view_init()

I merged all those to get intel_fb.c into shape.

> drm/xe/fb: Use the correct gtt view for remapped FBs
> drm/xe/fb: Remove weird VMA end alignemnt
> drm/xe/fb: Extract xe_dpt_size()
> drm/xe/fb: Use i915_gtt_view_is_*()

Left out the xe specific stuff for now to see if Maarten/others
have any comments.

> drm/i915/selftests: Eliminate duplicate vma size check
> drm/i915/selftests: Use i915_gtt_view_is_*()

And I need to take another look at the selftests.

Thanks for the reviews.

>
> drivers/gpu/drm/i915/display/intel_fb.c | 42 ++++++++++-----------
> drivers/gpu/drm/i915/display/intel_fb.h | 2 -
> drivers/gpu/drm/i915/i915_gtt_view_types.h | 15 ++++++++
> drivers/gpu/drm/i915/selftests/i915_vma.c | 33 ++++++-----------
> drivers/gpu/drm/xe/display/xe_fb_pin.c | 43 ++++++++++++----------
> 5 files changed, 72 insertions(+), 63 deletions(-)
>
> --
> 2.52.0

--
Ville Syrjälä
Intel