Re: [PATCH 05/12] drm/xe/fb: Remove weird VMA end alignemnt

Jani Nikula
2026-04-08T08:45:15Z

On Tue, 07 Apr 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> For some reason xe is also alining the end of the vma. That
> should not be necessary, so don't.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Cc: Maarten, does it look sane to you too?

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/xe/display/xe_fb_pin.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index 35e5c322f8b0..72efafb189f7 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -307,8 +307,7 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,
> size = intel_rotation_info_size(&view->rotated) * XE_PAGE_SIZE;
>
> pte = xe_ggtt_encode_pte_flags(ggtt, bo, xe->pat.idx[XE_CACHE_NONE]);
> - vma->node = xe_ggtt_insert_node_transform(ggtt, bo, pte,
> - ALIGN(size, align), align,
> + vma->node = xe_ggtt_insert_node_transform(ggtt, bo, pte, size, align,
> view->type == I915_GTT_VIEW_NORMAL ?
> NULL : write_ggtt_rotated_node,
> &(struct fb_rotate_args){view, bo});

--
Jani Nikula, Intel