Re: [PATCH 00/13] Ultrajoiner basic functionality series

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 9/30/2024 10:05 PM, Ankit Nautiyal wrote:
> This patch series attempts to implement basic support
> for Ultrajoiner functionality.
>
> Rev6:
> -Upgrade the debugfs functionality to enable the joining of a
> specified number of pipes.
> -Modify the display helpers reliant on the pipe joiner mechanism
> to use number of pipes joined, instead of joiner flag.
> -Checkpatch fixes.
>
> Rev7:
> -Use struct intel_display, minor refactoring, and rebase.
>
> Rev8:
> -Address comments from Ville.
> -Simplified debugfs for forcing joiner, and added option to disable
> joiner.
> -Modified the ultra/bigjoiner helpers as suggested by Ville.
> -Split few of the bigger patches as suggested.
>
> Rev9:
> Rebase
>
> Rev10:
> -Rebase
> -Fix enable_joined_pipes as suggested by Ville, to avoid propagate
> is_ultrajoiner.
> -Enhance the mask to iterate over joiner pipes, as suggested by Ville.
>
> Rev11:
> -Address review comments from Ville
> -Split changes to dsc helpers to separate patches
>
> Rev12:
> -Move 'Refactor enable_joiner_pipes' earlier than 'Implement hw state
> readout and checks for ultrajoiner'.
> -Few improvements as suggested in review comments.
> -Use --patience for Patch #8 "drm/i915/display: Refactor
> enable_joiner_pipes"
>
> Rev13:
> -Refactor get_max_compressed_bpp_with_joiner and split changes into 3
> patches.
>
> Rev14:
> -Fix issues in patches#11~13 for num_joined_pipes = 1.
>
> Rev15:
> -Rebase
>
> Ankit Nautiyal (8):
>    drm/i915: Split current joiner hw state readout
>    drm/i915/display: Add macro HAS_ULTRAJOINER()
>    drm/i915/display: Refactor enable_joiner_pipes
>    drm/i915/dp: Refactor joiner max_bpp calculations into separate
>      functions
>    drm/i915/dp: Use num_joined_pipes in bigjoiner_bw_max_bpp
>    drm/i915/dp: Modify compressed bpp limitations for ultrajoiner
>    drm/i915/display: Consider ultrajoiner for computing maxdotclock
>    drm/i915/intel_dp: Add support for forcing ultrajoiner
>
> Stanislav Lisovskiy (5):
>    drm/i915: Add bigjoiner and uncompressed joiner hw readout sanity
>      checks
>    drm/i915: Implement hw state readout and checks for ultrajoiner
>    drm/i915/display/vdsc: Add ultrajoiner support with DSC
>    drm/i915/dp: Simplify helper to get slice count with joiner
>    drm/i915: Compute config and mode valid changes for ultrajoiner


Thanks for the reviews, patches pushed to drm-intel-next.

Regards,

Ankit

>
>   drivers/gpu/drm/i915/display/intel_display.c  | 320 +++++++++++++++---
>   drivers/gpu/drm/i915/display/intel_display.h  |   3 +
>   .../drm/i915/display/intel_display_debugfs.c  |   8 +
>   .../drm/i915/display/intel_display_device.h   |   3 +
>   drivers/gpu/drm/i915/display/intel_dp.c       | 106 ++++--
>   drivers/gpu/drm/i915/display/intel_vdsc.c     |  11 +-
>   .../gpu/drm/i915/display/intel_vdsc_regs.h    |   2 +
>   7 files changed, 372 insertions(+), 81 deletions(-)
>