Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: "Meenakshisundaram,
	Mohanram" <mohanram.meenakshisundaram@intel.com>,
	<intel-xe@lists.freedesktop.org>, <rodrigo.vivi@intel.com>
Cc: <thomas.hellstrom@linux.intel.com>, <matthew.brost@intel.com>,
	<Meenakshisundaram@freedesktop.org>
Subject: Re: [PATCH] drm/xe/guc: Fix CFI panic due to function signature mismatch
Date: Thu, 29 Jan 2026 21:52:51 +0100	[thread overview]
Message-ID: <d14315b0-6a58-4f9f-8dc9-91f3af96303e@intel.com> (raw)
In-Reply-To: <20260129183659.492395-1-mohanram.meenakshisundaram@intel.com>



On 1/29/2026 7:36 PM, Meenakshisundaram, Mohanram wrote:
> When reading GuC debugfs file (/sys/kernel/debug/dri/0/gt0/uc/guc_info)
> with CFI (Control Flow Integrity) enabled, the kernel panics at
> guc_debugfs_show+0x9f.
> 
> Root cause: guc_debugfs_show() declares a function pointer expecting
> int (*print)(struct xe_guc *, struct drm_printer *),
> but xe_guc_print_info() was defined with void return type.
> CFI detects this type mismatch at the indirect call site.
> 
> Fix: Change xe_guc_print_info() to return int instead of void, matching
> the expected function signature. Return -ETIMEDOUT on force_wake failure
> and 0 on success.
> 

There is already [1] under review which addresses the same issue

[1] https://patchwork.freedesktop.org/series/160668/ 



      parent reply	other threads:[~2026-01-29 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 18:36 [PATCH] drm/xe/guc: Fix CFI panic due to function signature mismatch Meenakshisundaram, Mohanram
2026-01-29 18:21 ` ✗ CI.checkpatch: warning for " Patchwork
2026-01-29 18:23 ` ✓ CI.KUnit: success " Patchwork
2026-01-29 19:00 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-29 20:52 ` Michal Wajdeczko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d14315b0-6a58-4f9f-8dc9-91f3af96303e@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=Meenakshisundaram@freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=mohanram.meenakshisundaram@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox