From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47E71EFCD95 for ; Mon, 9 Mar 2026 10:35:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E67F810E4CE; Mon, 9 Mar 2026 10:35:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gbjUct+B"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF3E610E00A; Mon, 9 Mar 2026 10:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773052519; x=1804588519; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=H5k17/f2MLN4x7ocaee4PFxuLWcOy17TiF4ninqHGQw=; b=gbjUct+BVZK8jpafePFupeAtP7tVruK1KD8oeJMfQpAIxmn6ElbZ9zNR bAtkjtvATxDTpWn2kfxm558uEaC2nuWSdYR5kDE6b2iLDMxJSEmE2MwVs UJFAgnj8hBu4vmWNcGqkPT6LCABhhbSGskY8G/up5XGZVpuzWx+5fjuRP 66RcBVVQ5mPfhxc6A4iCeVe/K5CLc0m4MuhCPkWvi0eVwDlGpsUZRv+gK 5tXy3X2XGtCVd0S1sXBSDyR2rjITwIygPx32C48nwNUv0WJPQriqwDHSj I2myjl5xbwWZZeGMxtbw4EqAqDzfHSA1Hy+cITj9809MAMUhlWTJcVlAY A==; X-CSE-ConnectionGUID: 5KDDRlxGQwWcFLSDIaTT2w== X-CSE-MsgGUID: 6FzFlE3fRt6wKWlAlwqqGg== X-IronPort-AV: E=McAfee;i="6800,10657,11723"; a="91458064" X-IronPort-AV: E=Sophos;i="6.23,109,1770624000"; d="scan'208";a="91458064" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2026 03:35:18 -0700 X-CSE-ConnectionGUID: Csk/u4cIRxa+3Nb4jmgRqw== X-CSE-MsgGUID: uL9Ox0hASTG0x9wDStKXDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,109,1770624000"; d="scan'208";a="250177817" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.239]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2026 03:35:14 -0700 From: Jani Nikula To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Randy Dunlap , Ville =?utf-8?B?U3lyasOkbMOk?= , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] iopoll: fix function parameter names in read_poll_timeout_atomic() In-Reply-To: <20260306221033.2357305-1-rdunlap@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260306221033.2357305-1-rdunlap@infradead.org> Date: Mon, 09 Mar 2026 12:35:11 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 06 Mar 2026, Randy Dunlap wrote: > Correct the function parameter names to avoid kernel-doc warnings > and to emphasize this function is atomic (non-sleeping). > > Warning: include/linux/iopoll.h:169 function parameter 'sleep_us' not > described in 'read_poll_timeout_atomic' > Warning: ../include/linux/iopoll.h:169 function parameter > 'sleep_before_read' not described in 'read_poll_timeout_atomic' > > Fixes: 9df8043a546d ("iopoll: Generalize read_poll_timeout() into poll_ti= meout_us()") > Signed-off-by: Randy Dunlap Reviewed-by: Jani Nikula Please let me know how you want this merged. I don't think iopoll.h has an active maintainer. > --- > v2: change the function parameter names, not the kernel-doc comments (Jan= i) > > include/linux/iopoll.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- linux-next-20260304.orig/include/linux/iopoll.h > +++ linux-next-20260304/include/linux/iopoll.h > @@ -159,7 +159,7 @@ > * > * This macro does not rely on timekeeping. Hence it is safe to call ev= en when > * timekeeping is suspended, at the expense of an underestimation of wal= l clock > - * time, which is rather minimal with a non-zero delay_us. > + * time, which is rather minimal with a non-zero @delay_us. > * > * When available, you'll probably want to use one of the specialized > * macros defined below rather than this macro directly. > @@ -167,9 +167,9 @@ > * Returns: 0 on success and -ETIMEDOUT upon a timeout. In either > * case, the last read value at @args is stored in @val. > */ > -#define read_poll_timeout_atomic(op, val, cond, sleep_us, timeout_us, \ > - sleep_before_read, args...) \ > - poll_timeout_us_atomic((val) =3D op(args), cond, sleep_us, timeout_us, = sleep_before_read) > +#define read_poll_timeout_atomic(op, val, cond, delay_us, timeout_us, \ > + delay_before_read, args...) \ > + poll_timeout_us_atomic((val) =3D op(args), cond, delay_us, timeout_us, = delay_before_read) >=20=20 > /** > * readx_poll_timeout - Periodically poll an address until a condition i= s met or a timeout occurs > > > --- > Cc: Ville Syrj=C3=A4l=C3=A4 > Cc: Jani Nikula > Cc: intel-gfx@lists.freedesktop.org > Cc: intel-xe@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org --=20 Jani Nikula, Intel