Re: [PATCH] drm/xe/oa: Remove WARN_ON's for unsupported configurations

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 20.06.2024 00:56, Ashutosh Dixit wrote:
> The OA ioctl's already have drm_dbg's which are sufficient to tell the user
> that OA is not supported on unsupported configurations (execlist mode and
> platform gen < 12). Having additional WARN_ON's for these during driver
> probe create unnecessary noise. Just remove these WARN_ON's.
> 
> Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_oa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 34206e0b6a08..5093a89a31f1 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -2382,7 +2382,7 @@ int xe_oa_init(struct xe_device *xe)
>  	int ret;
>  
>  	/* Support OA only with GuC submission and Gen12+ */
> -	if (XE_WARN_ON(!xe_device_uc_enabled(xe)) || XE_WARN_ON(GRAPHICS_VER(xe) < 12))
> +	if (!xe_device_uc_enabled(xe) || GRAPHICS_VER(xe) < 12)
>  		return 0;
>  
>  	oa->xe = xe;