From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 3/5] drm/i915/pfit: fix comment style for moved comments
Date: Wed, 26 Feb 2025 12:01:09 +0200 [thread overview]
Message-ID: <d3bc49cf04473a0be07bab1ad7fd9df1f671307f.1740564009.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1740564009.git.jani.nikula@intel.com>
Adhere to coding style.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_pfit.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_pfit.c b/drivers/gpu/drm/i915/display/intel_pfit.c
index 0a7609020c17..5e4a6ef2ff8d 100644
--- a/drivers/gpu/drm/i915/display/intel_pfit.c
+++ b/drivers/gpu/drm/i915/display/intel_pfit.c
@@ -569,9 +569,9 @@ void ilk_pfit_enable(const struct intel_crtc_state *crtc_state)
if (!crtc_state->pch_pfit.enabled)
return;
- /* Force use of hard-coded filter coefficients
- * as some pre-programmed values are broken,
- * e.g. x201.
+ /*
+ * Force use of hard-coded filter coefficients as some pre-programmed
+ * values are broken, e.g. x201.
*/
if (IS_IVYBRIDGE(dev_priv) || IS_HASWELL(dev_priv))
intel_de_write_fw(dev_priv, PF_CTL(pipe), PF_ENABLE |
@@ -591,8 +591,10 @@ void ilk_pfit_disable(const struct intel_crtc_state *old_crtc_state)
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
enum pipe pipe = crtc->pipe;
- /* To avoid upsetting the power well on haswell only disable the pfit if
- * it's in use. The hw state code will make sure we get this right. */
+ /*
+ * To avoid upsetting the power well on haswell only disable the pfit if
+ * it's in use. The hw state code will make sure we get this right.
+ */
if (!old_crtc_state->pch_pfit.enabled)
return;
@@ -657,8 +659,10 @@ void i9xx_pfit_enable(const struct intel_crtc_state *crtc_state)
intel_de_write(display, PFIT_CONTROL(display),
crtc_state->gmch_pfit.control);
- /* Border color in case we don't scale up to the full screen. Black by
- * default, change to something else for debugging. */
+ /*
+ * Border color in case we don't scale up to the full screen. Black by
+ * default, change to something else for debugging.
+ */
intel_de_write(display, BCLRPAT(display, crtc->pipe), 0);
}
--
2.39.5
next prev parent reply other threads:[~2025-02-26 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 10:01 [PATCH 0/5] drm/i915/pfit: panel fitter refactors Jani Nikula
2025-02-26 10:01 ` [PATCH 1/5] drm/i915/pfit: rename intel_panel_fitting() to intel_pfit_compute_config() Jani Nikula
2025-02-26 10:01 ` [PATCH 2/5] drm/i915/pfit: move ilk and i9xx pfit code to intel_pfit.[ch] Jani Nikula
2025-02-26 10:01 ` Jani Nikula [this message]
2025-02-26 10:01 ` [PATCH 4/5] drm/i915/pfit: convert moved code to struct intel_display Jani Nikula
2025-02-26 10:01 ` [PATCH 5/5] drm/i915/pfit: split out intel_pfit_regs.h Jani Nikula
2025-02-26 12:53 ` [PATCH 0/5] drm/i915/pfit: panel fitter refactors Ville Syrjälä
2025-02-27 18:59 ` Jani Nikula
2025-02-26 13:16 ` ✓ CI.Patch_applied: success for " Patchwork
2025-02-26 13:16 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-26 13:17 ` ✓ CI.KUnit: success " Patchwork
2025-02-26 13:34 ` ✓ CI.Build: " Patchwork
2025-02-26 13:36 ` ✓ CI.Hooks: " Patchwork
2025-02-26 13:38 ` ✗ CI.checksparse: warning " Patchwork
2025-02-26 13:55 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-26 14:55 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3bc49cf04473a0be07bab1ad7fd9df1f671307f.1740564009.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox