From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "dev@lankhorst.se" <dev@lankhorst.se>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
lkp <lkp@intel.com>
Subject: Re: drm/ttm/tests: Fix build failure on PREEMPT_RT
Date: Wed, 4 Mar 2026 05:54:55 +0000 [thread overview]
Message-ID: <d5a0a62bd8de9ce035efa1edf95c8332da0ec6ea.camel@intel.com> (raw)
In-Reply-To: <20260226151228.256003-1-dev@lankhorst.se>
On Thu, 2026-02-26 at 16:12 +0100, Maarten Lankhorst wrote:
> Fix a compile error in the kunit tests when CONFIG_PREEMPT_RT is
> enabled, and the normal mutex is converted into a rtmutex.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202602261547.3bM6yVAS-lkp@intel.com/
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
> drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> index d468f83220720..2ba5ddf2b1c9e 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> @@ -222,13 +222,13 @@ static void ttm_bo_reserve_interrupted(struct
> kunit *test)
> KUNIT_FAIL(test, "Couldn't create ttm bo reserve
> task\n");
>
> /* Take a lock so the threaded reserve has to wait */
> - mutex_lock(&bo->base.resv->lock.base);
> + ww_mutex_lock(&bo->base.resv->lock, NULL);
There is this comment in include/linux/dma-resv.h:dma_resv:lock :
* Update side lock. Don't use directly, instead use the wrapper
* functions like dma_resv_lock() and dma_resv_unlock().
BR,
Jouni Högander
>
> wake_up_process(task);
> msleep(20);
> err = kthread_stop(task);
>
> - mutex_unlock(&bo->base.resv->lock.base);
> + ww_mutex_unlock(&bo->base.resv->lock);
>
> KUNIT_ASSERT_EQ(test, err, -ERESTARTSYS);
> }
next prev parent reply other threads:[~2026-03-04 5:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 15:12 [PATCH] drm/ttm/tests: Fix build failure on PREEMPT_RT Maarten Lankhorst
2026-02-27 6:06 ` ✓ CI.KUnit: success for " Patchwork
2026-02-27 6:42 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27 13:31 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-04 5:54 ` Hogander, Jouni [this message]
2026-03-04 8:37 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5a0a62bd8de9ce035efa1edf95c8332da0ec6ea.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=dev@lankhorst.se \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox