Re: [PATCH v7 03/10] drm/xe/devcoredump: Add ASCII85 dump helper function

[John Harrison <john.c.harrison@intel.com>]

On 9/5/2024 18:54, Lucas De Marchi wrote:
> On Thu, Sep 05, 2024 at 01:50:58PM GMT, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> There is a need to include the GuC log and other large binary objects
>> in core dumps and via dmesg. So add a helper for dumping to a printer
>> function via conversion to ASCII85 encoding.
>
> why are we not dumping the binary data directly to devcoredump?
As per earlier comments, there is a WiFi driver or some such that does 
exactly that. But all they are dumping is a binary blob.

We want the devcoredump file to still be human readable. That won't be 
the case if you stuff binary data in the middle of it. Most obvious 
problem - the zeros in the data will terminate your text file at that 
point. Potentially bigger problem for end users - random fake ANSI codes 
will destroy your terminal window if you try to cat the file to read it.

John.


>
> Lucas De Marchi