Re: [PATCH v2] drm/xe/xe_sysctrl: Fix sparse endian warnings in mailbox header macros

["Tauro, Riana" <riana.tauro@intel.com>]

On 4/7/2026 11:33 PM, Anoop, Vijay wrote:
> From: Anoop Vijay <anoop.c.vijay@intel.com>
>
> Remove unnecessary le32_to_cpu() conversions from XE_SYSCTRL_APP_HDR_*
> macros.
>
> Fixes: 37ace5254a2b ("drm/xe/xe_sysctrl: Add ABI and mailbox interface headers")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202604010228.Z20DhK4g-lkp@intel.com/
Looks good to me

Reviewed-by: Riana Tauro <riana.tauro@intel.com>

> Signed-off-by: Anoop Vijay <anoop.c.vijay@intel.com>
> ---
> v2: (Umesh, Riana)
> - Fix macros instead of changing struct field, per review
> ---
>   drivers/gpu/drm/xe/xe_sysctrl_mailbox.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.h b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.h
> index 91460be9e22c..f67e9234de48 100644
> --- a/drivers/gpu/drm/xe/xe_sysctrl_mailbox.h
> +++ b/drivers/gpu/drm/xe/xe_sysctrl_mailbox.h
> @@ -15,13 +15,13 @@ struct xe_sysctrl;
>   struct xe_sysctrl_mailbox_command;
>   
>   #define XE_SYSCTRL_APP_HDR_GROUP_ID(hdr) \
> -	FIELD_GET(APP_HDR_GROUP_ID_MASK, le32_to_cpu((hdr)->data))
> +	FIELD_GET(APP_HDR_GROUP_ID_MASK, (hdr)->data)
>   
>   #define XE_SYSCTRL_APP_HDR_COMMAND(hdr) \
> -	FIELD_GET(APP_HDR_COMMAND_MASK, le32_to_cpu((hdr)->data))
> +	FIELD_GET(APP_HDR_COMMAND_MASK, (hdr)->data)
>   
>   #define XE_SYSCTRL_APP_HDR_VERSION(hdr) \
> -	FIELD_GET(APP_HDR_VERSION_MASK, le32_to_cpu((hdr)->data))
> +	FIELD_GET(APP_HDR_VERSION_MASK, (hdr)->data)
>   
>   void xe_sysctrl_mailbox_init(struct xe_sysctrl *sc);
>   int xe_sysctrl_send_command(struct xe_sysctrl *sc,