Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Filipchuk <julia.filipchuk@intel.com>
To: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/xe/gsc: Do not attempt to load the GSC multiple times
Date: Fri, 23 Aug 2024 17:31:49 -0700	[thread overview]
Message-ID: <d89e0ac8-be21-49de-ab9c-a4509bda48b7@intel.com> (raw)
In-Reply-To: <20240813231148.1663731-2-daniele.ceraolospurio@intel.com>

LGTM

Suggest to use "< 0" for error check in xe_uc_fw_is_in_error_state?

Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>


  parent reply	other threads:[~2024-08-24  0:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 23:11 [PATCH 0/4] drm/xe: fixes and debug improvements for GSC load Daniele Ceraolo Spurio
2024-08-13 23:11 ` [PATCH 1/4] drm/xe/gsc: Do not attempt to load the GSC multiple times Daniele Ceraolo Spurio
2024-08-15 18:24   ` Lucas De Marchi
2024-08-24  0:31   ` Julia Filipchuk [this message]
2024-08-13 23:11 ` [PATCH 2/4] drm/xe/gsc: Fix FW status if the firmware is already loaded Daniele Ceraolo Spurio
2024-08-24  0:32   ` Julia Filipchuk
2024-08-13 23:11 ` [PATCH 3/4] drm/xe/gsc: Track the platform in the compatibility version Daniele Ceraolo Spurio
2024-08-24  0:32   ` Julia Filipchuk
2024-08-13 23:11 ` [PATCH 4/4] drm/xe/gsc: Add debugfs to print GSC info Daniele Ceraolo Spurio
2024-08-24  1:02   ` Julia Filipchuk
2024-08-28 21:25     ` Daniele Ceraolo Spurio
2024-08-13 23:17 ` ✓ CI.Patch_applied: success for drm/xe: fixes and debug improvements for GSC load Patchwork
2024-08-13 23:17 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-13 23:19 ` ✓ CI.KUnit: success " Patchwork
2024-08-13 23:30 ` ✓ CI.Build: " Patchwork
2024-08-13 23:33 ` ✓ CI.Hooks: " Patchwork
2024-08-13 23:34 ` ✓ CI.checksparse: " Patchwork
2024-08-14  0:05 ` ✓ CI.BAT: " Patchwork
2024-08-14  1:10 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d89e0ac8-be21-49de-ab9c-a4509bda48b7@intel.com \
    --to=julia.filipchuk@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox