From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 626A6C4167B for ; Wed, 6 Dec 2023 12:08:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 305C310E0EE; Wed, 6 Dec 2023 12:08:18 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8953910E0EE for ; Wed, 6 Dec 2023 12:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701864496; x=1733400496; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=5d/KmOANd3/TjG8q5djjRdpNyhN/o8FnNmOpXlXSgIA=; b=YOpb3Di7EO13r/SP85oG/CD+9RP6GsjnYYjOnUSzAs78g0sG2+HNYY0e eoRltfVb1NZ/UH+OPGDkYF3LwYN33HfMFQUiZKgpJQ7CYezOhZ6A5U1UL NNAmCcMUCmt3xgnZE+Dltpe0/0rQ0ZhfS35M92DF8KxpYQDU7IEdqNQyY UKhAcwWiq65LPL+8rDW7l88eQwtdfqPgcuRd0Q/LKNy/iuVq/MJzYZ50b Aa2kC9cWcAZyxK83R33yx+NTMBul98LmsAhTxqBBdP5AJEbDnRo/qZNGG NzIOm6cBAEeHMP6M0S3P4daGRZIJZvXCvLX1xCbxFcxrfM41e5zm7xqb7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="393780561" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="393780561" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 04:08:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="771282107" X-IronPort-AV: E=Sophos;i="6.04,255,1695711600"; d="scan'208";a="771282107" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Dec 2023 04:08:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 04:08:15 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Dec 2023 04:08:15 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Dec 2023 04:08:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YzKFszZz59hkIMdI72MGYxanjBncgPqxikCCdlIaQsJFnbFXoHeEBT2TBx6nxZ2y3JPMDP1kx6VBBWrDYdBapNvrH1/2Z6LGjbM3OAN7RREcJxydqAuaQAs9Ns7MUiRMHTWOPmBPamAVBY17gDQ5EBPHr6GL/c4kiE+IpYB6BF1cKmLYduGb4I5wj0GQaHHi3AfPYsvT7UcO/DM18SQAll1RNkhqQx1aDbpRb3CxwK1Xo17kfma663Z4dAAEfCJCIG6YuXuB6ugAU1DWIxMY87MCIVPDEpI3bg/prXttrUsxOL60SUc6P8ByXbnHlYljHda2fpYIwjudM+bnfZ/R8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TmuR9hGSOgikqHMxVauDAZOR9SmS3/0VxiNsfWokU2g=; b=WgFiXyLDYPLlFoEYECkLJ+v3RrrCkz2nIDKXCEl5LiJ60xm32NdWinllGhaYo7wgdF0lNCX/PXbo0bAEfRKvi+HerIOsk8VGzcqyzn/5agzfQwIjNxzPobW9UtDReFEduHgLmXPIZ5M5oO99EqVXMF9y0QAzYqXDNclyvwH0jR6C2wdBNjd+Ck6UaoRJ011DidSxT/J72SDlvhnaG/ENo9pxo9OScoS6M7ap3mw0N13Omn8kNdnsfQ9GH7l0xB2hDhHMNWo0hBQQWLgAwZKy5FB5e81UKkVvcaLjKCcYIYQtAoF8k8hDv5OktzdtSQNze6b5hlGIp99ruVQWxRhlGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by LV8PR11MB8745.namprd11.prod.outlook.com (2603:10b6:408:204::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Wed, 6 Dec 2023 12:08:13 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2eaa:4647:7ac0:eb52]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::2eaa:4647:7ac0:eb52%4]) with mapi id 15.20.7068.025; Wed, 6 Dec 2023 12:08:13 +0000 Message-ID: Date: Wed, 6 Dec 2023 17:38:06 +0530 User-Agent: Mozilla Thunderbird To: "Gupta, Anshuman" , "intel-xe@lists.freedesktop.org" References: <20231206044735.966213-1-sujaritha.sundaresan@intel.com> <20231206044735.966213-2-sujaritha.sundaresan@intel.com> Content-Language: en-US From: "Sundaresan, Sujaritha" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0098.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:9b::11) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|LV8PR11MB8745:EE_ X-MS-Office365-Filtering-Correlation-Id: a476a188-093c-4986-bcdf-08dbf6540548 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: opwIK5alH49BChA7cPnc/HazPa+Rf3+0QxnFeDdwEg9xf9hRjZNrRYavqV8+GO0ftsQoCncBRug7ZsVmGAq8X30gUCZVOzzbVEmA5uYLWcdBOy7wPkmNINWhD5fXuWUeh7LdKUNKLCLZrZQ6FxqgohdE+oCy3KMUu5s4yQpfFjeXTP4MUDBf+xUx9SjlvqMmjM3aofpq7T9+Nfn6rZDXnLYLK5xtRhq86TGaGyq8obQfIOShD0pKL+sXnWTZ2LOCyZy43a4IemnuKd2WGU41YjDM0vqzYCEBtobE1NVtn4nJzPrI1+wFLw17XjoAZY9oQz1OnCDmmRYVpFEpLzhdxWtWwkkm/6MWLhY7xzQqyoTt/sNg0WRHl4B9N95mKjQi6CLxpOaAfVp5DhSZyMQsrN9iPU+gmxAob787iLl/e/o5f5rGf1JBzxuvZJmIde35v7PLpk8biAy5LYGwMrc3A0sKEqADTp6boWkVBIuR3YxvNEjLqEXpFGLVKMwZWPusihpEF7YJVjYM1JtyVQeiyuh2rnEWs3D/qg3Ky7dBBAOfTKaqCV/9p2ilhEkWwHA9BYZABTKmD8fA2YvILLRy5cWQ45BD3FK17DjVfJnjJKyaUXclq1SwBH366j/Wb5NQRl3cMt1hwO/1LO/kO54CTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(366004)(136003)(39860400002)(396003)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(41300700001)(4326008)(8676002)(82960400001)(38100700002)(86362001)(31696002)(36756003)(83380400001)(2906002)(8936002)(5660300002)(6506007)(6666004)(53546011)(26005)(107886003)(478600001)(6486002)(31686004)(2616005)(6512007)(66946007)(66476007)(66556008)(110136005)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZE9YaTVvU1hrNHlTbVZ2S2VSRit1Z1hrOTRaQk9wSjRyWElBN2ViVjVIM3c1?= =?utf-8?B?TGp5OEhFZ2hyK1BsVnZUWVl3VGFuT3R1QlJQZmtyeDlKTnJLNWZ4RUltUndi?= =?utf-8?B?L3laQXRVTkhOT2lxNHFKR1FiY2tEb0tPNG5FazRIeWFQSERleTlxSEI1MzlF?= =?utf-8?B?aFNrMXkwZ0J3aWtZWXJlKzZJNHc1Mnk1T3ZnUXJBVFh0YTgxSmNnbkdFU0Y1?= =?utf-8?B?eXVhK0I0WWJpQVdZa0JhTHJ0SDNtbjQzYjNhOTRlZVgveUpHV05PcnF4WnJW?= =?utf-8?B?dEIwcTN1RFRPTGM5YjNkRXdhSGpVSmRrT3orV2htbG1qYnplOUNkMEhLTWN3?= =?utf-8?B?UVZWUURUUm9teC9BckdHdkVoTkhjelpoUi85RUdGd0hQQWFqRDlROUcvaHJo?= =?utf-8?B?dzhYZU9wVnlENnNRUW9xbjZJVEpFUDc5Mi9xNEZtRlZFRXVVaHJuSENTQUoz?= =?utf-8?B?RDFFVWU5VmdDY0FGWGxvT2MxT1hHeHdEeWZTQWtiVlduVUo4bFNZN1dYZDJn?= =?utf-8?B?UDBGc2pGSlpuYnVNeXV4NU1tdkhxSnZKeEFKRGxyU3Z0emRBNXdUdW9NQUVp?= =?utf-8?B?Y1pCZkRyVk02UzRhTW45bWc1ZkhkbFNrZTluSnZmS25qZEZ3L093VHE1WC9O?= =?utf-8?B?S0pVUFY1NE15ZDJmS2pxa0RqTlNsanlyTDhDMnRqaGtUVm9HS1U5MzdRWmtL?= =?utf-8?B?aVBleFI0QXhHN3pueVJld01LSFVkVWNjekdKU3dJNzlLRWZiUk9WbjhoK3B5?= =?utf-8?B?MTdPcno0emZGc284NlhuNTVmV1Y0cnVyZGNqZmRmMW4rZ0pZRzMxU2dUQ3A3?= =?utf-8?B?Z0IrclJOYm9kQUtWS3czeDlWNHNWMkpuRlpjNlNldDloUGxoSy9FVGMxUjlj?= =?utf-8?B?WWgvVEFNcG1FbDdEaGNhcTJNazV3ZGVyNjQyYmg1N3pEQ29yVFBtUkhVNUo5?= =?utf-8?B?a292N2R6a0dtNUhsMndscERYUGk1UmhlT3BSam9TeTVydFQrbElsK2RQb3h2?= =?utf-8?B?bmFjWkdtL3RVZW9FclZWb2hLaEZEZ0l3YWhqWDUvdm84MzZ5eE1kQlA2UGox?= =?utf-8?B?Q2pQYldYRyt2U3dpOTN3MVJIMmx0WklEZENieXNBeTVibmZKV0NuL0RCOG55?= =?utf-8?B?YW1LQlNjK2xrRjNoVWE3YmpqM0FJTmUrbW56OW1GWXBIK2dJcVFvT3lEMmpK?= =?utf-8?B?NFJiSjJEa1k1QWhyeTZxMlFRY2FWVExvWE1uUExZc0tPSFRGaXpmTE9GTngy?= =?utf-8?B?b3RmeEgreFhFTFFYdTdBRkV4aWRQWDZwdnZRaWp2RlVCSTR3anU4eDZSa0Fj?= =?utf-8?B?VGJmbGhYL0ljSmUycnI3ejdyWmFUeVd4cHlwZDUrU2hRWXVUcVV2a05HR1FL?= =?utf-8?B?QnBsNCs0TzkxQk45SWNNSWhvaXdVRDA0aGpIdlVTWEdjVU9VV0kyd3liZ0pW?= =?utf-8?B?blg4REc1VTJsa1lKeEdtZ3hIbUJHUjkwdzBsbFNEakdxeHN5NEN3TkRIeWFB?= =?utf-8?B?cnNhcFhJUzV2Ty8xSnlURzJaZ0hyUG5IbnU0UXRxL2xDVWVvNFVDOTlEbU81?= =?utf-8?B?RlJUK3BsdE5uYmFmWmUrVUxQOE1jeWU4N3ZRZUhCWTVUQmozZXlrTzc2U21K?= =?utf-8?B?RnplNkViS0IyQTl3dlNwNEdpWi9kZ1JzaTBaajlPSWhJWDFacVJXZHdrQmx6?= =?utf-8?B?RzRQT0dFamxmM0cxdUlnbXh4WCsrR1YvQUtaeVR1R3pyR2o5T0M1UWQ4OFZu?= =?utf-8?B?ckIvWHBRS2RpZVdPREE4cUhMWE5ySGdhYzkvaTBBd1Bmc1dWVXZvS3hsU2xm?= =?utf-8?B?akxZOVB2V05jUVRqNjZFU2hMY2F6b0NaNnd4ODlVTWhuaFo0R1ZJQjE0YnNR?= =?utf-8?B?WDY5amNRaGFxdFIzQnNjWG0xdUJZUzhMalo1UTVOUDYrV3RUOFJMRVdleVNK?= =?utf-8?B?THVnOXNCNXRpejJGWHJ6anBFaS9HSHdiR1g3Z3BnYmVHcS9VQVc0SGxlWlBV?= =?utf-8?B?VVo4Y1NHZXk1Rm1WY0VaL3FXNm9VSnE1ZlduUVUvcjhIRi9mdElpRy9NM3Qv?= =?utf-8?B?ak9RUitNL2UwVUw1ZVplbEJkbWgyTDNoVDhLcmtROTdlVnd1WjJzdUpiWmx2?= =?utf-8?B?U0kzSVpOWDlQYnEyZ2JmdllvYUpJcVVQTkJqUnZna2R4dzk2N2h0STlzSjlS?= =?utf-8?B?YlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a476a188-093c-4986-bcdf-08dbf6540548 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 12:08:13.2668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 29utbV2bfuBM1S48EQDdLYHHCUnTGpiuN16vGnC6meSEvk1fmWpIdR183qFVMP/TAdcqf3mB0CoiFsgCvrQxbKKuVx686O2Xv3S5bCq4u2g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8745 X-OriginatorOrg: intel.com Subject: Re: [Intel-xe] [v2 1/2] drm/xe: Add a new memory directory under tile X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Vivi, Rodrigo" Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 12/6/2023 5:23 PM, Gupta, Anshuman wrote: > >> -----Original Message----- >> From: Intel-xe On Behalf Of Sujaritha >> Sundaresan >> Sent: Wednesday, December 6, 2023 10:18 AM >> To: intel-xe@lists.freedesktop.org >> Cc: Sundaresan, Sujaritha ; Vivi, Rodrigo >> >> Subject: [Intel-xe] [v2 1/2] drm/xe: Add a new memory directory under tile >> >> Add a new memory directory under /device/tile and move physical_vram_size >> attribute to the new directory. >> >> New hierarchy: >> >> /device/tile/memory/physical_vram_size_bytes >> >> v2: Fix heading typo (Riana) >> Fix cleanup error on unload/reload cycle >> >> Signed-off-by: Sujaritha Sundaresan >> --- >> drivers/gpu/drm/xe/xe_tile_sysfs.c | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c >> b/drivers/gpu/drm/xe/xe_tile_sysfs.c >> index 16376607c68f..e8ce4d9270e6 100644 >> --- a/drivers/gpu/drm/xe/xe_tile_sysfs.c >> +++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c >> @@ -24,7 +24,8 @@ static ssize_t >> physical_vram_size_bytes_show(struct device *kdev, struct device_attribute >> *attr, >> char *buf) >> { >> - struct xe_tile *tile = kobj_to_tile(&kdev->kobj); >> + struct kobject *kobj = &kdev->kobj; >> + struct xe_tile *tile = kobj_to_tile(kobj->parent); >> >> return sysfs_emit(buf, "%llu\n", tile->mem.vram.actual_physical_size); >> } >> @@ -38,7 +39,7 @@ static void tile_sysfs_fini(struct drm_device *drm, void >> *arg) { >> struct xe_tile *tile = arg; >> >> - kobject_put(tile->sysfs); >> + kobject_del(tile->sysfs); > Why kobekct_del instead of kobject_put? > Thanks, > Anshuman Gupta. Hi Anshuman, Basically when sanity checking, after reload we see that we are not doing a proper cleanup. kobject_put will only decrement the ref count and possibly free the kobject. But that is not happening in this case. There is a duplicate remaining of the tile directory. This required a clean unregister of the parent from sysfs hence the use of kobject_del. Thanks, Suja >> } >> >> void xe_tile_sysfs_init(struct xe_tile *tile) @@ -46,6 +47,7 @@ void >> xe_tile_sysfs_init(struct xe_tile *tile) >> struct xe_device *xe = tile_to_xe(tile); >> struct device *dev = xe->drm.dev; >> struct kobj_tile *kt; >> + struct kobject *kobj; >> int err; >> >> kt = kzalloc(sizeof(*kt), GFP_KERNEL); @@ -64,8 +66,15 @@ void >> xe_tile_sysfs_init(struct xe_tile *tile) >> >> tile->sysfs = &kt->base; >> >> + kobj = kobject_create_and_add("memory", tile->sysfs); >> + if (!kobj) { >> + kobject_put(kobj); >> + drm_warn(&xe->drm, "%s failed, err: %d\n", __func__, - >> ENOMEM); >> + return; >> + } >> + >> if (IS_DGFX(xe) && xe->info.platform != XE_DG1 && >> - sysfs_create_file(tile->sysfs, physical_memsize_attr)) >> + sysfs_create_file(kobj, physical_memsize_attr)) >> drm_warn(&xe->drm, >> "Sysfs creation to read addr_range per tile failed\n"); >> >> -- >> 2.25.1