Re: [PATCH] drm/i915/gvt_mmio_table: Use the gvt versions of the display macros

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 1/21/2026 7:15 PM, Jani Nikula wrote:
> On Wed, 14 Jan 2026, Ankit Nautiyal <ankit.k.nautiyal@intel.com> wrote:
>> Include gvt/display_helpers.h so that the display register macros in
>> intel_gvt_mmio_table.c expand through the exported display functions.
>> This lets us keep the existing macro calls while avoiding direct
>> access to display internals, helping the display modularization work.
>>
>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Thanks for the review, pushed to drm-intel-next.


Regards,

Ankit

>
>> ---
>>   drivers/gpu/drm/i915/intel_gvt_mmio_table.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
>> index 478d00f89a4b..052596ac83a0 100644
>> --- a/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
>> +++ b/drivers/gpu/drm/i915/intel_gvt_mmio_table.c
>> @@ -11,12 +11,12 @@
>>   #include "display/intel_color_regs.h"
>>   #include "display/intel_crt_regs.h"
>>   #include "display/intel_cursor_regs.h"
>> -#include "display/intel_display_core.h"
>>   #include "display/intel_display_regs.h"
>>   #include "display/intel_display_types.h"
>>   #include "display/intel_dmc_regs.h"
>>   #include "display/intel_dp_aux_regs.h"
>>   #include "display/intel_dpio_phy.h"
>> +#include "display/intel_fbc.h"
>>   #include "display/intel_fbc_regs.h"
>>   #include "display/intel_fdi_regs.h"
>>   #include "display/intel_lvds_regs.h"
>> @@ -32,6 +32,7 @@
>>   #include "gt/intel_engine_regs.h"
>>   #include "gt/intel_gt_regs.h"
>>   
>> +#include "gvt/display_helpers.h"
>>   #include "gvt/reg.h"
>>   
>>   #include "i915_drv.h"