Re: [PATCH v8 5/6] drm/xe/guc: Pre-allocate output nodes for extraction

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

On Mon, 2024-05-06 at 18:47 -0700, Zhanjun Dong wrote:
> re-allocate a fixed number of empty nodes up front (at the
alan: "pre-allocate"
> time of ADS registration) that we can consume from or return to
> an internal cached list of nodes.
> Add guc capture data structure definition.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
alan: honestly, the commit message is just way too short and doesnt
even explain why we need this patch. On that note, we should
verify with the leads of xe-kmd core-mm if we still have the same
constraints for xe that we did in i915 that required this
pre-allocated cachelist of nodes.

alan: if we still need the pre-allocated cacahelist of nodes, then
all of the code in this patch looks good. However, as i mentioned
in Patch4, we should be doing dynamic allocation of nodes in P4
and only start introducing guc-capture's cachelist and usage together
with the rest of this patch which contains the allocation / freeing.