Re: [Intel-xe] [PATCH 1/3] drm/xe/uapi: Remove XE_QUERY_CONFIG_FLAGS_USE_GUC

["Souza, Jose" <jose.souza@intel.com>]

On Fri, 2023-07-21 at 16:19 -0400, Rodrigo Vivi wrote:
> This config is the only real one. If execlist remains in the
> code it will forever be experimental and we shouldn't maintain
> an uapi like that for that experimental piece of code that
> should never be used by real users.

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_query.c | 3 ---
>  include/uapi/drm/xe_drm.h     | 1 -
>  2 files changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_query.c b/drivers/gpu/drm/xe/xe_query.c
> index f880c9af1651..56440a27ddba 100644
> --- a/drivers/gpu/drm/xe/xe_query.c
> +++ b/drivers/gpu/drm/xe/xe_query.c
> @@ -191,9 +191,6 @@ static int query_config(struct xe_device *xe, struct drm_xe_device_query *query)
>  	if (xe_device_get_root_tile(xe)->mem.vram.usable_size)
>  		config->info[XE_QUERY_CONFIG_FLAGS] =
>  			XE_QUERY_CONFIG_FLAGS_HAS_VRAM;
> -	if (xe->info.enable_guc)
> -		config->info[XE_QUERY_CONFIG_FLAGS] |=
> -			XE_QUERY_CONFIG_FLAGS_USE_GUC;
>  	config->info[XE_QUERY_CONFIG_MIN_ALIGNEMENT] =
>  		xe->info.vram_flags & XE_VRAM_FLAGS_NEED64K ? SZ_64K : SZ_4K;
>  	config->info[XE_QUERY_CONFIG_VA_BITS] = 12 +
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 347351a8f618..790bf27407a5 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -217,7 +217,6 @@ struct drm_xe_query_config {
>  #define XE_QUERY_CONFIG_REV_AND_DEVICE_ID	0
>  #define XE_QUERY_CONFIG_FLAGS			1
>  	#define XE_QUERY_CONFIG_FLAGS_HAS_VRAM		(0x1 << 0)
> -	#define XE_QUERY_CONFIG_FLAGS_USE_GUC		(0x1 << 1)
>  #define XE_QUERY_CONFIG_MIN_ALIGNEMENT		2
>  #define XE_QUERY_CONFIG_VA_BITS			3
>  #define XE_QUERY_CONFIG_GT_COUNT		4