From: Jani Nikula <jani.nikula@intel.com>
To: David Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [PATCH] drm/displayid: fix Tiled Display Topology ID size
Date: Mon, 15 Jun 2026 14:14:27 +0300 [thread overview]
Message-ID: <dcce02bcee216f44cbbd4e597a2a0b3e4e9977e4@intel.com> (raw)
In-Reply-To: <CAMwc25ow-MehYN8u0EFkEW-JB2CYL+od9xja0WBK0-msWMHOww@mail.gmail.com>
On Thu, 11 Jun 2026, David Airlie <airlied@redhat.com> wrote:
> On Thu, Jun 11, 2026 at 12:16 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> The Tiled Display Topology ID of a DisplayID Tiled Display Topology Data
>> Block consists of three fields:
>>
>> - Tiled Display Manufacturer/Vendor ID Field (3 bytes)
>> - Tiled Display Product ID Code Field (2 bytes)
>> - Tiled Display Serial Number Field (4 bytes)
>>
>> i.e. a total of 9 bytes, not 8.
>>
>> The DisplayID Tiled Display Topology ID is used as the tile group
>> identifier.
>>
>> Update both struct displayid_tiled_block topology_id member and struct
>> drm_tile_group group_data member to full 9 bytes.
>>
>> The group data was missing the last byte of the serial number. I don't
>> know whether there are known bug reports that might be linked to this,
>> but it's plausible the last byte could be the differentiating part for
>> the tile groups, and fewer tile groups might have been created than
>> intended.
>
> I pulled out my spec, and indeed I can confirm this is the correct reading!
>
> Reviewed-by: Dave Airlie <airlied@redhat.com>
Thanks for the review, pushed to drm-misc-fixes.
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2026-06-15 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 14:15 [PATCH] drm/displayid: fix Tiled Display Topology ID size Jani Nikula
2026-06-10 14:24 ` ✓ CI.KUnit: success for " Patchwork
2026-06-10 15:03 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-10 19:21 ` ✓ Xe.CI.FULL: " Patchwork
2026-06-10 21:10 ` [PATCH] " David Airlie
2026-06-15 11:14 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcce02bcee216f44cbbd4e597a2a0b3e4e9977e4@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox