From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Ilia Levi <illevi@habana.ai>, intel-xe@lists.freedesktop.org
Cc: ilia.levi@intel.com, jonathan.cavitt@intel.com,
koby.elbaz@intel.com, yaron.avizrat@intel.com
Subject: Re: [PATCH v5 5/5] drm/xe: memirq handler changes
Date: Tue, 17 Sep 2024 21:53:21 +0200 [thread overview]
Message-ID: <de0b4f71-590e-43cf-9f7a-3299290f0297@intel.com> (raw)
In-Reply-To: <20240917112307.1242329-6-illevi@habana.ai>
On 17.09.2024 13:23, Ilia Levi wrote:
> From: Ilia Levi <ilia.levi@intel.com>
>
> Expose an interrupt processing handler for a single hw engine.
> Refactor code to use this handler from the VF.
> This handler also caters for the MSI-X mode, where the hardware engines
> report interrupt source and status to the offset of engine instance zero.
nit: maybe you should also add here that "this new function will be used
soon in upcoming MSIX enabling series."
>
> Signed-off-by: Ilia Levi <ilia.levi@intel.com>
but still LGTM
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
next prev parent reply other threads:[~2024-09-17 19:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 11:23 [PATCH v5 0/5] memirq infra changes Ilia Levi
2024-09-17 11:23 ` [PATCH v5 1/5] drm/xe: Introduce dedicated config for memirq debug Ilia Levi
2024-09-17 20:07 ` Michal Wajdeczko
2024-09-17 11:23 ` [PATCH v5 2/5] drm/xe: Introduce xe_device_uses_memirq() Ilia Levi
2024-09-17 19:16 ` Michal Wajdeczko
2024-09-17 11:23 ` [PATCH v5 3/5] drm/xe: move memirq out of VF Ilia Levi
2024-09-17 20:14 ` Michal Wajdeczko
2024-09-17 11:23 ` [PATCH v5 4/5] drm/xe: memirq infra changes for MSI-X Ilia Levi
2024-09-17 19:29 ` Michal Wajdeczko
2024-09-17 11:23 ` [PATCH v5 5/5] drm/xe: memirq handler changes Ilia Levi
2024-09-17 19:53 ` Michal Wajdeczko [this message]
2024-09-17 11:41 ` ✓ CI.Patch_applied: success for memirq infra changes (rev6) Patchwork
2024-09-17 11:42 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-17 11:43 ` ✓ CI.KUnit: success " Patchwork
2024-09-17 11:55 ` ✓ CI.Build: " Patchwork
2024-09-17 11:57 ` ✓ CI.Hooks: " Patchwork
2024-09-17 11:58 ` ✓ CI.checksparse: " Patchwork
2024-09-17 13:13 ` ✗ CI.BAT: failure " Patchwork
2024-09-17 15:16 ` ✗ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de0b4f71-590e-43cf-9f7a-3299290f0297@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=ilia.levi@intel.com \
--cc=illevi@habana.ai \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=koby.elbaz@intel.com \
--cc=yaron.avizrat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox