From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E39ECCAC589 for ; Tue, 9 Sep 2025 08:22:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A96F410E650; Tue, 9 Sep 2025 08:22:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="SIDIipj6"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33CB010E650; Tue, 9 Sep 2025 08:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757406166; x=1788942166; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=6P76TH7rnCVKKTMTyS+1ai4RvHbvt7VPfT1ibSEqKqM=; b=SIDIipj66dtLI5sPgmMyJVNFnsqPKu/sHOMNZ3HFZ1byiSamZumx0ih3 TVLeetQmaWzHFrJUUEstE3JPncpmN/n+T6oLJzXJsGfwNSOBDFcHTkRJ3 01X5ugwqRfzCBecd7QBW/empXwswtJD7gHguSk/BlJpkDjTSLuwdXWGQ1 VKXmP+ljo6SZzfW7o0jtcrv3mWaLJ8cRD3NvjRm0YpQHbi4n8Gnd2a+9b uvdhmMhF+Z/jDnrwhfQ6xy5HubKwnbU3SkyK6JaZokneEVfLTjmjAG4uQ 5whmxHfMT/5mqBjNArt1b+Ckj+8VFC/p+hhuAt5iR39j+P7YF7fT51qmg g==; X-CSE-ConnectionGUID: S0Hajc0LR5ammZifoqjiaQ== X-CSE-MsgGUID: MkZiFMd5S22NxKRgXmdn3w== X-IronPort-AV: E=McAfee;i="6800,10657,11547"; a="69937631" X-IronPort-AV: E=Sophos;i="6.18,250,1751266800"; d="scan'208";a="69937631" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2025 01:22:45 -0700 X-CSE-ConnectionGUID: jaDdCYtUQT6oamzEG45aSA== X-CSE-MsgGUID: qL541S5zRlWwsizAgZHAMA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,250,1751266800"; d="scan'208";a="204010798" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.247]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2025 01:22:44 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/display: add intel_display_device_present() In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250903090408.3492875-1-jani.nikula@intel.com> Date: Tue, 09 Sep 2025 11:22:41 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 05 Sep 2025, Ville Syrj=C3=A4l=C3=A4 wrote: > On Wed, Sep 03, 2025 at 12:04:08PM +0300, Jani Nikula wrote: >> Add a proper function for display && HAS_DISPLAY(display) to hide >> indirect struct intel_display access via the macro from a number of >> places outside of display. This makes struct intel_display * an opaque >> pointer in these places. All HAS_DISPLAY() usage is now constrained >> within display. > > Looks all right. Though a lot of code where this gets used really > shouldn't exist outside the display code in the first place. But > cleaning all that up is going to take some effort. Agreed. > Reviewed-by: Ville Syrj=C3=A4l=C3=A4 Pushed to din, thanks for the review. BR, Jani. --=20 Jani Nikula, Intel