Re: [PATCH 0/6] Move HuC and GSC FW defs for LNL and BMG to drm-xe-next

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 7/24/2024 9:48 PM, Lucas De Marchi wrote:
> On Wed, Jul 24, 2024 at 05:32:17PM GMT, Daniele Ceraolo Spurio wrote:
>> The FW defines are currently in the for-ci branch because the FW blobs
>> weren't ready to be officially published. Now that we have updated HuC
>> and GSC blobs that are ready to be sent to linux-firmware, we can remove
>> the defines from the for-ci branch and add them to drm-xe-next.
>>
>> Note that the 3 reverts are not meant to be merged, they're there to
>> indicate the removal of those patches from the for-ci branch. Only the
>> latter 3 patches are meant to be merged.
>>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: John Harrison <John.C.Harrison@Intel.com>
>
> not a huge fan of UFC, but the first thing that came to mind when I saw
> this was the catchphrase "iiiiiiiit's tiiime" :) Although I still miss
> GuC in the series, hopefully we can get it soon.
>
> If CI is happy, I'm happy with this.
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> It would be good to note, in the cover letter, where the firmware blobs
> currently are (the commit in drm/firmware containing them) and the
> status for sending this to upstream linux-firmware.
>
> AFAICS 
> https://gitlab.freedesktop.org/drm/firmware/-/commits/intel-staging?ref_type=heads
> up to commit 0690b69dc20da6d096450faa0c256f6896ff8365 has these 3 blobs.
> Can you share the plan to send them to linux-firmware? Is this going to
> happen just after having the CI results?

I was planning to wait for the GuC binaries to be ready first and then 
send a single PR to linux-firmware with all the blobs, which means 
sending the PR either late this week or early next week. Note that we 
usually send the PR after the patches have been merged for 1-2 days, so 
this would be in line with that.

CI is happy, so let me know if you prefer me to hold until we're ready 
with all the binaries, otherwise I'll go ahead and merge.

Daniele

>
>
> thanks
> Lucas De Marchi
>
>>
>> Daniele Ceraolo Spurio (6):
>>  Revert "drm/xe/huc: Define BMG HuC"
>>  Revert "drm/xe/gsc: define GSC FW for LNL"
>>  Revert "drm/xe/huc: Define LNL HuC"
>>  drm/xe/huc: Define HuC binary for LNL
>>  drm/xe/gsc: Define GSC binary for LNL
>>  drm/xe/huc: Define HuC binary for BMG
>>
>> drivers/gpu/drm/xe/xe_uc_fw.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> -- 
>> 2.43.0
>>