Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v8 2/3] drm/xe: Use FORCEWAKE_GT in xe_guc_pc_fini_hw()
Date: Thu, 5 Feb 2026 00:05:06 +0100	[thread overview]
Message-ID: <de7a555b-0bc0-4198-97db-bfcc53344621@intel.com> (raw)
In-Reply-To: <20260204014234.2867763-3-vinay.belgaumkar@intel.com>



On 2/4/2026 2:42 AM, Vinay Belgaumkar wrote:
> No need to use FORCEWAKE_ALL since the registers being written are in
> GT domain.
> 
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_pc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index c8313e308f96..878eb273c3e6 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -1300,7 +1300,7 @@ static void xe_guc_pc_fini_hw(void *arg)
>  	if (xe_device_wedged(xe))
>  		return;
>  
> -	CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FORCEWAKE_ALL);
> +	CLASS(xe_force_wake, fw_ref)(gt_to_fw(pc_to_gt(pc)), XE_FW_GT);
>  	XE_WARN_ON(xe_guc_pc_stop(pc));
>  
>  	/* Bind requested freq to mert_freq_cap before unload */


  reply	other threads:[~2026-02-04 23:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  1:42 [PATCH v8 0/3] drm/xe: Separate out GuC RC code Vinay Belgaumkar
2026-02-04  1:42 ` [PATCH v8 1/3] drm/xe: Decouple GuC RC code from xe_guc_pc Vinay Belgaumkar
2026-02-04  1:42 ` [PATCH v8 2/3] drm/xe: Use FORCEWAKE_GT in xe_guc_pc_fini_hw() Vinay Belgaumkar
2026-02-04 23:05   ` Michal Wajdeczko [this message]
2026-02-04  1:42 ` [PATCH v8 3/3] drm/xe: Add a wrapper for SLPC set/unset params Vinay Belgaumkar
2026-02-04  1:51 ` ✗ CI.checkpatch: warning for drm/xe: Separate out GuC RC code (rev5) Patchwork
2026-02-04  1:53 ` ✓ CI.KUnit: success " Patchwork
2026-02-04  2:43 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-04 16:04 ` ✗ CI.checkpatch: warning for drm/xe: Separate out GuC RC code (rev6) Patchwork
2026-02-04 16:05 ` ✓ CI.KUnit: success " Patchwork
2026-02-04 16:24 ` ✗ Xe.CI.FULL: failure for drm/xe: Separate out GuC RC code (rev5) Patchwork
2026-02-04 16:57 ` ✗ Xe.CI.BAT: failure for drm/xe: Separate out GuC RC code (rev6) Patchwork
2026-02-04 20:28 ` ✓ Xe.CI.BAT: success " Patchwork
2026-02-05  3:04 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de7a555b-0bc0-4198-97db-bfcc53344621@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox