Re: [PATCH v2 2/4] drm/xe/stolen: unify interface with i915

["Govindapillai, Vinod" <vinod.govindapillai@intel.com>]

On Fri, 2025-12-05 at 12:30 +0200, Jani Nikula wrote:
> Have i915_gem_stolen_node_offset() return u64, and pass const pointer
> to
> them.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h | 4 ++-
> -
>  drivers/gpu/drm/xe/display/xe_stolen.c                       | 4 ++-
> -
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> 
> diff --git a/drivers/gpu/drm/xe/compat-i915-
> headers/gem/i915_gem_stolen.h b/drivers/gpu/drm/xe/compat-i915-
> headers/gem/i915_gem_stolen.h
> index 48e3256ba37e..368045a470d1 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h
> @@ -23,13 +23,13 @@ bool i915_gem_stolen_initialized(struct
> drm_device *drm);
>  
>  bool i915_gem_stolen_node_allocated(const struct intel_stolen_node
> *node);
>  
> -u32 i915_gem_stolen_node_offset(struct intel_stolen_node *node);
> +u64 i915_gem_stolen_node_offset(const struct intel_stolen_node
> *node);
>  
>  u64 i915_gem_stolen_area_address(struct drm_device *drm);
>  
>  u64 i915_gem_stolen_area_size(struct drm_device *drm);
>  
> -u64 i915_gem_stolen_node_address(struct intel_stolen_node *node);
> +u64 i915_gem_stolen_node_address(const struct intel_stolen_node
> *node);
>  
>  u64 i915_gem_stolen_node_size(const struct intel_stolen_node *node);
>  
> diff --git a/drivers/gpu/drm/xe/display/xe_stolen.c
> b/drivers/gpu/drm/xe/display/xe_stolen.c
> index 9f04ba36e930..387506586288 100644
> --- a/drivers/gpu/drm/xe/display/xe_stolen.c
> +++ b/drivers/gpu/drm/xe/display/xe_stolen.c
> @@ -67,7 +67,7 @@ bool i915_gem_stolen_node_allocated(const struct
> intel_stolen_node *node)
>  	return node->bo;
>  }
>  
> -u32 i915_gem_stolen_node_offset(struct intel_stolen_node *node)
> +u64 i915_gem_stolen_node_offset(const struct intel_stolen_node
> *node)
>  {
>  	struct xe_res_cursor res;
>  
> @@ -91,7 +91,7 @@ u64 i915_gem_stolen_area_size(struct drm_device
> *drm)
>  	return 0;
>  }
>  
> -u64 i915_gem_stolen_node_address(struct intel_stolen_node *node)
> +u64 i915_gem_stolen_node_address(const struct intel_stolen_node
> *node)
>  {
>  	struct xe_device *xe = node->xe;
>