Re: [PATCH v2 4/5] drm/i915/power: convert intel_wakeref_t to struct ref_tracker *

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 01 Dec 2025, Luca Coelho <luca@coelho.fi> wrote:
> On Tue, 2025-11-25 at 15:24 +0200, Jani Nikula wrote:
>> diff --git a/drivers/gpu/drm/xe/display/xe_display_rpm.c b/drivers/gpu/drm/xe/display/xe_display_rpm.c
>> index 340f65884812..9416ec784e39 100644
>> --- a/drivers/gpu/drm/xe/display/xe_display_rpm.c
>> +++ b/drivers/gpu/drm/xe/display/xe_display_rpm.c
>> @@ -5,6 +5,7 @@
>>  
>>  #include "intel_display_core.h"
>>  #include "intel_display_rpm.h"
>> +#include "intel_wakeref.h"
>
> Just to be sure this is not a stray change, why did you add it here?

I was pretty sure it was required, maybe depending on some kconfig,
because the include is being removed in some other places, but I can't
reproduce the fail now.

I'd say not a huge problem because it's being removed in the next patch
no matter what.

BR,
Jani.


>
>
>>  #include "xe_device.h"
>>  #include "xe_device_types.h"
>>  #include "xe_pm.h"
>
> Regardless:
>
> Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
>
> --
> Cheers,
> Luca.

-- 
Jani Nikula, Intel