From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A051ACD5496 for ; Tue, 19 Sep 2023 07:49:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F8DF10E366; Tue, 19 Sep 2023 07:49:48 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7DE5710E361 for ; Tue, 19 Sep 2023 07:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695109787; x=1726645787; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=RFjWhbB27q8fLqg7msrC17v0t1M1OC/pUBnB77FW1Yw=; b=GoGiiKTVapltL8W6tAun/7hD8TFRWCuwIR+cnSdwPAKY6CWjbr5W3WVG aP2ZUbfHBjIHV8GLs8nQblIhdVQTUGkxlAiYKzZHQDHWkel6/v81tgEFv +GCP70QW6zqOhto2jpUbO4ihUfbPhs023cyFG8Ov0oBZIZACXvOwgH5wC j208T72uGZtFabYNLqan9FaUlMDh2khJF+Jd2RhpTjGcCWSqLWz4qjVjf r4ZK4RH6RXsuGuoteiRy5tDh90NViGDoKJsKpg/LrPdGcR4GprK2MMxCL md9S3yDXeDPPTzV6VndaoIottBFCgqnmfnUtlishtOCeAnr2ob25yEpZx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="364924794" X-IronPort-AV: E=Sophos;i="6.02,158,1688454000"; d="scan'208";a="364924794" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 00:49:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="993073455" X-IronPort-AV: E=Sophos;i="6.02,158,1688454000"; d="scan'208";a="993073455" Received: from aravind-dev.iind.intel.com (HELO [10.145.162.80]) ([10.145.162.80]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 00:49:41 -0700 Message-ID: Date: Tue, 19 Sep 2023 13:29:26 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-xe@lists.freedesktop.org References: <20230919063611.14236-1-aravind.iddamsetty@linux.intel.com> <03b5e4bf-f98d-c839-3e49-681712d828fe@linux.intel.com> From: Aravind Iddamsetty In-Reply-To: <03b5e4bf-f98d-c839-3e49-681712d828fe@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Intel-xe] [PATCH] drm/xe: Fix kernel doc warning for PMU events X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lucas De Marchi Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 19/09/23 13:16, Thomas Hellström wrote: > +Lucas for any --fixup comments. > > Hi, Aravind. > > On 9/19/23 08:36, Aravind Iddamsetty wrote: >> Add DOC keyword to PMU events comment in include/drm/xe_drm.h to make it >> kernel doc format. >> >> Fixes: 4a9681392cec ("drm/xe/pmu: Enable PMU interface") > > Since we're still rebasing xe, The above commit hash will soon be stale, so  I think the proper way to add this is to do > > git commit --fixup= Hi Thomas, Thanks for your comment. Ashutosh had suggested the same, so I had modified and merged the change. Thanks, Aravind. > > >> >> Signed-off-by: Aravind Iddamsetty >> --- >>   include/uapi/drm/xe_drm.h | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h >> index 63863eda8355..6ab85c7fed36 100644 >> --- a/include/uapi/drm/xe_drm.h >> +++ b/include/uapi/drm/xe_drm.h >> @@ -1054,7 +1054,7 @@ struct drm_xe_vm_madvise { >>   }; >>     /** >> - * XE PMU event config IDs >> + * DOC: XE PMU event config IDs >>    * >>    * Check 'man perf_event_open' to use these ID's in 'struct perf_event_attr' >>    * as part of perf_event_open syscall to read a particular event. > > Otherwise LGTM. > > Reviewed-by: Thomas Hellström > >