Re: [PATCH v2 10/29] drm/gpuvm: Add DRM_GPUVA_OP_USER

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Tue, 2024-10-15 at 20:24 -0700, Matthew Brost wrote:
> Add DRM_GPUVA_OP_USER which allows driver to define their own gpuvm
> ops.
> 
> Cc: Danilo Krummrich <dakr@redhat.com>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>  include/drm/drm_gpuvm.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/drm/drm_gpuvm.h b/include/drm/drm_gpuvm.h
> index 00d4e43b76b6..cc3f8ed5113b 100644
> --- a/include/drm/drm_gpuvm.h
> +++ b/include/drm/drm_gpuvm.h
> @@ -812,6 +812,11 @@ enum drm_gpuva_op_type {
>  	 * @DRM_GPUVA_OP_PREFETCH: the prefetch op type
>  	 */
>  	DRM_GPUVA_OP_PREFETCH,
> +
> +	/**
> +	 * @DRM_GPUVA_OP_USER: the user defined op type
> +	 */
> +	DRM_GPUVA_OP_USER,

Perhaps _OP_DRIVER, But Danilo might want to chime in.

Otherwise LGTM.
Thanks,
Thomas



>  };
>  
>  /**