From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4575BD0BB73 for ; Thu, 24 Oct 2024 08:53:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 13A6B10E8B3; Thu, 24 Oct 2024 08:53:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="dM8x/wCz"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49BA810E246; Thu, 24 Oct 2024 08:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729759979; x=1761295979; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=DNf5vyaAy97cBjT+9ncS9FQcr815rIqZqus+axexMjE=; b=dM8x/wCzWjv3ExYtNGZf46WS1zrJwgUNhi+6/O+TkJdeI4uXNKyssM8g YozYN49fpAK18CB7gXnKoCigptcMcsbg7XHHmyGDKnY2R0kuWwqJom7RU dBwyed6valELfQzNxHxGS8C0s6Wx2wEhFuDcyL5xoR93is1CsjiNaMJOz NIA/CkZ2bSxJqh44V4yqeQRhmSN8fCWjH44BaOB4/5/2DguWnZjDpD0/K TIyEQtkl4vqNHeN8MFxAMWtIOcsjuW5OOliLAaJlmn7jfohHXj/VegZOh +8xEsBmS7rvbWVjMSN7jaaIx6ycfyHM27b0ZmTEaexjfDMOKBKLEaKInX A==; X-CSE-ConnectionGUID: 9Pz8tHjPRcyG8cFkEMy5Yw== X-CSE-MsgGUID: zgsgL1V1Q3GX/jW7YHfwNQ== X-IronPort-AV: E=McAfee;i="6700,10204,11234"; a="17005894" X-IronPort-AV: E=Sophos;i="6.11,228,1725346800"; d="scan'208";a="17005894" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2024 01:52:59 -0700 X-CSE-ConnectionGUID: lJ8oE/ByQqCLQwUyO1mlJw== X-CSE-MsgGUID: R3VzJx5LTI+C9Y1GJIVkwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,228,1725346800"; d="scan'208";a="80699083" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO [10.245.245.216]) ([10.245.245.216]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2024 01:52:57 -0700 Message-ID: Date: Thu, 24 Oct 2024 09:52:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/9] drm/xe: Add xe_ttm_access_memory To: Matthew Brost , intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: mika.kuoppala@intel.com, thomas.hellstrom@linux.intel.com References: <20241021211835.1675640-1-matthew.brost@intel.com> <20241021211835.1675640-4-matthew.brost@intel.com> Content-Language: en-GB From: Matthew Auld In-Reply-To: <20241021211835.1675640-4-matthew.brost@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 21/10/2024 22:18, Matthew Brost wrote: > Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible > VRAM easily be accessed. Add xe_ttm_access_memory which hooks into > ttm_bo_access to access such memory. > > v4: > - Assert memory access rather than taking RPM ref (Thomas / Auld) > - Fix warning on xe_res_cursor.h for non-zero offset (Mika) > > Reported-by: Christoph Manszewski > Suggested-by: Thomas Hellström > Signed-off-by: Matthew Brost Reviewed-by: Matthew Auld