Re: [PATCH] drm/xe: remove unused struct xe_device members

["Souza, Jose" <jose.souza@intel.com>]

On Thu, 2024-03-21 at 18:15 +0200, Jani Nikula wrote:
> modeset_restore_state has been unused since commit 6af0ffc0db93
> ("drm/i915/display: move restore state and ctx under display
> sub-struct").
> 
> member global_obj_list has been unused since commit e2925e19c006
> ("drm/i915/display: move global_obj_list under display sub-struct").
> 
> hti_state has been unused since commit 62749912540b ("drm/i915/display:
> move hti under display sub-struct").
> 
> snps_phy_failed_calibration has been unused since commit 3a7e2d58f800
> ("drm/i915: move snps_phy_failed_calibration to display sub-struct under
> snps").
> 

Reviewed-by: José Roberto de Souza <jose.souza@intel.com>

> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device_types.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 9785eef2e5a4..1df3dcc17d75 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -498,10 +498,7 @@ struct xe_device {
>  	struct mutex sb_lock;
>  
>  	/* Should be in struct intel_display */
> -	u32 skl_preferred_vco_freq, max_dotclk_freq, hti_state;
> -	u8 snps_phy_failed_calibration;
> -	struct drm_atomic_state *modeset_restore_state;
> -	struct list_head global_obj_list;
> +	u32 skl_preferred_vco_freq, max_dotclk_freq;
>  
>  	union {
>  		/* only to allow build, not used functionally */