Re: [PATCH 05/14] drm/xe/pf: Add functions to bulk configure EQ/PT on GT

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10/27/2025 8:03 PM, Lucas De Marchi wrote:
> On Mon, Oct 20, 2025 at 08:24:05PM +0200, Michal Wajdeczko wrote:
>> We already have functions to bulk configure 'hard' resources like
>> GGTT, LMEM or GuC context/doorbells IDs. Now add functions for the
>> 'soft' scheduling parameters, as we will need them soon in the
>> upcoming patches.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> ---
>> drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 56 ++++++++++++++++++++++
>> drivers/gpu/drm/xe/xe_gt_sriov_pf_config.h |  2 +
>> 2 files changed, 58 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
>> index 0a591b86d94e..99d5fb68174c 100644
>> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
>> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
>> @@ -1778,6 +1778,34 @@ u32 xe_gt_sriov_pf_config_get_exec_quantum(struct xe_gt *gt, unsigned int vfid)
>>     return exec_quantum;
>> }
>>
>> +/**
>> + * xe_gt_sriov_pf_config_bulk_set_exec_quantum() - Configure execution quantum for PF and VFs.
>> + * @gt: the &xe_gt to configure
>> + * @exec_quantum: requested execution quantum in milliseconds (0 is infinity)
>> + *
>> + * This function can only be called on PF.
>> + *
>> + * Return: 0 on success or a negative error code on failure.
>> + */
>> +int xe_gt_sriov_pf_config_bulk_set_exec_quantum(struct xe_gt *gt, u32 exec_quantum)
>> +{
>> +    unsigned int totalvfs = xe_gt_sriov_pf_get_totalvfs(gt);
>> +    unsigned int n;
>> +    int err = 0;
>> +
>> +    mutex_lock(xe_gt_sriov_pf_master_mutex(gt));
>> +    for (n = 0; n <= totalvfs; n++) {
>> +        err = pf_provision_exec_quantum(gt, VFID(n), exec_quantum);
> 
> Given now the function accepts PFID, it's weird to pass VFID(n).

PFID is still VFID(0)

> Any advantage on using that nop macro?

the function pf_provision_exec_quantum() expects "vfid" anyway
so use of the macro was supposed to be self-documenting that
we are not passing any random integer here

but I can drop this macro here if you want

> 
> 
> Lucas De Marchi