Re: [PATCH v2 4/4] drm/xe/ct: drop irq usage of xa_erase()

["Nilawar, Badal" <badal.nilawar@intel.com>]

On 01-10-2024 14:13, Matthew Auld wrote:
> Unclear why disabling interrupts is needed here. Nothing seems to be
> touching fence_lookup and its corresponding lock from an irq so there
> should be no risk of deadlock.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc_ct.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index d3de2e6d690f..3fd1d4e97528 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -890,7 +890,7 @@ static int guc_ct_send_recv(struct xe_guc_ct *ct, const u32 *action, u32 len,
>   			goto retry_same_fence;
>   
>   		if (!g2h_fence_needs_alloc(&g2h_fence))
> -			xa_erase_irq(&ct->fence_lookup, g2h_fence.seqno);
> +			xa_erase(&ct->fence_lookup, g2h_fence.seqno);
>   
>   		return ret;
>   	}
> @@ -907,7 +907,7 @@ static int guc_ct_send_recv(struct xe_guc_ct *ct, const u32 *action, u32 len,
>   	if (!ret) {
>   		xe_gt_err(gt, "Timed out wait for G2H, fence %u, action %04x, done %s",
>   			  g2h_fence.seqno, action[0], str_yes_no(g2h_fence.done));
> -		xa_erase_irq(&ct->fence_lookup, g2h_fence.seqno);
> +		xa_erase(&ct->fence_lookup, g2h_fence.seqno);

Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Regards,
Badal
>   		mutex_unlock(&ct->lock);
>   		return -ETIME;
>   	}