Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: John.C.Harrison@Intel.com, Intel-Xe@Lists.FreeDesktop.Org
Subject: Re: [PATCH v3 1/2] drm/xe/guc: Remove spurious line feed in debug print
Date: Thu, 9 May 2024 12:18:48 +0200	[thread overview]
Message-ID: <eaf746a4-0bb8-4d98-b48a-786400cb073b@intel.com> (raw)
In-Reply-To: <20240508224927.11341-2-John.C.Harrison@Intel.com>



On 09.05.2024 00:49, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> Including line feeds at the start of a debug print messes up the
> output when sent to dmesg. The break actually appears between all the
> usefu prefix information and the actual string being printed. In this

typo

> case, each block of data has a very clear start line and an extra
> delimeter is really not necessary. So don't do it.
> 

this was also on my to-fix list,

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
> index 0151d29b3c58..ecbf0b116cc3 100644
> --- a/drivers/gpu/drm/xe/xe_guc_ct.c
> +++ b/drivers/gpu/drm/xe/xe_guc_ct.c
> @@ -1435,7 +1435,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
>  		drm_puts(p, "H2G CTB (all sizes in DW):\n");
>  		guc_ctb_snapshot_print(&snapshot->h2g, p);
>  
> -		drm_puts(p, "\nG2H CTB (all sizes in DW):\n");
> +		drm_puts(p, "G2H CTB (all sizes in DW):\n");
>  		guc_ctb_snapshot_print(&snapshot->g2h, p);
>  
>  		drm_printf(p, "\tg2h outstanding: %d\n",

  reply	other threads:[~2024-05-09 10:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 22:49 [PATCH v3 0/2] Imrpove GuC debug log/status output John.C.Harrison
2024-05-08 22:49 ` [PATCH v3 1/2] drm/xe/guc: Remove spurious line feed in debug print John.C.Harrison
2024-05-09 10:18   ` Michal Wajdeczko [this message]
2024-05-08 22:49 ` [PATCH v3 2/2] drm/xe/guc: Improve robustness of GuC log dumping to dmesg John.C.Harrison
2024-05-13 15:21   ` Dong, Zhanjun
2024-05-13 17:13     ` John Harrison
2024-05-14 17:32       ` Dong, Zhanjun
2024-05-14 18:18         ` John Harrison
2024-05-14 16:01   ` Michal Wajdeczko
2024-05-14 18:31     ` John Harrison
2024-05-14 21:05       ` Michal Wajdeczko
2024-05-16  0:00         ` John Harrison
2024-05-08 22:54 ` ✓ CI.Patch_applied: success for Imrpove GuC debug log/status output Patchwork
2024-05-08 22:55 ` ✓ CI.checkpatch: " Patchwork
2024-05-08 22:56 ` ✓ CI.KUnit: " Patchwork
2024-05-08 23:07 ` ✓ CI.Build: " Patchwork
2024-05-08 23:10 ` ✓ CI.Hooks: " Patchwork
2024-05-08 23:11 ` ✓ CI.checksparse: " Patchwork
2024-05-08 23:47 ` ✓ CI.BAT: " Patchwork
2024-05-09 12:21 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaf746a4-0bb8-4d98-b48a-786400cb073b@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    --cc=John.C.Harrison@Intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox