From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F561D0EE18 for ; Tue, 25 Nov 2025 19:42:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B189E10E444; Tue, 25 Nov 2025 19:42:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="hmdHkdCr"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A84C510E082; Tue, 25 Nov 2025 19:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764099722; x=1795635722; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=PI386nP+RcPyvriG3AEkYN5yihnLI+NdFE4WUucODGc=; b=hmdHkdCrZJImAcCPMwCNkSzA2jJ2Q2gfZ/ONdcp8LkjMr97pAkUPeYif sosUG72pZBDJkZUpXhQyKXT3/UGNntIbjaU4s7U2+k6qBlz7963O34j+M ndrxytGpjuJywBxcy9ms+oCNrBsk6t3i4Exdda8S01ZtXaZ1rowdBo2Pr 0YHhPLxq89mnhfLnj5zG7CeNmedKytqsKx6icRtFMCgzDBMfMjcaYObJz xHAh6vpZRdi5wudGDEFfKo7tL87qr9I6867br/0dFsMaAGccwFzkHkI+V 6s/3dWbBNH89wGDl3/CBafarhjAAF2bRrfdBOh5d6QA/9CYqcD0yXt9pq w==; X-CSE-ConnectionGUID: tvK7au/WQ7OEl4NkGjxmqA== X-CSE-MsgGUID: Z7xNouo4RA2AAxmsdAG8bg== X-IronPort-AV: E=McAfee;i="6800,10657,11624"; a="66207335" X-IronPort-AV: E=Sophos;i="6.20,226,1758610800"; d="scan'208";a="66207335" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2025 11:42:01 -0800 X-CSE-ConnectionGUID: 0g2ILfIYS3qnUdxYneHYhw== X-CSE-MsgGUID: zhOy77ImSY2BS36uN9xKGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,226,1758610800"; d="scan'208";a="192631831" Received: from ettammin-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.213]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2025 11:42:00 -0800 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 0/6] drm/i915: uapi vs. hw state fixes In-Reply-To: <20251119181606.17129-1-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20251119181606.17129-1-ville.syrjala@linux.intel.com> Date: Tue, 25 Nov 2025 21:41:56 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 19 Nov 2025, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Spotted a few places using the uapi state when they most > likely should have been using the hw state. Fix those up. Reviewed-by: Jani Nikula > > Ville Syrj=C3=A4l=C3=A4 (6): > drm/i915: Use the proper (hw.crtc) for the cursor unpin vblank worker > drm/i915/psr: Use hw.crtc instead of uapi.crtc > drm/i915/psr: Use hw.rotation instead of uapi.rotation > drm/i915: Use hw.active instead of uapi.active in the initial plane > readout > drm/i915/panic: Get the crtc from the correct place > drm/i915/panic: Clean up the variables > > drivers/gpu/drm/i915/display/intel_crtc.c | 4 +- > drivers/gpu/drm/i915/display/intel_plane.c | 58 +++++++++---------- > .../drm/i915/display/intel_plane_initial.c | 6 +- > drivers/gpu/drm/i915/display/intel_psr.c | 12 ++-- > drivers/gpu/drm/i915/display/intel_psr.h | 3 +- > drivers/gpu/drm/xe/display/xe_plane_initial.c | 6 +- > 6 files changed, 45 insertions(+), 44 deletions(-) --=20 Jani Nikula, Intel