From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE4CB10A88D2 for ; Thu, 26 Mar 2026 15:22:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7178610E94D; Thu, 26 Mar 2026 15:22:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="KrtnOYUx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DD8E10E385; Thu, 26 Mar 2026 15:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774538572; x=1806074572; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=BIuW72JNbr550nmWi2w0kAtsgSevh9fZB/gGJlWGL9E=; b=KrtnOYUxMZtNlmO46E6Ial8//GoHKAFGgvhNnfHYrq2Y8z1GgGHvwJsH 9S7O+UU3yXSg/5DktxMq1ymfnJse7BKiqBkZkKdTIn2BdauXU3wkjp6zn Bq+1i/sj+GL1wgas/iYWlv4lOmcqs00+6/NP/jmdVGsxr4XaN1iLGF3bM 8kFXszkCf+VFjJ2Fn+UJSB/36MDodZSUxkIp75kTn8iLAKysh7szdxB+j HgDeqPELauyYK8ZmQuZoT6mw1asCvp8z1Zlo867OIuJOf4E6SXbIIOeQf JRBJtz+KI7XgqqlHGuysRrxGh4T+Kae475Rg9OnCK3GbPZ66EFMYUNVBs w==; X-CSE-ConnectionGUID: skdK45zvTeeGbQca0/Fg5w== X-CSE-MsgGUID: hOt2nyw4TeieFBxet+EqOQ== X-IronPort-AV: E=McAfee;i="6800,10657,11741"; a="75314356" X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="75314356" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 08:22:52 -0700 X-CSE-ConnectionGUID: e/xM4SSbQUqSeqaasGF8kA== X-CSE-MsgGUID: f9TdAbB2S5qsAVVNAoqS9Q== X-ExtLoop1: 1 Received: from jkrzyszt-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.246.199]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 08:22:49 -0700 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 3/5] drm/i915/dsi: Make 'clock_stop' boolean In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260326111814.9800-1-ville.syrjala@linux.intel.com> <20260326111814.9800-4-ville.syrjala@linux.intel.com> <1558669af43583b072c8c58eff1e01960c2d9f8c@intel.com> <557b26b17545103834b9051b7165d8010a88f870@intel.com> Date: Thu, 26 Mar 2026 17:22:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, 26 Mar 2026, Ville Syrj=C3=A4l=C3=A4 wrote: > On Thu, Mar 26, 2026 at 05:01:33PM +0200, Jani Nikula wrote: >> On Thu, 26 Mar 2026, Ville Syrj=C3=A4l=C3=A4 wrote: >> > On Thu, Mar 26, 2026 at 03:40:56PM +0200, Jani Nikula wrote: >> >> On Thu, 26 Mar 2026, Ville Syrjala wr= ote: >> >> > From: Ville Syrj=C3=A4l=C3=A4 >> >> > >> >> > The DSI 'clock_stop' parameter is a boolean, so use a real >> >> > 'bool' for it. And pimp the debug print while at it. >> >> > >> >> > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 >> >> > --- >> >> > drivers/gpu/drm/i915/display/intel_dsi.h | 2 +- >> >> > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++-- >> >> > 2 files changed, 3 insertions(+), 3 deletions(-) >> >> > >> >> > diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu= /drm/i915/display/intel_dsi.h >> >> > index 8e39d2b52c54..0023ac341aa0 100644 >> >> > --- a/drivers/gpu/drm/i915/display/intel_dsi.h >> >> > +++ b/drivers/gpu/drm/i915/display/intel_dsi.h >> >> > @@ -81,7 +81,7 @@ struct intel_dsi { >> >> > int video_mode; >> >> >=20=20 >> >> > bool eot_pkt; >> >> > - u8 clock_stop; >> >> > + bool clock_stop; >> >> >=20=20 >> >> > u8 escape_clk_div; >> >> > u8 dual_link; >> >> > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers= /gpu/drm/i915/display/intel_dsi_vbt.c >> >> > index 51f6a5b82cb2..23da7f5f9578 100644 >> >> > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> >> > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c >> >> > @@ -719,7 +719,7 @@ void intel_dsi_log_params(struct intel_dsi *int= el_dsi) >> >> > drm_printf(&p, "Burst mode ratio %d\n", intel_dsi->burst_mode_rat= io); >> >> > drm_printf(&p, "Reset timer %d\n", intel_dsi->rst_timer_val); >> >> > drm_printf(&p, "EoT packet %s\n", str_enabled_disabled(intel_dsi-= >eot_pkt)); >> >> > - drm_printf(&p, "Clockstop %s\n", str_enabled_disabled(!intel_dsi-= >clock_stop)); >> >> > + drm_printf(&p, "Clock stop during BLLP %s\n", str_enabled_disable= d(intel_dsi->clock_stop)); >> >>=20 >> >> What's with the reversed !intel_dsi->clock_stop in the existing log a= nd >> >> the change here? >> > >> > I've had these sitting around for a while so completely forgot I chang= ed >> > it. >> > >> > Looks that it's been wrong since the initial commit. >> > >> > Apparently v2 of the patch >> > https://lore.kernel.org/intel-gfx/1397454507-10273-5-git-send-email-sh= obhit.kumar@intel.com/ >> > had it the correct way around, but then it got messed in >> > in v3 while the capital letters were being made lowercase. >> > >> > I can split that out into its own patch with that explanation. >>=20 >> Not sure I care enough, other than please mention it in the commit >> message. Unless you specifically want that fix backported too. > > Nah. I guess I'll just amend the commit message a bit. Also, Reviewed-by: Jani Nikula --=20 Jani Nikula, Intel