Re: [PATCH v2] drm/xe: Adjust page count tracepoints in shrinker

["Summers, Stuart" <stuart.summers@intel.com>]

On Wed, 2026-01-07 at 12:57 -0800, Matthew Brost wrote:
> Page accounting can change via the shrinker without calling
> xe_ttm_tt_unpopulate(), which normally updates page count tracepoints
> through update_global_total_pages. Add a call to
> update_global_total_pages when the shrinker successfully shrinks a
> BO.
> 
> v2:
>  - Don't adjust global accounting when pinning (Stuart)
> 
> Cc: stable@vger.kernel.org
> Fixes: ce3d39fae3d3 ("drm/xe/bo: add GPU memory trace points")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_bo.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
> index 8b6474cd3eaf..6ab52fa397e3 100644
> --- a/drivers/gpu/drm/xe/xe_bo.c
> +++ b/drivers/gpu/drm/xe/xe_bo.c
> @@ -1054,6 +1054,7 @@ static long xe_bo_shrink_purge(struct
> ttm_operation_ctx *ctx,
>                                unsigned long *scanned)
>  {
>         struct xe_device *xe = ttm_to_xe_device(bo->bdev);
> +       struct ttm_tt *tt = bo->ttm;
>         long lret;
>  
>         /* Fake move to system, without copying data. */
> @@ -1078,8 +1079,10 @@ static long xe_bo_shrink_purge(struct
> ttm_operation_ctx *ctx,
>                               .writeback = false,
>                               .allow_move = false});
>  
> -       if (lret > 0)
> +       if (lret > 0) {
>                 xe_ttm_tt_account_subtract(xe, bo->ttm);
> +               update_global_total_pages(bo->bdev, -(long)tt-
> >num_pages);
> +       }
>  
>         return lret;
>  }
> @@ -1165,8 +1168,10 @@ long xe_bo_shrink(struct ttm_operation_ctx
> *ctx, struct ttm_buffer_object *bo,
>         if (needs_rpm)
>                 xe_pm_runtime_put(xe);
>  
> -       if (lret > 0)
> +       if (lret > 0) {
>                 xe_ttm_tt_account_subtract(xe, tt);
> +               update_global_total_pages(bo->bdev, -(long)tt-
> >num_pages);
> +       }
>  
>  out_unref:
>         xe_bo_put(xe_bo);